From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2B83AA0C4B;
	Tue,  9 Nov 2021 03:10:51 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 96D4640E28;
	Tue,  9 Nov 2021 03:10:50 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id DB59A4068B
 for <dev@dpdk.org>; Tue,  9 Nov 2021 03:10:49 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id EB77D20B9D59; Mon,  8 Nov 2021 18:10:48 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EB77D20B9D59
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1636423848;
 bh=LKmlFIkUv4WiwtyhgPI15uAw9wbzNUNfo1wiu5QgmGo=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=oCgIx6PVAP/tgFvsHZvvFZhX4Dn8mMc8WQfYmTaD1dikc98Dcp3hUnbQ5v9sVaBOG
 AJRUGR+BxeShlnZIIzvrO3w54wlGR9bZ3XdKBN/7devMLoyiPAKQ/EJ+vO4alNCJwN
 HIEV6vGfR9Xz2/dqA4CeBBrTb//lhC9wdTZB5AF4=
Date: Mon, 8 Nov 2021 18:10:48 -0800
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, khot@microsoft.com,
 dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com,
 ocardona@microsoft.com, bruce.richardson@intel.com,
 david.marchand@redhat.com, pallavi.kadam@intel.com
Message-ID: <20211109021048.GF12569@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1633732841-17873-1-git-send-email-navasile@linux.microsoft.com>
 <1633765318-28356-1-git-send-email-navasile@linux.microsoft.com>
 <1633765318-28356-10-git-send-email-navasile@linux.microsoft.com>
 <4938958.YfKOMBFpFK@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4938958.YfKOMBFpFK@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v16 9/9] Add unit tests for thread API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Oct 12, 2021 at 06:33:16PM +0200, Thomas Monjalon wrote:
> 09/10/2021 09:41, Narcisa Ana Maria Vasile:
> > From: Narcisa Vasile <navasile@microsoft.com>
> > 
> > As a new API for threading is introduced,
> > a set of unit tests have been added to test the new interface.
> > The tests verify that:
> >  * mutexes and barriers behave as expected
> >  * thread properties are applied correctly
> >  * the thread id is retrieved correctly
> >  * thread creation/destruction works properly
> 
> Please make each test part of the patch implementing the feature.
> Thanks
> 
Makes sense, but most of these unit tests use rte_thread_create and
rte_thread_join to handle the creation and cleanup of the threads
that are being tested, so I'm forced to have this test patch at the end.
I could still break it up into smaller patches, one for each test category
(mutex, attributes, etc) if you want.