From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02A2EA034F; Tue, 9 Nov 2021 13:36:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 883A841109; Tue, 9 Nov 2021 13:36:39 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2079.outbound.protection.outlook.com [40.107.220.79]) by mails.dpdk.org (Postfix) with ESMTP id 5D2D24111F; Tue, 9 Nov 2021 13:36:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oNjtDG9XyDlFAhQSpkIrCUygggTxpGYCdK4I3/7wJeGVu6FLO2/2+EMPLHP87Oq+NS3b0FxrXk3zY6Zj4gBGN+IDzJIY9cjMnmqvUUxiJG3zyrKxAAETmY79UQ1rapAgfWx0lBcoiR6CU4/OmHLl6aoAeCSnql8ftfYrjg2aAeblqkR1jxuo96JjGKoIJH6Fj/JZ8/fVBA1XiXPLG/IyK3gq/lWn7ISOqIbJJvBkehUoRTCDedV0g61tn2q9/r3lRLA5rK7yGS9BuH02F901rQf0FpMI5w+DhLjNdA+QHWyf61DwM0cEvw9jbAjaa66tESIfRwMhZzlrulopIXeLvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JbSiq0Jb2dAj8yS4KE41fYV2IQ6dTZaQqpNBhyXCES4=; b=ZwENHkxCUkm6kgYop0sp/evR9iFNZCgKax8DQxh1Ilr6yNo+ktpYVKIod26Yab2OwBqB+nBl6ZZO9FFMgKqV2gG53Jk7U3V+5Djo+BXNQ4TlARmzs43Pde9bAqGJcZA5bRyuRXIlJ3VWRpd/T4/GBJyOvsr96g+rPrs6aqhw7wjLTXYpNrt+S20JbYovq4ELlv0PTUfzPXR0epqcs++quBifH2VcVTgj94bBqG5VvQn/mQ+5EFnhgV1wsOZNudasqBbBUkOuKhOOmHPacL2DRs659Rk9Bnx+VZu/LB/qqiqAKOaREgDzv6Mqh9qtG2R5jxJnHSpY0nR3lrXZeagF3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JbSiq0Jb2dAj8yS4KE41fYV2IQ6dTZaQqpNBhyXCES4=; b=XG8136Q+H8UgXNwXZ3TZZCiE0Q4qC22HMXprpVDrw+V7aG1RCve869kzqiwM0Nx1gkR8smjzh2AoYenzQe2Dx5ty4gdNR4fbBAFfG5egdu8op6zCMkAFxzp7pBhaom+giqAw9lBRPzALMQPcB+ouPinru/kO/9bqRvhlT1POcE4RmjzYlI1RMJGV/AYsfkmUDZa7vFvJEPVSIpIOHtiD6de1J14b5gsKZNFAuvRciUEBSKgNRWerAD36IIKTX3QPV1dom2DGMTlz98fbiw/KiAV5Sfnt00tTs9SX2bPJxViYASzTKbedubCRU8oVSRafgDqKfvtf5BVde/2hTYGWDA== Received: from MWHPR15CA0056.namprd15.prod.outlook.com (2603:10b6:301:4c::18) by BY5PR12MB4068.namprd12.prod.outlook.com (2603:10b6:a03:203::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Tue, 9 Nov 2021 12:36:36 +0000 Received: from CO1NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:301:4c:cafe::b7) by MWHPR15CA0056.outlook.office365.com (2603:10b6:301:4c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Tue, 9 Nov 2021 12:36:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT065.mail.protection.outlook.com (10.13.174.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4669.10 via Frontend Transport; Tue, 9 Nov 2021 12:36:35 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 9 Nov 2021 12:36:31 +0000 From: Matan Azrad To: Viacheslav Ovsiienko CC: , Thomas Monjalon , , Michael Baum Date: Tue, 9 Nov 2021 14:36:09 +0200 Message-ID: <20211109123612.2301442-3-matan@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211109123612.2301442-1-matan@nvidia.com> References: <20211108172113.2241853-1-matan@nvidia.com> <20211109123612.2301442-1-matan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b371fd2c-9824-4587-63f8-08d9a37d91aa X-MS-TrafficTypeDiagnostic: BY5PR12MB4068: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: veSPd7EqTWkr/NpSc7fadSMWK5PxU174VzWhpB3K92BYFBIoYJ8chhjR7QIBYr3YFarcyIiMN5PBvyKcQkJunH2xgsQVqrZbwaA8c9sPdq6UXDAWmDNxiVVkPojj4GtqKI+t7Ir7t59d3T7zjQL+dEOt/U8fE1nPTuMxFmcT6w2CgsrRSIUhw+QvFK8Psw45Rcnp3hpFSZWiZFL1Nx04hXHz0ypi29o6x+TlbIfuznnVZqy2Amf+8q0wBdOy5QbagpqI1Iefx1VgfIIHlkYN57ObqXKh/2SYil63jzWRwnUeGxNjpUJSa2I6v+vbKop+g3zpkM2EYsC+qRXXsQhzEgYpqjqDbievz3lQGhxbQdhWTy45p4L148xU4P2tk8Hum/9R6OQCWYgZaUOQGgxv23O2m7n9t8N8I/qs5NknGLIhUu2EGqLQSA+G1afYz3vhKKNLA5yi3dn4Fo4V/qBt/KAzVqb7lB+P9qF2OjhzSnbzZjaFmZn3IKnXZ6twjpbQomq3rQq766yoM+ddUMk3WrB9diQC8ffzgJRI5bsMjhCDQh9+WDKOoHVR8cDxfqgNYNc5IBN9bHqn3WMt5964R/gPpGayFkVeEWxppBENBtJE/2JOVc9knoylIWTw3ZJh4xjPQWjSRTIIH11a4h+Z8R/VGnXeMmObT0PvCkW4VrQkbnIcneK/eKSF9FcrSO9bu0fql3EuoUzUEDUxz+QPyA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(2616005)(6286002)(4326008)(47076005)(426003)(6666004)(36756003)(83380400001)(336012)(55016002)(356005)(36860700001)(6862004)(107886003)(1076003)(2906002)(82310400003)(26005)(7636003)(86362001)(5660300002)(36906005)(6636002)(16526019)(7696005)(508600001)(70586007)(70206006)(8676002)(54906003)(37006003)(186003)(316002)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 12:36:35.8629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b371fd2c-9824-4587-63f8-08d9a37d91aa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4068 Subject: [dpdk-dev] [PATCH v3 2/5] common/mlx5: add wrapped MR create API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The mlx5 PMD uses the kernel mlx5 driver to map physical memory to the HW. Using the Verbs API ibv_reg_mr, a mkey can be created for that. In this case, the mkey is signed on the user ID of the kernel driver. Using the DevX API, a mkey also can be created, but it should point an umem object (represents the specific buffer mapping) created by the kernel. In this case, the mkey is signed on the user ID of the process DevX context. In FW DevX control commands which get mkey as a parameter, there is a security check on the user ID and Verbs mkeys are rejected. Unfortunately, also when using DevX mkey, there is an error in the FW command on umem validation because the umem is not designed to be used for any mkey parameters. As a workaround to the kernel driver/FW issue, it is needed to use a wrapped MR, which is an indirect mkey(created by the DevX API) pointing to direct mkey created by the kernel for any DevX command uses an MR. Add an API to create and destroy this wrapped MR. Fixes: 5382d28c2110 ("net/mlx5: accelerate DV flow counter transactions") Fixes: 9d39e57f21ac ("vdpa/mlx5: support live migration") Cc: stable@dpdk.org Signed-off-by: Michael Baum Signed-off-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c | 56 ++++++++++++++++++++ drivers/common/mlx5/mlx5_common.h | 18 +++++++ drivers/common/mlx5/version.map | 3 ++ drivers/common/mlx5/windows/mlx5_common_os.c | 40 ++++++++++++++ 4 files changed, 117 insertions(+) diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c index b516564b79..0d3e24e04e 100644 --- a/drivers/common/mlx5/linux/mlx5_common_os.c +++ b/drivers/common/mlx5/linux/mlx5_common_os.c @@ -744,3 +744,59 @@ mlx5_get_device_guid(const struct rte_pci_addr *dev, uint8_t *guid, size_t len) fclose(id_file); return ret; } + +/* + * Create direct mkey using the kernel ibv_reg_mr API and wrap it with a new + * indirect mkey created by the DevX API. + * This mkey should be used for DevX commands requesting mkey as a parameter. + */ +int +mlx5_os_wrapped_mkey_create(void *ctx, void *pd, uint32_t pdn, void *addr, + size_t length, struct mlx5_pmd_wrapped_mr *pmd_mr) +{ + struct mlx5_klm klm = { + .byte_count = length, + .address = (uintptr_t)addr, + }; + struct mlx5_devx_mkey_attr mkey_attr = { + .pd = pdn, + .klm_array = &klm, + .klm_num = 1, + }; + struct mlx5_devx_obj *mkey; + struct ibv_mr *ibv_mr = mlx5_glue->reg_mr(pd, addr, length, + IBV_ACCESS_LOCAL_WRITE | + (haswell_broadwell_cpu ? 0 : + IBV_ACCESS_RELAXED_ORDERING)); + + if (!ibv_mr) { + rte_errno = errno; + return -rte_errno; + } + klm.mkey = ibv_mr->lkey; + mkey_attr.addr = (uintptr_t)addr; + mkey_attr.size = length; + mkey = mlx5_devx_cmd_mkey_create(ctx, &mkey_attr); + if (!mkey) { + claim_zero(mlx5_glue->dereg_mr(ibv_mr)); + return -rte_errno; + } + pmd_mr->addr = addr; + pmd_mr->len = length; + pmd_mr->obj = (void *)ibv_mr; + pmd_mr->imkey = mkey; + pmd_mr->lkey = mkey->id; + return 0; +} + +void +mlx5_os_wrapped_mkey_destroy(struct mlx5_pmd_wrapped_mr *pmd_mr) +{ + if (!pmd_mr) + return; + if (pmd_mr->imkey) + claim_zero(mlx5_devx_cmd_destroy(pmd_mr->imkey)); + if (pmd_mr->obj) + claim_zero(mlx5_glue->dereg_mr(pmd_mr->obj)); + memset(pmd_mr, 0, sizeof(*pmd_mr)); +} diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h index 661d3ab235..e8809844af 100644 --- a/drivers/common/mlx5/mlx5_common.h +++ b/drivers/common/mlx5/mlx5_common.h @@ -509,4 +509,22 @@ mlx5_devx_uar_release(struct mlx5_uar *uar); int mlx5_os_open_device(struct mlx5_common_device *cdev, uint32_t classes); int mlx5_os_pd_create(struct mlx5_common_device *cdev); +/* mlx5 PMD wrapped MR struct. */ +struct mlx5_pmd_wrapped_mr { + uint32_t lkey; + void *addr; + size_t len; + void *obj; /* verbs mr object or devx umem object. */ + void *imkey; /* DevX indirect mkey object. */ +}; + +__rte_internal +int +mlx5_os_wrapped_mkey_create(void *ctx, void *pd, uint32_t pdn, void *addr, + size_t length, struct mlx5_pmd_wrapped_mr *pmd_mr); + +__rte_internal +void +mlx5_os_wrapped_mkey_destroy(struct mlx5_pmd_wrapped_mr *pmd_mr); + #endif /* RTE_PMD_MLX5_COMMON_H_ */ diff --git a/drivers/common/mlx5/version.map b/drivers/common/mlx5/version.map index 2335edf39d..8a62dc2782 100644 --- a/drivers/common/mlx5/version.map +++ b/drivers/common/mlx5/version.map @@ -134,6 +134,9 @@ INTERNAL { mlx5_os_umem_dereg; mlx5_os_umem_reg; + mlx5_os_wrapped_mkey_create; + mlx5_os_wrapped_mkey_destroy; + mlx5_realloc; mlx5_translate_port_name; # WINDOWS_NO_EXPORT diff --git a/drivers/common/mlx5/windows/mlx5_common_os.c b/drivers/common/mlx5/windows/mlx5_common_os.c index ea478d7395..0d03344343 100644 --- a/drivers/common/mlx5/windows/mlx5_common_os.c +++ b/drivers/common/mlx5/windows/mlx5_common_os.c @@ -390,3 +390,43 @@ mlx5_os_set_reg_mr_cb(mlx5_reg_mr_t *reg_mr_cb, mlx5_dereg_mr_t *dereg_mr_cb) *reg_mr_cb = mlx5_os_reg_mr; *dereg_mr_cb = mlx5_os_dereg_mr; } + +/* + * In Windows, no need to wrap the MR, no known issue for it in kernel. + * Use the regular function to create direct MR. + */ +int +mlx5_os_wrapped_mkey_create(void *ctx, void *pd, uint32_t pdn, void *addr, + size_t length, struct mlx5_pmd_wrapped_mr *wpmd_mr) +{ + struct mlx5_pmd_mr pmd_mr = {0}; + int ret = mlx5_os_reg_mr(pd, addr, length, &pmd_mr); + + (void)pdn; + (void)ctx; + if (ret != 0) + return -1; + wpmd_mr->addr = addr; + wpmd_mr->len = length; + wpmd_mr->obj = pmd_mr.obj; + wpmd_mr->imkey = pmd_mr.mkey; + wpmd_mr->lkey = pmd_mr.mkey->id; + return 0; +} + +void +mlx5_os_wrapped_mkey_destroy(struct mlx5_pmd_wrapped_mr *wpmd_mr) +{ + struct mlx5_pmd_mr pmd_mr; + + if (!wpmd_mr) + return; + pmd_mr.addr = wpmd_mr->addr; + pmd_mr.len = wpmd_mr->len; + pmd_mr.obj = wpmd_mr->obj; + pmd_mr.mkey = wpmd_mr->imkey; + pmd_mr.lkey = wpmd_mr->lkey; + mlx5_os_dereg_mr(&pmd_mr); + memset(wpmd_mr, 0, sizeof(*wpmd_mr)); +} + -- 2.25.1