From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5C58A034F; Wed, 10 Nov 2021 04:13:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B6C04014D; Wed, 10 Nov 2021 04:13:39 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id B56B140142 for ; Wed, 10 Nov 2021 04:13:37 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1059) id 04A2F20C352A; Tue, 9 Nov 2021 19:13:37 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 04A2F20C352A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1636514017; bh=Zd7p936ZLntmmAFStQPzhFbFZAUPrqcew9ZwpeEb/PI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CG6sSla3hsKvaiq9+67dEKGaaRuzZFZxtowWR6oGXQSiZf5M+ydiWNHaNWpqYFMoK Vmc5mEj0WQ09FQeKz1bb4LueHOFEqSVZRu/Zpk4TQyVA2DxIob8YK1IFzWw+DkxbZp 5mMOQ/64bOwOjJh68O7gs/Ko7mABLYJJRfi+7xj8= Date: Tue, 9 Nov 2021 19:13:36 -0800 From: Narcisa Ana Maria Vasile To: Thomas Monjalon Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, khot@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com Message-ID: <20211110031336.GC7558@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1633732841-17873-1-git-send-email-navasile@linux.microsoft.com> <1633765318-28356-1-git-send-email-navasile@linux.microsoft.com> <1633765318-28356-9-git-send-email-navasile@linux.microsoft.com> <27236504.5ELz80oB1M@thomas> <20211109020734.GE12569@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211109020734.GE12569@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v16 8/9] eal: implement functions for thread barrier management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 08, 2021 at 06:07:34PM -0800, Narcisa Ana Maria Vasile wrote: > On Tue, Oct 12, 2021 at 06:32:09PM +0200, Thomas Monjalon wrote: > > 09/10/2021 09:41, Narcisa Ana Maria Vasile: > > > From: Narcisa Vasile > > > > > > Add functions for barrier init, destroy, wait. > > > > > > A portable type is used to represent a barrier identifier. > > > The rte_thread_barrier_wait() function returns the same value > > > on all platforms. > > > > > > Signed-off-by: Narcisa Vasile > > > --- > > > lib/eal/common/rte_thread.c | 61 ++++++++++++++++++++++++++++++++++++ > > > lib/eal/include/rte_thread.h | 58 ++++++++++++++++++++++++++++++++++ > > > lib/eal/version.map | 3 ++ > > > lib/eal/windows/rte_thread.c | 56 +++++++++++++++++++++++++++++++++ > > > 4 files changed, 178 insertions(+) > > > > It doesn't need to be part of the API. > > The pthread barrier is used only as part of the control thread implementation. > > The need disappear if you implement control thread on Windows. > > > Actually I think I have the implementation already. I've worked at this some time ago, > I have this patch: > [v4,2/6] eal: add function for control thread creation > > The issue is I will break ABI so I cannot merge it as part of this patchset. > I'll see if I can remove this barrier patch though. I couldn't find a good way to test mutexes without barriers, so I kept this for now.