From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6E1BA034F; Wed, 10 Nov 2021 17:03:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B89941143; Wed, 10 Nov 2021 17:03:23 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 7DBE24113C for ; Wed, 10 Nov 2021 17:03:22 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id u11so3438571plf.3 for ; Wed, 10 Nov 2021 08:03:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fCCxgpGOzBDnDW+RTKDvNcLDxkUJeGk4t3WjHfH+MIY=; b=SIntns44xoqJXg/P+Z/sSo5su0pg1ufJhCGUsw2gGUfbmz5MbFIakVY9d9BxRk8/cy 0a0q+sn9geOb9BLvIhTSs/qspeJEAba3LFWuFPRpeWezeIakHD1y4axrNn9DJ/rslTMj h5crDbasQE7PUKzLUe86DRttgxVEYctG/6XkbQXc9kLd64eyeYSgtv13DcqWPtlacKWb Oq6JVK1rsSh+YhT3NFKVaz3Om6BLg1jL5Ot2R6WGNIsd0dFt4xGgNUEu0De8gAXeRZWy rxxRyT65KBufk5NP7haPS3KW6mpzB20TTbATLrhPrgnmBuRv5kpara/kKTqtPNT7Fcod ovNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fCCxgpGOzBDnDW+RTKDvNcLDxkUJeGk4t3WjHfH+MIY=; b=LPJQvOoc3eIR3nDk+P4OwaNWtoYEkVcObevP6VDb8TOjgMqmbx4t58/eTEEWW1sdb1 rl5HC9yj5P9om3VUPmX8kuClKYDlWtrHYINZYNcuHm8oZ+5aF7gJ5GQBmJbA8MPmKLBY O1Ahl6blG4ABoWc4nF49yhEkI/Qms6WUkvudMtVaPnwpgM4r9Bp8LD/5Cu1QD0DdauF9 bE0Jr8MqkZHz51qrbIIaVxXLFg6wq5SRCpfLlL1K8ipVSCo6f21svwg5vZtx+Gw2o2XX GS9S0rTbapk2W125k0UBZEO4gwzrGVOsGxtI28bL5ltXGV7rjfNKZ9kzf7zd9ratZbke ygsg== X-Gm-Message-State: AOAM5311BsnT/pGJIH1zp8TuDy1jM0tv2ysED1zMLDIf4Altgz/wFt57 LWz3sh2HLZdDBJg/ByndtErXmg== X-Google-Smtp-Source: ABdhPJwAFTiWfDamxRfTPGMHei1K3K5AqFvM1ZQ8Xo0Ms3izzpgwlSLW0cNw+ct51+CuCZ3a7E1j+w== X-Received: by 2002:a17:90b:3b48:: with SMTP id ot8mr18529058pjb.78.1636560201419; Wed, 10 Nov 2021 08:03:21 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id co4sm5974427pjb.2.2021.11.10.08.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 08:03:21 -0800 (PST) Date: Wed, 10 Nov 2021 08:03:18 -0800 From: Stephen Hemminger To: "Xu, Wei1" Cc: "Lu, Wenzhuo" , "Wu, Jingjing" , "bernard.iremonger@inel.com" , "dev@dpdk.org" Subject: Re: [PATCH] app/testpmd: fix parameters order when calling rte_ether_addr_copy() Message-ID: <20211110080318.61df8450@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 10 Nov 2021 08:17:59 +0000 "Xu, Wei1" wrote: > eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *); > - rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], > - ð_hdr->dst_addr); > - rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, > - ð_hdr->src_addr); > + rte_ether_addr_copy(ð_hdr->dst_addr, > + &peer_eth_addrs[fs->peer_addr]); > + rte_ether_addr_copy(ð_hdr->src_addr, > + &ports[fs->tx_port].eth_addr); Your patch indents with spaces not tabs