From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ED5DA034F; Fri, 12 Nov 2021 15:39:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E21A9410F5; Fri, 12 Nov 2021 15:39:04 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by mails.dpdk.org (Postfix) with ESMTP id D3F5940692 for ; Fri, 12 Nov 2021 15:39:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NkD/ybdz5y+cQFBJdqw4ff0npEX70+DL2JpXnGfn9KjZcOkoudRu8Ur3PvrnrS5fkZeLWiOzVbqW+y0W1RVAAU8s7j2OWQjqmKgsBGycGit3JUs9klriKWDWPVW2GXiyhFe3OzlIT+SF5oZcpBgjJvyxh1QYOyvWN0p8La3F7zWc4w5LXrs1+7RHtKJE6H72ist0cP3j5TYQID51UQSSoeCBt9715X4avsc7irg5Rktnds52twywYa038Lp56y0L7K3/HwKSESrTnnoudk/s8qnYIJ0OJYphqHZp7XuH+4z/UplqdwbtVlpaGNhldEznncofvggr/CGWtbr8PB3SPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QqUDWrvdmKybxvQF78CWzzzeo47Fzti8L2KPukInjHw=; b=nLqHR5RTs1i3W8g65jHxL+vcvkvZa8LvuucAGgOvqe4O14lSSWw+XQc3tMek5L2W/nG+cuWFDBnMdoqfkVl5ngJgHszZpY6XMOw9fB/3WR22+z5b/WXnrHOyxBMCG0mJ7qyjLLffvBgSa+Y4cNRsbUA2AYCelVJEgjogZX5asrAVQSQp3aufd/k6O8xuvkXt6YDrHbEHW8ZM2LKOc/T5Ilu8W53BZ84yVVzfYIWU680HhLpIUXgZfGV7HI57kP0Y/34khcmghD7+kFJ40q5HA0f3rhPek3JH+t6YpAC6Kl17x6Z9njyKMdRL4BIo6UJCsrFviwGBiAdXa3+iOaU04A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QqUDWrvdmKybxvQF78CWzzzeo47Fzti8L2KPukInjHw=; b=X/YhFYCTVgtdwNqK2i87nv1h28nb1H5KAOEmCzID2tC/hwSA5fqTWJX4d2oukpljwHb6RZfEL5eVo3lZMbplJD9n6aHHWA8YEK12cF8LCwA4DNCv5rYDg0RoSNyfuPr3MhNdhRjYvdcTjNTr+KPtWM6j0/wBpJrZ69zWBLPy7p5E2Zwpkg474ucfvTB+X9M14iDU288uzFdg1jWaiVFVPNPek15cZeGM+s1hhtj5qpBXM6u3NqQIql4w7sPQjkG4j/ZpdFZToEo8w+7xnpReulqA8M6poFNCIw0rWxNHKlQYRDeUKDznaI9egAyV6BZmwAOMBN5Ckym+kpYVt+2p+g== Received: from DM5PR15CA0070.namprd15.prod.outlook.com (2603:10b6:3:ae::32) by SN1PR12MB2350.namprd12.prod.outlook.com (2603:10b6:802:24::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Fri, 12 Nov 2021 14:39:01 +0000 Received: from DM6NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:3:ae:cafe::5e) by DM5PR15CA0070.outlook.office365.com (2603:10b6:3:ae::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Fri, 12 Nov 2021 14:39:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT028.mail.protection.outlook.com (10.13.173.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4690.15 via Frontend Transport; Fri, 12 Nov 2021 14:39:00 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 12 Nov 2021 14:38:57 +0000 From: Bing Zhao To: , CC: , Subject: [PATCH] net/mlx5: fix the delay drop bit set overflow Date: Fri, 12 Nov 2021 16:38:42 +0200 Message-ID: <20211112143842.9290-1-bingz@nvidia.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 225ea7f8-57b3-41df-e61a-08d9a5ea2acf X-MS-TrafficTypeDiagnostic: SN1PR12MB2350: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QHYBpqn8ssI8P0+kc2keTdKwLdyoiT7TQRMhqRw6rnjryqeSeSLwGvsWyTXC7UTOIZbqJbnkXPnVBJBt5U+v5ne5VCVr3LJBQS8uXOnTkdbSC5thCWrn1eIvknkEwp0/kZJvt84G+ymyCOINs5SFQT0onZPC/WQbg4I3dw/oJ4f8pO/I9fRMF2qAcHSpqbUJIAY+x3kTczmWQpz+OfHzLJGrCi7/Cuxj7IexVQYjkTdy+6Gk3n4WjQEUx2H9E/oWiYpXXX6k5t+5muxPAeX+8mRE2+gOHZ4lYUb3AROP/sD9qzrcyC1k2Mtl12uVrv/JxrG7qZArsKg+2R6E4DOvyBX1RDSUplR+8jYdsomYISzygd/48F4Gze32u64iag0ANKqzSwAgwrixhBEil0DO5i6hN9pN18JD4+aAEH9r1ipoauQy4cKfR0wFbUlM8hiF2wH/BN9l3p5jd7Qf4Iz4kYVpKfNpKNmJMd+kUyM0h6rQ/Yk7KjIu4VMToT09LwsmTSFexP4k0ssjJ7Ndh6TvhsZv8TPRgGPNOvcxVOOFDY2hfvJKCtTuXlBJSrgX2wCwPoysgEyAtEWeoRCy91fPoQNwGH1kuWv9+uhAyhzD8pCoB4N9mD/k68X2pqp1fcL+jjWZ60U5bpxev/QrUC4s00lbNXvTj0YsdvT0zcvxBSpd6irzFUSiiG+0kdJ+mWg/nMRZcfMXaP63Dh6skSrVZhiWBz0HSgwRXOW4L2isqlw= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(2906002)(110136005)(86362001)(5660300002)(54906003)(36906005)(316002)(336012)(4326008)(6636002)(36860700001)(1076003)(82310400003)(6286002)(55016002)(2616005)(107886003)(426003)(7696005)(356005)(6666004)(508600001)(36756003)(26005)(8676002)(16526019)(8936002)(70206006)(186003)(70586007)(7636003)(83380400001)(47076005)(309714004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2021 14:39:00.7724 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 225ea7f8-57b3-41df-e61a-08d9a5ea2acf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2350 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The attribute to record the global control of hairpin queues' delay drop was defined as a bit-field with one bit, and the intention was to reduce the memory overhead. In the meanwhile, the macro was defined as an enumerated value 0x2. No matter what value inputted via devarg, the lowest bit was always zero and the higher bits would be ignored. For hairpin queues, the delay drop attribute couldn't be enabled. With the commit, the double logical negation is used to fix this. Fixes: febcac7b46cd ("net/mlx5: support Rx queue delay drop") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index f5990dd757..2f5d74105a 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1978,8 +1978,8 @@ mlx5_args_check(const char *key, const char *val, void *opaque) } else if (strcmp(MLX5_ALLOW_DUPLICATE_PATTERN, key) == 0) { config->allow_duplicate_pattern = !!tmp; } else if (strcmp(MLX5_DELAY_DROP, key) == 0) { - config->std_delay_drop = tmp & MLX5_DELAY_DROP_STANDARD; - config->hp_delay_drop = tmp & MLX5_DELAY_DROP_HAIRPIN; + config->std_delay_drop = !!(tmp & MLX5_DELAY_DROP_STANDARD); + config->hp_delay_drop = !!(tmp & MLX5_DELAY_DROP_HAIRPIN); } else { DRV_LOG(WARNING, "%s: unknown parameter", key); rte_errno = EINVAL; -- 2.27.0