From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0DBBA0032; Sat, 13 Nov 2021 18:10:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 120E740691; Sat, 13 Nov 2021 18:10:19 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 1AF2C4013F for ; Sat, 13 Nov 2021 18:10:17 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id k4so10923151plx.8 for ; Sat, 13 Nov 2021 09:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/Qbk5E70izVKq4iFAjHKsRk2acRom1i3Z+Lj6NojAac=; b=yhI10p2ihTJVAPpR2vg1SYPUCJwzR/AsSDRpnRu+yNwafDqsGLWbPVDi2WYdYQFmUv LSgIqlqWdAkNIIviqq4VrYY+6qJMbpvn8siZ5CKe6LQVIk61O1nSB5RAkes7zX+Wp8+Z SjtZecfQa0bvP0T4nR4ZjJbmADBm0kmQ8uDm7WqL0i3v8Dnszw8wsUoffIu6SoO6PL0b DFPxTp0sirtEiTn4/Ba4dQrBIxq+ZNiDP+9ouIX/fsFRt6ptb/5bQuQoAwdpiptHei+P Ep+z/J5z2VCIATWkDoWgxpl2X4dNMD4RbVksbC6zBHsVkvYNBb3KoU2AV5zbEkl2/+0p JDsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/Qbk5E70izVKq4iFAjHKsRk2acRom1i3Z+Lj6NojAac=; b=kLgMZWoutyjEThW9yiI5C2rISjmOWVr9v5FA0EROGTT1iN4WXF4B0UPOvoiZ/CogY1 1WBkoTgcoPNiTtxPdCU37ekd8pL68MatLW0uY9Dg051MInI8J3BP7MgZiEahN360J/q3 UEI9d1UM7MbcRuI7LujJVAFRBvQkReN6LS1CkWR60GlipqOAINUfVgD+8veQfSjMdHDM GdVCIOtt2hrI3NIXEz6ekGUtoOw+9wgLcYKBwoQ5aYevnX4aayg0Dq3fnkC16wmiOAJR nWY561ah3Y2MX9kXYP9Ea2SsFCy+A2WINP2AN88wRpKkUHxsOVu6C4QwMkiIBHCRsUy3 bVCg== X-Gm-Message-State: AOAM530G8gUSBoj7KqT2q0ICb1M3mx2BKVHRr2ZJLIpnntnf7cn44xUT rB3zqBKfqLKDENGyttTqnwxOlQ== X-Google-Smtp-Source: ABdhPJzla1z/n/hs57slklMRi85264JnyBB/4IvRr98d376W1vm6YWVvCeSH+05OeiKkoNUm98gEIg== X-Received: by 2002:a17:903:300d:b0:142:744f:c74d with SMTP id o13-20020a170903300d00b00142744fc74dmr19538561pla.26.1636823416706; Sat, 13 Nov 2021 09:10:16 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id l17sm10293626pfc.94.2021.11.13.09.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Nov 2021 09:10:16 -0800 (PST) Date: Sat, 13 Nov 2021 09:10:13 -0800 From: Stephen Hemminger To: Apeksha Gupta Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, sachin.saxena@nxp.com, hemant.agrawal@nxp.com Subject: Re: [PATCH v10 4/5] net/enetfec: add Rx/Tx support Message-ID: <20211113091013.12d5ca0c@hermes.local> In-Reply-To: <20211113043141.18888-5-apeksha.gupta@nxp.com> References: <20211110074829.16654-2-apeksha.gupta@nxp.com> <20211113043141.18888-1-apeksha.gupta@nxp.com> <20211113043141.18888-5-apeksha.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 13 Nov 2021 10:01:40 +0530 Apeksha Gupta wrote: > + if (mbuf) > + rte_pktmbuf_free(mbuf); Null check is unnecessary. rte_pktmbuf_free(NULL) is defined to be safe, like free(NULL).