From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47110A0032; Sat, 13 Nov 2021 18:12:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2170E40691; Sat, 13 Nov 2021 18:12:03 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 0E9634013F for ; Sat, 13 Nov 2021 18:12:00 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id g19so11190033pfb.8 for ; Sat, 13 Nov 2021 09:12:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FrdFhHFkaEeSEFSxp/YhRQDgLVdNoSNICOmoSD6HtkA=; b=p25MExKnxWwxwq95aExy/GuAX7rUSDwtglMSE4lMRiTVsJMp9Z25we2FJNdTVw0FgP nDacooAwgvzaELqsNSXfUz2diGvh1i5kzsnR+YxgdJlo3hNuu2GR8mKxyxcDswFM8RJ+ Ybw3oxypB4qiNrOTKGqJw0yRWqLIaCFUKsp/Ma129j6TrA0uPuKgZFa69+UrJB/yQ+3R NSS2LZbjzcQhFJzTDmoHrI9U6QfEh1tpGFlK5VmXoy/MoyTSqfx2yHBpfYwMhSNb2lUs R8OlJkF9WHNR/WlUBwpiONEtDoFS2m9HG/PAUvKLKWZ9SfEH97mjSQW7m4h8qYgMcefQ qCKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FrdFhHFkaEeSEFSxp/YhRQDgLVdNoSNICOmoSD6HtkA=; b=wMh3NUayj48V+KOeD2ZSZNY0JDltZ62jFd+tOT6f5D26nSdoXNGc/60sirYlmqOJlh mvJ1njssMnj//53AtIo69gh41uZ1oPgs5d9ncoo0bc/3qbpVlMq15gubHgMTpzkeYwTY quVkn1plEWrsMH4bndLFBkynIF6X6mGVTanb9V9ohomEn9rB5ElW2Yaq15I7E0O+LJM8 1NfcN5y2fs/bfjfiq6C5Fvw24grmI0aVJuBQiTroXWUe+cmpgfXSS7gOBmsFpGoXQZSY 8hABPSrRXjAraYmmwYcAsF6rcyI7FzUqMhFfQWVZu5exi2YF/tsTM/pdH5dpJFD23atR 3+2Q== X-Gm-Message-State: AOAM531T9FmnT3XErKnFXIBMlDP+Fg0Uu+PNQ81JROMnzL7MqkGla1fx 6q/4W89tVY5CO0J9szglAdVAxg== X-Google-Smtp-Source: ABdhPJxCxRRiuumSOS2h0VGijFdV2Gj5FgGed9uKLJSh3v3EHI6KbJFnucVtkUbHo6Q4kctTdCYzcA== X-Received: by 2002:a05:6a00:8c4:b0:44c:9827:16cc with SMTP id s4-20020a056a0008c400b0044c982716ccmr21313514pfu.7.1636823520105; Sat, 13 Nov 2021 09:12:00 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id h25sm7205905pgm.33.2021.11.13.09.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Nov 2021 09:11:59 -0800 (PST) Date: Sat, 13 Nov 2021 09:11:56 -0800 From: Stephen Hemminger To: Apeksha Gupta Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, sachin.saxena@nxp.com, hemant.agrawal@nxp.com Subject: Re: [PATCH v10 3/5] net/enetfec: support queue configuration Message-ID: <20211113091156.401a1f24@hermes.local> In-Reply-To: <20211113043141.18888-4-apeksha.gupta@nxp.com> References: <20211110074829.16654-2-apeksha.gupta@nxp.com> <20211113043141.18888-1-apeksha.gupta@nxp.com> <20211113043141.18888-4-apeksha.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 13 Nov 2021 10:01:39 +0530 Apeksha Gupta wrote: > + /* Tx deferred start is not supported */ > + if (tx_conf->tx_deferred_start) { > + ENETFEC_PMD_ERR("%p:Tx deferred start not supported", > + (void *)dev); Small observations: 1. Cast to void * is unnecessary in a print/log statement 2. Why not print something human friendly like device name?