From: Rashmi Shetty <rashmi.shetty@intel.com>
To: dev@dpdk.org
Cc: jerinj@marvell.com, harry.van.haaren@intel.com,
pravin.pathak@intel.com, mike.ximing.chen@intel.com,
timothy.mcdaniel@intel.com,
Rashmi Shetty <rashmi.shetty@intel.com>
Subject: [PATCH v2] event/dlb2: fix delayed_pop test in dlb2_selftest
Date: Mon, 15 Nov 2021 10:34:44 -0600 [thread overview]
Message-ID: <20211115163445.1438809-1-rashmi.shetty@intel.com> (raw)
In-Reply-To: <20211112194857.1342664-1-rashmi.shetty@intel.com>
Number of events scheduled and available for dequeue
after token pop was set to dequeue_depth-1 instead of
dequeue_depth in test_delayed_pop. The expectation is
that all dequeue_depth number of events can be dequeued
once the last event is released.
Fixes: a10e8e96865f ("event/dlb2: add delayed token pop logic")
Signed-off-by: Rashmi Shetty <rashmi.shetty@intel.com>
---
v2:
- Updated commit message with 'Fixes' tag (Jerin)
---
drivers/event/dlb2/dlb2_selftest.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/event/dlb2/dlb2_selftest.c b/drivers/event/dlb2/dlb2_selftest.c
index 5cf66c552c..2113bc2c99 100644
--- a/drivers/event/dlb2/dlb2_selftest.c
+++ b/drivers/event/dlb2/dlb2_selftest.c
@@ -1354,7 +1354,7 @@ test_delayed_pop(void)
}
/* Release one more event. This will trigger the token pop, and
- * dequeue_depth - 1 more events will be scheduled to the device.
+ * dequeue_depth more events will be scheduled to the device.
*/
ev.op = RTE_EVENT_OP_RELEASE;
@@ -1366,7 +1366,7 @@ test_delayed_pop(void)
timeout = 0xFFFFFFFFF;
- for (i = 0; i < port_conf.dequeue_depth - 1; i++) {
+ for (i = 0; i < port_conf.dequeue_depth; i++) {
if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 1) {
printf("%d: event dequeue expected to succeed\n",
__LINE__);
@@ -1374,14 +1374,6 @@ test_delayed_pop(void)
}
}
- timeout = 0x10000;
-
- if (rte_event_dequeue_burst(evdev, 0, &ev, 1, timeout) != 0) {
- printf("%d: event dequeue expected to fail\n",
- __LINE__);
- goto err;
- }
-
cleanup();
return 0;
--
2.25.1
next prev parent reply other threads:[~2021-11-15 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 19:48 [PATCH] " Rashmi Shetty
2021-11-12 20:25 ` Chen, Mike Ximing
2021-11-15 8:29 ` Jerin Jacob
2021-11-15 16:34 ` Rashmi Shetty [this message]
2021-11-16 7:07 ` [PATCH v2] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115163445.1438809-1-rashmi.shetty@intel.com \
--to=rashmi.shetty@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=mike.ximing.chen@intel.com \
--cc=pravin.pathak@intel.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).