From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2D1AA0032; Mon, 15 Nov 2021 19:24:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3861D4117E; Mon, 15 Nov 2021 19:24:21 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 8D2A24117D for ; Mon, 15 Nov 2021 19:24:20 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id m15so11409987pgu.11 for ; Mon, 15 Nov 2021 10:24:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=4z78BEUHprTIJauQLdIJQtGM1CwYvEfzSt4dC6O3sBk=; b=bwT3CYRxRhym4XIOKwC573OE2QnQyTuO79CoYSK+G6F9o1uTYSe3T4cemdRwwEBXzY Yh2pCzppwKOD89kSmV4onYcBsyiRM9Vg4Dp1RK1nHfSD8hnY9we5kcDeR3T+I0Rn64ff Ozudrn3m3Pag3+nes1wA9LuLNIovDk9DU8+48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=4z78BEUHprTIJauQLdIJQtGM1CwYvEfzSt4dC6O3sBk=; b=h2cXoAo+jY0plbOg+jIy3po6Du+sf5ugFopNv/3tKpDue7rQRngfq7jwjT6wxttIoG GVyyqHOc/8lcQ2lIB+Qveav0CftXblHqGH3CGIwNDRBaL+9/eZuJWk+LUpUDyLOSMjN0 TEG4rJY4t6avl1LmNyhx7+cc1BXCY4zEjy9AfQJtss4V1JyXM3hgwET3z7ZvMifIgjQ+ ZLjSrJnQuRzS7wfCLhrTJCWnTDMotAu3kYGjl65SImrWz1jFrzYEQIVARg4G4jlrH/B7 efL4ZRHMxun9kZFgqOrvSjMh9S8B+WrDztMEjcupYbx0lxF+sAbP82MHBGpuMOUCj2Vy Tmww== X-Gm-Message-State: AOAM5321pmf5tgmyG7WfmfR5vnoVrOteD4QG3WW8mUYndPxbBSebj2lj /llm0TCzat5UenZ4AbcyZR4Brkj44IbbQQ== X-Google-Smtp-Source: ABdhPJyZUach79fosLsgwCHRDrtlE/inBzLgH1+SyUUhN2zniOrS8LryTHdKLID0ulzBYhp6QVDvYA== X-Received: by 2002:a05:6a00:2496:b0:49f:eba0:6575 with SMTP id c22-20020a056a00249600b0049feba06575mr34863006pfv.78.1637000659734; Mon, 15 Nov 2021 10:24:19 -0800 (PST) Received: from lrichardson-VirtualBox.dhcp.broadcom.net ([192.19.11.250]) by smtp.gmail.com with ESMTPSA id w7sm12419785pgo.56.2021.11.15.10.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 10:24:19 -0800 (PST) From: Lance Richardson To: Bruce Richardson , Konstantin Ananyev , Ajit Khaparde , Somnath Kotur Cc: dev@dpdk.org, stable@dpdk.org Subject: [PATCH 2/2] net/bnxt: remove software prefetches from AVX2 Rx path Date: Mon, 15 Nov 2021 13:24:10 -0500 Message-Id: <20211115182410.5545-3-lance.richardson@broadcom.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211115182410.5545-1-lance.richardson@broadcom.com> References: <20211115182410.5545-1-lance.richardson@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000d6226305d0d7ea94" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000d6226305d0d7ea94 Content-Transfer-Encoding: 8bit Testing has shown no performance benefit from software prefetching of receive completion descriptors in the AVX2 burst receive path, and slightly better performance without them on some CPU families, so this patch removes them. Fixes: c4e4c18963b0 ("net/bnxt: add AVX2 RX/Tx") Cc: stable@dpdk.org Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c b/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c index 54e3af22ac..34bd22edf0 100644 --- a/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c +++ b/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c @@ -92,12 +92,6 @@ recv_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) cons = raw_cons & (cp_ring_size - 1); mbcons = (raw_cons / 2) & (rx_ring_size - 1); - /* Prefetch first four descriptor pairs. */ - rte_prefetch0(&cp_desc_ring[cons + 0]); - rte_prefetch0(&cp_desc_ring[cons + 4]); - rte_prefetch0(&cp_desc_ring[cons + 8]); - rte_prefetch0(&cp_desc_ring[cons + 12]); - /* Return immediately if there is not at least one completed packet. */ if (!bnxt_cpr_cmp_valid(&cp_desc_ring[cons], raw_cons, cp_ring_size)) return 0; @@ -136,14 +130,6 @@ recv_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) _mm256_storeu_si256((void *)&rx_pkts[i + 4], t0); #endif - /* Prefetch eight descriptor pairs for next iteration. */ - if (i + BNXT_RX_DESCS_PER_LOOP_VEC256 < nb_pkts) { - rte_prefetch0(&cp_desc_ring[cons + 16]); - rte_prefetch0(&cp_desc_ring[cons + 20]); - rte_prefetch0(&cp_desc_ring[cons + 24]); - rte_prefetch0(&cp_desc_ring[cons + 28]); - } - /* * Load eight receive completion descriptors into 256-bit * registers. Loads are issued in reverse order in order to -- 2.25.1 --000000000000d6226305d0d7ea94 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQeQYJKoZIhvcNAQcCoIIQajCCEGYCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3QMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVgwggRAoAMCAQICDEE6ETlop5mCMi8TTTANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDAwMDZaFw0yMjA5MjIxNDA0NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGTAXBgNVBAMTEExhbmNlIFJpY2hhcmRzb24xLDAqBgkqhkiG 9w0BCQEWHWxhbmNlLnJpY2hhcmRzb25AYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAtwpZpnhFX97ppmkjMk0524J34JdotSKqTN5VpCqyyjqOsA0+igK8vDIGNu+a k/I58b3mblSBsPf9Nh2ac1Qiu8fe/SRrxE2iwLdoY+lXFDHOSJ8YU5wbZShTmffks80aTql1eafj tiuQyqfwsT7KhL7TtQmS9kiSoOH2JSKQP34kp8oQHDYMKs/K6LbknHFvZQuu1tyzp9So3lsR40I4 F6MGdop4+ha+FsPeuhBVzHZETpIgknNz9flzINObGsEoHwpQ2aNccyKXb6WhR8cgmBsE5g6yJM8I pRfmy8qUi+GjsMESst3vqlHhoH+2mONs2aTi6bGmi97VtBBrwtg4SQIDAQABo4IB3jCCAdowDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAoBgNVHREEITAfgR1sYW5jZS5yaWNoYXJkc29uQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggr BgEFBQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUjrW9hZEi RhS3ycv7B7yNT4ZrlTUwDQYJKoZIhvcNAQELBQADggEBAC33vhcbLmLx4UYvphWOyiUhuwWwXGne 1yu5ciJf7xa8NhNr08wJ4HWmtPTt4PeoswbYKybfmCHCKRgdlsuOIY8+e5dxtPDNNtgDuadauKTH cVagaPUqEK+0C5YcfWoQTfgL7chfv4s+ZNDGuVbt0EjflX4u3gb3HFwkrlOaZSx/fTMh3uyL8EIV wUPvLlDKieK0BzrXEqjF+PA/YAiFEgfsTMqpwZJ7HjHECNsNRrTsAL5PEZA6CPn/05YRh90p7y6s BvWO7ehqE8R1FML6VqLiuzdoV6aY/tGkpxCVQSq6WPJYoe2AimWT6BFI50/llQOsXrHvmPIii/X9 epe3qW8xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52 LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgxB OhE5aKeZgjIvE00wDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIG9WMtp0pr92LUP3 qnuPY4GhK3NGwqqapbEl63y00XMcMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTIxMTExNTE4MjQyMFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZI AWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEH MAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQCk/t48bmxC9+RPIN7GPN8+M+9tw5R+OO/i h1mJm94k7SGq1CzKnH/eWx0P/E6m4ERlA70YZN1rhAD1hqaqJctN/FA6tIoF4oX2RB5jtENdluV4 D/YuYIC12MT5cHbaMpm5uDJLzNky3lCO3E2tf/uni9jDdPjX7bDuleEoMNkdk3mHsUMRTs/ebsn6 2q3OVcTgYdgpmt6VyIdHSLposHeFs4Wb21Z4NaaqPxbyf0WHsabK1TuELYTdMeuL02sR9nduAYGm kAABB+mWjv5Gj7nL/9oa0vn459h/mstsFSL7vKu1EryFMOoOxpiyt04fG3TQs8dizeCP6caRvmlG yN+V --000000000000d6226305d0d7ea94--