From: David Christensen <drc@linux.vnet.ibm.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, David Christensen <drc@linux.vnet.ibm.com>
Subject: [PATCH v2] eal/ppc: support ASan
Date: Mon, 15 Nov 2021 13:38:47 -0800 [thread overview]
Message-ID: <20211115213847.1428592-1-drc@linux.vnet.ibm.com> (raw)
In-Reply-To: <20211115184106.1406617-1-drc@linux.vnet.ibm.com>
Add support for Address Sanitizer (ASan) for PPC/POWER architecture.
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
v2: Removed architecture test, modified programmer's guide text
config/meson.build | 2 +-
doc/guides/prog_guide/asan.rst | 6 +++---
lib/eal/common/malloc_elem.h | 2 ++
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 3f5912fce7..805d5d51d0 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -433,7 +433,7 @@ if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == 'address
dpdk_extra_ldflags += '-lasan'
endif
- if is_linux and arch_subdir in ['x86', 'arm'] and dpdk_conf.get('RTE_ARCH_64')
+ if is_linux and dpdk_conf.get('RTE_ARCH_64')
dpdk_conf.set10('RTE_MALLOC_ASAN', true)
endif
endif
diff --git a/doc/guides/prog_guide/asan.rst b/doc/guides/prog_guide/asan.rst
index 28b2382fc7..693fba36c8 100644
--- a/doc/guides/prog_guide/asan.rst
+++ b/doc/guides/prog_guide/asan.rst
@@ -32,9 +32,9 @@ Example::
- If the program is tested using cmdline, you may need to execute the
"stty echo" command when an error occurs.
-ASan is aware of DPDK memory allocations, thanks to added instrumentation.
-This is enabled on x86_64 and arm64 at the moment.
-Other architectures may have to define ASAN_SHADOW_OFFSET.
+ASan is aware of DPDK memory allocations, thanks to added instrumentation, and
+is enabled on all 64 bit architectures for Linux. Other architectures may have
+to define ASAN_SHADOW_OFFSET.
Example heap-buffer-overflow error
----------------------------------
diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
index b982c83f70..15d8ba7af2 100644
--- a/lib/eal/common/malloc_elem.h
+++ b/lib/eal/common/malloc_elem.h
@@ -112,6 +112,8 @@ malloc_elem_cookies_ok(const struct malloc_elem *elem)
#define ASAN_SHADOW_OFFSET 0x00007fff8000
#elif defined(RTE_ARCH_ARM64)
#define ASAN_SHADOW_OFFSET 0x001000000000
+#elif defined(RTE_ARCH_PPC_64)
+#define ASAN_SHADOW_OFFSET 0x020000000000
#endif
#define ASAN_SHADOW_GRAIN_SIZE 8
--
2.27.0
next prev parent reply other threads:[~2021-11-15 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 18:41 [PATCH] " David Christensen
2021-11-15 20:10 ` David Marchand
2021-11-15 21:38 ` David Christensen [this message]
2021-11-16 8:42 ` [PATCH v2] " David Marchand
2021-11-16 10:22 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115213847.1428592-1-drc@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).