From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 366B2A0032; Tue, 16 Nov 2021 01:24:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AA9140141; Tue, 16 Nov 2021 01:24:42 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id EDB6940040 for ; Tue, 16 Nov 2021 01:24:40 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 318DA20C6352; Mon, 15 Nov 2021 16:24:40 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 318DA20C6352 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1637022280; bh=+raZCYW8VZDpXt30ozLoCiYI2Ms9hVSNJWwH7HSks50=; h=Date:From:To:Subject:From; b=siEzHuBoTi4or51VEYtIdHzDZp8DniCpuQ7W95o7b72sD9kyFBMepDvEo7PsjV1Yb b7JtEv+b7vS2gWET4megKGbiwZBKtLx5jLpzCil/JD32n6m/gj8sFM8xrtJdpv9Tq/ wzwNKKo6CrK200OhV/srVffOQTf+5Pw5O1KE3xUc= Date: Mon, 15 Nov 2021 16:24:40 -0800 From: Tyler Retzlaff To: dev@dpdk.org Subject: ethdev: hide internal structures Message-ID: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org hi folks, I don't understand the text of this change. would you mind explaining? commit f9bdee267ab84fd12dc288419aba341310b6ae08 Author: Konstantin Ananyev Date: Wed Oct 13 14:37:04 2021 +0100 ethdev: hide internal structures +* ethdev: Made ``rte_eth_dev``, ``rte_eth_dev_data``, ``rte_eth_rxtx_callback`` + private data structures. ``rte_eth_devices[]`` can't be accessed directly + by user any more. While it is an ABI breakage, this change is intended + to be transparent for both users (no changes in user app is required) and + PMD developers (no changes in PMD is required). if it is an ABI break (and it is also an API break) how is it that this change could be "transparent" to the user application? * existing binaries will not run. (they need to be recompiled) * existing code will not compile. (code changes are required) in order to cope with this change an application will have to have the code modified and will need to be re-compiled. so i don't understand how that is transparent? thanks