From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>
Subject: Re: [PATCH] common/mlx5: decrease log level for hlist creation
Date: Tue, 16 Nov 2021 13:33:26 -0800 [thread overview]
Message-ID: <20211116133326.652d6e20@hermes.local> (raw)
In-Reply-To: <20211116203354.14167-1-david.marchand@redhat.com>
On Tue, 16 Nov 2021 21:33:54 +0100
David Marchand <david.marchand@redhat.com> wrote:
> act_size = rte_align32pow2(size);
> - DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power of 2, will "
> + DRV_LOG(DEBUG, "Size 0x%" PRIX32 " is not power of 2, will "
> "be aligned to 0x%" PRIX32 ".", size, act_size);
Splitting log message mid sentence is bad practice, why not fix it?
DRV_LOG(DEBUG,
"Size %#" PRIX32 " is not power of 2, will be aligned to %#" PRIX32
size, act_size);
next prev parent reply other threads:[~2021-11-16 21:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 20:33 David Marchand
2021-11-16 21:33 ` Stephen Hemminger [this message]
2021-11-17 12:14 ` Slava Ovsiienko
2021-11-17 13:02 ` David Marchand
2021-11-17 13:28 ` Slava Ovsiienko
2021-11-17 14:46 ` David Marchand
2021-11-18 14:22 ` David Marchand
2021-11-19 8:36 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116133326.652d6e20@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).