From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE891A0C53; Tue, 16 Nov 2021 22:33:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AA0E40141; Tue, 16 Nov 2021 22:33:31 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id B5DC440040 for ; Tue, 16 Nov 2021 22:33:30 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id o4so583037pfp.13 for ; Tue, 16 Nov 2021 13:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vz/AmQmG+ccI4zS5mwsZo5POclGi3kjSj+/civ0Yiow=; b=Q760PXkc5/TXAKdAmqo241b1K6/Hi28PrdOEVqWvhQAUJah/CR+R2HLtcpiz17lRnn fCtoO6PEcg2MPbS8gzsUR/jip4sZuuZlzDPi6AlmqgP3OTgCWQoDwkhI458llY2cmvY/ ZL4ixOS0sRkv161hIYx5netf+oOo4q6P0S0TO5cueI8dzvd2zBaD4bal9GLz3NJolbSz YUqOiwoF/HPKFNJOSmJYPkehxHDDbYl3PoG9GN37PNIiefDxWFQcP4lSXSXveNZKLHUh 8VozycuDTHUBafNbcwZ2zt447tYK2Fme8eG+ApmrwGFR9l/svu7GRiWcyhca+5KLENdt eyYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Vz/AmQmG+ccI4zS5mwsZo5POclGi3kjSj+/civ0Yiow=; b=aJWCGGIbAxHU9Fq2gX7c89GUevkaUqSYRs9BelWbQn2rms9jPr/OAfYgC9AFfsWpkP yPRB1b9ls6NBtWHAkFa7Mzu+ZQo4NcvdQ68wO5x/RGu5JLLEA0iJsXWL1qaDSOWdZPLR u5WDz4KpE7prS2GVCwdRD6VnUuKBKTsldZnSE7sCMVSvH744nKA1ppSWHLQT8Ml/lTrB ZP4Ny0iDtJlnRyo8Dd8W3MA29Djib4kOXyBY0fSCPEPBNHAoB6bo8xSSsd8Dvs6YBuyC trXNHC799/R0dJYkz5tZmEKs7Pd6cs09wnioO+ZzXGptBXXWKBEhWVnJZlPorbB6kFwM guaQ== X-Gm-Message-State: AOAM5311qT9MyIfEnQPbl0jv7f7QmYPDEG5ZjTvuBC2tppjaeZtNmO/f 7pD2RzMBKHrig7x95lBPB+rBHw== X-Google-Smtp-Source: ABdhPJzkJpwIPDpKfBpKrVmCSlXCmUEug3K6HzNUt43qdMxe+v45tMrlICDuTVypaRNByoXmKP9yNg== X-Received: by 2002:aa7:83d6:0:b0:494:690e:e66b with SMTP id j22-20020aa783d6000000b00494690ee66bmr2207821pfn.53.1637098409896; Tue, 16 Nov 2021 13:33:29 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id q13sm21216632pfk.22.2021.11.16.13.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 13:33:29 -0800 (PST) Date: Tue, 16 Nov 2021 13:33:26 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com, Matan Azrad , Viacheslav Ovsiienko , Suanming Mou Subject: Re: [PATCH] common/mlx5: decrease log level for hlist creation Message-ID: <20211116133326.652d6e20@hermes.local> In-Reply-To: <20211116203354.14167-1-david.marchand@redhat.com> References: <20211116203354.14167-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 16 Nov 2021 21:33:54 +0100 David Marchand wrote: > act_size = rte_align32pow2(size); > - DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power of 2, will " > + DRV_LOG(DEBUG, "Size 0x%" PRIX32 " is not power of 2, will " > "be aligned to 0x%" PRIX32 ".", size, act_size); Splitting log message mid sentence is bad practice, why not fix it? DRV_LOG(DEBUG, "Size %#" PRIX32 " is not power of 2, will be aligned to %#" PRIX32 size, act_size);