DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: ethdev: hide internal structures
Date: Tue, 16 Nov 2021 11:10:18 -0800	[thread overview]
Message-ID: <20211116191018.GA31070@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <DM6PR11MB4491BE29A03C5D8625F66BD69A999@DM6PR11MB4491.namprd11.prod.outlook.com>

On Tue, Nov 16, 2021 at 10:32:55AM +0000, Ananyev, Konstantin wrote:
>  
> rte_eth_dev,  rte_eth_dev_data, rte_eth_rxtx_callback are internal
> data structures that were used by public inline ethdev functions. 
> Well behaving app should not access these data structures directly.
> So, for well behaving app there should no changes in the code required.
> That what I meant by 'transparent' above.
> But it is still an ABI change, so yes, the app has to be re-compiled. 

so it appears the application was establishing a private context /
vendor extension between the application and a pmd. the application
was abusing access to the rte_eth_devices[] to get the private context
from the rte_eth_dev.

is there a proper / supported way of providing this functionality
through the public api?

> 
> Konstantin

  reply	other threads:[~2021-11-16 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  0:24 Tyler Retzlaff
2021-11-16  9:32 ` Ferruh Yigit
2021-11-16 17:54   ` Tyler Retzlaff
2021-11-16 20:07     ` Ferruh Yigit
2021-11-16 20:44       ` Tyler Retzlaff
2021-11-16 10:32 ` Ananyev, Konstantin
2021-11-16 19:10   ` Tyler Retzlaff [this message]
2021-11-16 21:25     ` Stephen Hemminger
2021-11-16 22:58       ` Tyler Retzlaff
2021-11-16 23:22         ` Stephen Hemminger
2021-11-17 22:05           ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116191018.GA31070@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).