From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 62F96A0C47;
	Tue, 16 Nov 2021 23:58:11 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D767240141;
	Tue, 16 Nov 2021 23:58:10 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 39EAE40040
 for <dev@dpdk.org>; Tue, 16 Nov 2021 23:58:09 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 6FF3A20C634D; Tue, 16 Nov 2021 14:58:08 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6FF3A20C634D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1637103488;
 bh=moSx3tg1Pkcs0uH3UQyKhGhXv9ql/oFriabC1db+3q0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=K+ulGT854Bk0Y+3VxtVhKeYRAmWwixRX2hjseNuEjPEXuVnXjYTHSnhe+Bsbnk6it
 YIVZj1OWx8iU6mkae4Pn+ILEp5wY68AswWzC8ZuqsVsfg14QvXC57Q0L6TshUUSNCa
 Qhwj1MmDVhCBY9y85F6qJoAaRu91cuvYU+bjxrFI=
Date: Tue, 16 Nov 2021 14:58:08 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: ethdev: hide internal structures
Message-ID: <20211116225808.GA27960@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <DM6PR11MB4491BE29A03C5D8625F66BD69A999@DM6PR11MB4491.namprd11.prod.outlook.com>
 <20211116191018.GA31070@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <20211116132510.49731a0c@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211116132510.49731a0c@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Nov 16, 2021 at 01:25:10PM -0800, Stephen Hemminger wrote:
> On Tue, 16 Nov 2021 11:10:18 -0800
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> 
> > On Tue, Nov 16, 2021 at 10:32:55AM +0000, Ananyev, Konstantin wrote:
> > >  
> > > rte_eth_dev,  rte_eth_dev_data, rte_eth_rxtx_callback are internal
> > > data structures that were used by public inline ethdev functions. 
> > > Well behaving app should not access these data structures directly.
> > > So, for well behaving app there should no changes in the code required.
> > > That what I meant by 'transparent' above.
> > > But it is still an ABI change, so yes, the app has to be re-compiled.   
> > 
> > so it appears the application was establishing a private context /
> > vendor extension between the application and a pmd. the application
> > was abusing access to the rte_eth_devices[] to get the private context
> > from the rte_eth_dev.
> > 
> > is there a proper / supported way of providing this functionality
> > through the public api?
> > 
> > > 
> > > Konstantin  
> 
> Keep a array in application?  Portid is universally
> available.
> 
> struct my_portdata *my_ports[RTE_ETH_MAXPORTS];

i guess by this you mean maintain the storage in the application and
then export that storage for proprietary use in the pmd. ordinarily i
wouldn't want to have this hard-coded into the modules abi but since
we are talking about vendor extensions it has to be managed somewhere.

anyway, i guess i have my answer.

thanks stephen, appreciate it.