From: Joyce Kong <joyce.kong@arm.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com,
Joyce Kong <joyce.kong@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: [PATCH v3 04/12] test/stack_perf: use compiler atomics for lcore sync
Date: Wed, 17 Nov 2021 08:21:52 +0000 [thread overview]
Message-ID: <20211117082200.1029621-5-joyce.kong@arm.com> (raw)
In-Reply-To: <20211117082200.1029621-1-joyce.kong@arm.com>
Convert rte_atomic usages to compiler atomic built-ins
for lcore sync in stack_perf test cases.
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
app/test/test_stack_perf.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c
index 4ee40d5d19..1eae00a334 100644
--- a/app/test/test_stack_perf.c
+++ b/app/test/test_stack_perf.c
@@ -6,7 +6,6 @@
#include <stdio.h>
#include <inttypes.h>
-#include <rte_atomic.h>
#include <rte_cycles.h>
#include <rte_launch.h>
#include <rte_pause.h>
@@ -24,7 +23,7 @@
*/
static volatile unsigned int bulk_sizes[] = {8, MAX_BURST};
-static rte_atomic32_t lcore_barrier;
+static uint32_t lcore_barrier;
struct lcore_pair {
unsigned int c1;
@@ -144,9 +143,8 @@ bulk_push_pop(void *p)
s = args->s;
size = args->sz;
- rte_atomic32_sub(&lcore_barrier, 1);
- while (rte_atomic32_read(&lcore_barrier) != 0)
- rte_pause();
+ __atomic_fetch_sub(&lcore_barrier, 1, __ATOMIC_RELAXED);
+ rte_wait_until_equal_32(&lcore_barrier, 0, __ATOMIC_RELAXED);
uint64_t start = rte_rdtsc();
@@ -175,7 +173,7 @@ run_on_core_pair(struct lcore_pair *cores, struct rte_stack *s,
unsigned int i;
for (i = 0; i < RTE_DIM(bulk_sizes); i++) {
- rte_atomic32_set(&lcore_barrier, 2);
+ __atomic_store_n(&lcore_barrier, 2, __ATOMIC_RELAXED);
args[0].sz = args[1].sz = bulk_sizes[i];
args[0].s = args[1].s = s;
@@ -208,7 +206,7 @@ run_on_n_cores(struct rte_stack *s, lcore_function_t fn, int n)
int cnt = 0;
double avg;
- rte_atomic32_set(&lcore_barrier, n);
+ __atomic_store_n(&lcore_barrier, n, __ATOMIC_RELAXED);
RTE_LCORE_FOREACH_WORKER(lcore_id) {
if (++cnt >= n)
@@ -302,7 +300,7 @@ __test_stack_perf(uint32_t flags)
struct lcore_pair cores;
struct rte_stack *s;
- rte_atomic32_init(&lcore_barrier);
+ __atomic_store_n(&lcore_barrier, 0, __ATOMIC_RELAXED);
s = rte_stack_create(STACK_NAME, STACK_SIZE, rte_socket_id(), flags);
if (s == NULL) {
--
2.25.1
next prev parent reply other threads:[~2021-11-17 8:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 9:41 [PATCH v2 00/12] use compiler atomic builtins for app modules Joyce Kong
2021-11-16 9:41 ` [PATCH v2 01/12] test/pmd_perf: use compiler atomic builtins for polling sync Joyce Kong
2021-11-16 21:30 ` Honnappa Nagarahalli
2021-11-16 9:41 ` [PATCH v2 02/12] test/ring_perf: use compiler atomic builtins for lcores sync Joyce Kong
2021-11-16 9:41 ` [PATCH v2 03/12] test/timer: use compiler atomic builtins for sync Joyce Kong
2021-11-16 19:52 ` Honnappa Nagarahalli
2021-11-16 20:20 ` David Marchand
2021-11-16 21:21 ` Honnappa Nagarahalli
2021-11-17 9:29 ` David Marchand
2021-11-16 9:41 ` [PATCH v2 04/12] test/stack_perf: use compiler atomics for lcore sync Joyce Kong
2021-11-16 9:41 ` [PATCH v2 05/12] test/bpf: use compiler atomics for calculation Joyce Kong
2021-11-16 9:41 ` [PATCH v2 06/12] test/func_reentrancy: use compiler atomics for data sync Joyce Kong
2021-11-16 9:42 ` [PATCH v2 07/12] app/eventdev: use compiler atomics for shared " Joyce Kong
2021-11-16 9:42 ` [PATCH v2 08/12] app/crypto: use compiler atomic builtins for display sync Joyce Kong
2021-11-16 9:42 ` [PATCH v2 09/12] app/compress: " Joyce Kong
2021-11-16 20:15 ` Honnappa Nagarahalli
2021-11-16 9:42 ` [PATCH v2 10/12] app/testpmd: remove atomic operations for port status Joyce Kong
2021-11-16 21:34 ` Honnappa Nagarahalli
2021-11-16 9:42 ` [PATCH v2 11/12] app/bbdev: use compiler atomics for shared data sync Joyce Kong
2021-11-16 9:42 ` [PATCH v2 12/12] app: remove unnecessary include of atomic header file Joyce Kong
2021-11-16 20:23 ` David Marchand
2021-11-17 7:05 ` Joyce Kong
2021-11-17 8:21 ` [PATCH v3 00/12] use compiler atomic builtins for app modules Joyce Kong
2021-11-17 8:21 ` [PATCH v3 01/12] test/pmd_perf: use compiler atomic builtins for polling sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 02/12] test/ring_perf: use compiler atomic builtins for lcores sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 03/12] test/timer: use compiler atomic builtins for sync Joyce Kong
2021-11-17 8:21 ` Joyce Kong [this message]
2021-11-17 8:21 ` [PATCH v3 05/12] test/bpf: use compiler atomics for calculation Joyce Kong
2021-11-17 8:21 ` [PATCH v3 06/12] test/func_reentrancy: use compiler atomics for data sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 07/12] app/eventdev: use compiler atomics for shared " Joyce Kong
2021-11-17 8:21 ` [PATCH v3 08/12] app/crypto: use compiler atomic builtins for display sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 09/12] app/compress: " Joyce Kong
2021-11-17 8:21 ` [PATCH v3 10/12] app/testpmd: remove atomic operations for port status Joyce Kong
2021-11-17 8:21 ` [PATCH v3 11/12] app/bbdev: use compiler atomics for shared data sync Joyce Kong
2021-11-17 8:22 ` [PATCH v3 12/12] app: remove unnecessary include of atomic header file Joyce Kong
2021-11-17 10:02 ` [PATCH v3 00/12] use compiler atomic builtins for app modules David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117082200.1029621-5-joyce.kong@arm.com \
--to=joyce.kong@arm.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).