From: Dariusz Sosnowski <dsosnowski@nvidia.com> To: Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Dmitry Kozlyuk <dkozlyuk@nvidia.com> Cc: <dev@dpdk.org> Subject: [PATCH] net/mlx5: fix refcount on detached indirect action Date: Wed, 17 Nov 2021 17:46:05 +0200 Message-ID: <20211117154605.112390-1-dsosnowski@nvidia.com> (raw) This patch fixes segfault which was triggered when port, with indirect actions created, was closed. Segfault was occurring only when RTE_LIBRTE_MLX5_DEBUG was defined. It was caused by redundant decrement of RX queues refcount: - refcount was decremented when port was stopped and indirect actions were detached from RX queues (port stop), - refcount was decremented when indirect actions objects were destroyed (port close or destroying of indirect action). With this patch RX queues refcounts are decremented if and only if indirect actions object is detached or indirect actions object is destroyed. Fixes: ec4e11d41d12 ("net/mlx5: preserve indirect actions on restart") Cc: dkozlyuk@nvidia.com Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com> Acked-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com> --- drivers/net/mlx5/mlx5_rxq.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 52b95d7070..b7af60df38 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2214,8 +2214,15 @@ mlx5_ind_table_obj_release(struct rte_eth_dev *dev, if (ret) return 1; priv->obj_ops.ind_table_destroy(ind_tbl); - for (i = 0; i != ind_tbl->queues_n; ++i) - claim_nonzero(mlx5_rxq_deref(dev, ind_tbl->queues[i])); + /* + * Refcounts on RX queues are decremented if and only if indirection + * table was attached to RX queues. It will not be the case after + * calling mlx5_dev_stop. + */ + if (priv->dev_data->dev_started) { + for (i = 0; i != ind_tbl->queues_n; ++i) + claim_nonzero(mlx5_rxq_deref(dev, ind_tbl->queues[i])); + } mlx5_free(ind_tbl); return 0; } -- 2.25.1
next reply other threads:[~2021-11-17 15:48 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-17 15:46 Dariusz Sosnowski [this message] 2021-11-22 14:17 ` [PATCH v2] " Dariusz Sosnowski 2021-11-22 17:09 ` [PATCH v3] " Dariusz Sosnowski 2021-11-23 13:26 ` Slava Ovsiienko 2021-11-23 15:38 ` [PATCH v4] " Dariusz Sosnowski 2021-11-23 20:35 ` Raslan Darawsheh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211117154605.112390-1-dsosnowski@nvidia.com \ --to=dsosnowski@nvidia.com \ --cc=dev@dpdk.org \ --cc=dkozlyuk@nvidia.com \ --cc=matan@nvidia.com \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git