From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29DA9A0C41; Tue, 23 Nov 2021 20:10:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 766324114D; Tue, 23 Nov 2021 20:10:27 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 9532140040 for <dev@dpdk.org>; Tue, 23 Nov 2021 20:10:25 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id g18so224470pfk.5 for <dev@dpdk.org>; Tue, 23 Nov 2021 11:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w+nX1+WsdyuxSFJ1ePcpll0uCSzQId2gNKwFgLkB0tA=; b=bQWpbytgY95aQC+XMx4kwHMsfkSCDzMC1elMLUIUDw9c3w1//pY2FyTEVhKMtzQm4Z Az5Yj4i6lpUtlz9nE9rNprVJ7Cp09FhOTHiu1CUvTQ2s5Y+Jv9UXYp3b1TyzkqWI7TdI aD4NFfMeHV4+QYSjl3O4E704dQC6BOJDfsj4V7gmV32/Ku68AcobfenanrFWXQ41PSf2 yB+BnwKlrC/HXXrVqn+XFKlaSMI/8FHim5WHI41/xjS65NRihAOeQFmUE+Ha6tj9ySBv UhdG2a4qoHFHxYp/Mavw3OsgamZHmFVD97kriqfiBk7lMg6PYfZ0SRJqvhYrgSth5XoJ X03g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w+nX1+WsdyuxSFJ1ePcpll0uCSzQId2gNKwFgLkB0tA=; b=NMo/6iWrgy13HqKKqP0yv5Nizk5krHYgvHj6sezDJeAia5R4JW0GKh7Gx2D3Phd+KP 6CKBYO/ost9gJfYco56uuItnZGMF2PZ91L/fFMNHDVIGaOvZ6ben/gQPVs4W0oZrdRkX EhGxmOBt+22c7AvsiO/AnULd/Ah8W3gIaiFVbK85mkQpGXIiL8zhYFZy2qCoR3eViGJy bqG8H++DjdWSeNd5KYqn4iu+wA4L53QQNXGUZcLflCDLHzzx6C7doXuUbUDXk34sNhc0 imjp666KCGe97z494Q3FKUuMBIqkbbA7ey+OrkOCbSjg46COczmGSD7oNwF+xGi7SyZ4 HV5Q== X-Gm-Message-State: AOAM531BEO/MSVHVNooCdnz+FCf/VoLQX7yoABHAhO8aoo2ZzbhZco6h 8oiPUIIgqOmez/+dk7tkFj9b4A== X-Google-Smtp-Source: ABdhPJwKwgOnqKjChBSD8W+lX3wQeJvm3HE/+Cxrj5es+EcAekfvndl5LrvsUHKptE6iglYsHCCGrA== X-Received: by 2002:a05:6a00:1a04:b0:4a6:4384:2e5f with SMTP id g4-20020a056a001a0400b004a643842e5fmr4301710pfv.36.1637694624433; Tue, 23 Nov 2021 11:10:24 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id ot7sm2108011pjb.21.2021.11.23.11.10.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 11:10:24 -0800 (PST) Date: Tue, 23 Nov 2021 11:10:21 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>, Elad Nachman <eladv6@gmail.com>, <dev@dpdk.org>, <stable@dpdk.org>, Igor Ryzhov <iryzhov@nfware.com>, Eric Christian <erclists@gmail.com> Subject: Re: [PATCH] kni: restrict bifurcated device support Message-ID: <20211123111021.08763407@hermes.local> In-Reply-To: <0914b58e-de54-50ef-7e48-febf9688eb09@intel.com> References: <20211008235830.127167-1-ferruh.yigit@intel.com> <20211008190335.1fdc8f4a@hermes.local> <f7269e9c-8238-0e43-96ba-0b9f14bf4f58@intel.com> <20211123082218.11b894b0@hermes.local> <0914b58e-de54-50ef-7e48-febf9688eb09@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 23 Nov 2021 16:51:27 +0000 Ferruh Yigit <ferruh.yigit@intel.com> wrote: > >>> > >>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c > >>> index 611719b5ee27..d47fc6133cbe 100644 > >>> --- a/kernel/linux/kni/kni_net.c > >>> +++ b/kernel/linux/kni/kni_net.c > >>> @@ -838,6 +838,14 @@ kni_net_init(struct net_device *dev) > >>> dev->header_ops = &kni_net_header_ops; > >>> dev->ethtool_ops = &kni_net_ethtool_ops; > >>> dev->watchdog_timeo = WD_TIMEOUT; > >>> + > >>> + /* > >>> + * KNI is unsafe since it requires calling userspace to do > >>> + * control operations. And the overall quality according to > >>> + * kernel standards is the same as devices in staging. > >>> + */ > >>> + add_taint(TAINT_CRAP, LOCKDEP_STILL_OK); > >>> + netdev_warn(dev, "Adding kernel taint for KNI because it is not safe\n"); > >> > >> I am for discussing above separate from this patch, since this patch > >> restores the behavior that exist since KNI module exists. > > > > Any user of KNI will already get tainted because KNI is out of tree driver. > > > > I mean the note and explicit 'add_taint()' you mentioned above, can we separate > it from this bug fix. I changed my mind, the existing taint that happens from out of tree is enough. Especially since KNI is now deprecated.