Re: [PATCH v1] examples/l3fwd-power: add wakeup log

Re: [PATCH v1] examples/l3fwd-power: add wakeup log

[David Hunt]

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

Hi Li,

On 16/11/2021 1:00 PM, Miao Li wrote:
> This patch adds a log in main telemetry loop to show the thread is
> waked up and begins to send and receive packets.
>
> Signed-off-by: Miao Li <miao.li@intel.com>
> ---
>   examples/l3fwd-power/main.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index 6988a0ed34..b8c020fb91 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -1156,6 +1156,9 @@ main_telemetry_loop(__rte_unused void *dummy)
>   			ep_nep[nb_rx == 0]++;
>   			fp_nfp[nb_rx == MAX_PKT_BURST]++;
>   			poll_count++;
> +			RTE_LOG(INFO, L3FWD_POWER,
> +				"lcore %u is waked up on port %d queue %d\n",
> +				rte_lcore_id(), portid, queueid);
>   			if (unlikely(nb_rx == 0))
>   				continue;
>   


It's probably better to say "lcore %u is *reading *port %d queue %d".

Regards,
Dave.


[-- Attachment #2: Type: text/html, Size: 1359 bytes --]

[PATCH v1] examples/l3fwd-power: add wakeup log

[Miao Li]

This patch adds a log in main telemetry loop to show the thread is
waked up and begins to send and receive packets.

Signed-off-by: Miao Li <miao.li@intel.com>
---
 examples/l3fwd-power/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 6988a0ed34..b8c020fb91 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1156,6 +1156,9 @@ main_telemetry_loop(__rte_unused void *dummy)
 			ep_nep[nb_rx == 0]++;
 			fp_nfp[nb_rx == MAX_PKT_BURST]++;
 			poll_count++;
+			RTE_LOG(INFO, L3FWD_POWER,
+				"lcore %u is waked up on port %d queue %d\n",
+				rte_lcore_id(), portid, queueid);
 			if (unlikely(nb_rx == 0))
 				continue;
 
-- 
2.25.1

Re: [PATCH v2] examples/l3fwd-power: add wakeup log

[David Hunt]

On 17/11/2021 10:35 AM, Miao Li wrote:
> This patch adds a log in main telemetry loop to show the thread has
> woken up and begun to send and receive packets.
>
> Signed-off-by: Miao Li <miao.li@intel.com>
> ---
>   examples/l3fwd-power/main.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index 6988a0ed34..547785dafb 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -1156,6 +1156,9 @@ main_telemetry_loop(__rte_unused void *dummy)
>   			ep_nep[nb_rx == 0]++;
>   			fp_nfp[nb_rx == MAX_PKT_BURST]++;
>   			poll_count++;
> +			RTE_LOG(INFO, L3FWD_POWER,
> +				"lcore %u has woken up on port %d queue %d\n",
> +				rte_lcore_id(), portid, queueid);
>   			if (unlikely(nb_rx == 0))
>   				continue;
>   


Acked-by: David Hunt <david.hunt@intel.com>

Re: [PATCH v2] examples/l3fwd-power: add wakeup log

[Thomas Monjalon]

17/11/2021 09:57, David Hunt:
> 
> On 17/11/2021 10:35 AM, Miao Li wrote:
> > This patch adds a log in main telemetry loop to show the thread has
> > woken up and begun to send and receive packets.
> >
> > Signed-off-by: Miao Li <miao.li@intel.com>
> 
> Acked-by: David Hunt <david.hunt@intel.com>

Applied, thanks.

[PATCH v2] examples/l3fwd-power: add wakeup log

[Miao Li]

This patch adds a log in main telemetry loop to show the thread has
woken up and begun to send and receive packets.

Signed-off-by: Miao Li <miao.li@intel.com>
---
 examples/l3fwd-power/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 6988a0ed34..547785dafb 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1156,6 +1156,9 @@ main_telemetry_loop(__rte_unused void *dummy)
 			ep_nep[nb_rx == 0]++;
 			fp_nfp[nb_rx == MAX_PKT_BURST]++;
 			poll_count++;
+			RTE_LOG(INFO, L3FWD_POWER,
+				"lcore %u has woken up on port %d queue %d\n",
+				rte_lcore_id(), portid, queueid);
 			if (unlikely(nb_rx == 0))
 				continue;
 
-- 
2.25.1

[PATCH] examples/power: revert "add wakeup log"

[David Hunt]

This reverts commit 931e3a994597acb9ffa827376206e8aa324476b7.

Wakeup happens quite often (several hundred times a second) in
l3fwd-power example app in PMD power management mode, so this
message is appearing too often to be useful. This patch reverts
that info message addition.

Fixes: 931e3a994597 ("examples/l3fwd-power: add wakeup log")

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 examples/l3fwd-power/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 5c5825166d..b8b3be2b8a 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1156,9 +1156,6 @@ main_telemetry_loop(__rte_unused void *dummy)
 			ep_nep[nb_rx == 0]++;
 			fp_nfp[nb_rx == MAX_PKT_BURST]++;
 			poll_count++;
-			RTE_LOG(INFO, L3FWD_POWER,
-				"lcore %u has woken up on port %d queue %d\n",
-				rte_lcore_id(), portid, queueid);
 			if (unlikely(nb_rx == 0))
 				continue;
 
-- 
2.17.1

RE: [PATCH] examples/power: revert "add wakeup log"

[Pattan, Reshma]

> -----Original Message-----
> From: David Hunt <david.hunt@intel.com>
> This reverts commit 931e3a994597acb9ffa827376206e8aa324476b7.
> 
> Wakeup happens quite often (several hundred times a second) in l3fwd-power
> example app in PMD power management mode, so this message is appearing
> too often to be useful. This patch reverts that info message addition.
> 
> Fixes: 931e3a994597 ("examples/l3fwd-power: add wakeup log")
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
Tested-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Re: [PATCH] examples/power: revert "add wakeup log"

[Thomas Monjalon]

24/11/2021 13:17, Pattan, Reshma:
> > From: David Hunt <david.hunt@intel.com>
> > This reverts commit 931e3a994597acb9ffa827376206e8aa324476b7.
> > 
> > Wakeup happens quite often (several hundred times a second) in l3fwd-power
> > example app in PMD power management mode, so this message is appearing
> > too often to be useful.

It was my initial thought but I merged it anyway because you acked.

> > This patch reverts that info message addition.
> > 
> > Fixes: 931e3a994597 ("examples/l3fwd-power: add wakeup log")
> > 
> > Signed-off-by: David Hunt <david.hunt@intel.com>
> Tested-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Applied