DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bing Zhao <bingz@nvidia.com>
To: <viacheslavo@nvidia.com>, <matan@nvidia.com>
Cc: <dev@dpdk.org>, <rasland@nvidia.com>, <stable@dpdk.org>,
	Li Zhang <lizh@nvidia.com>, Shun Hao <shunh@nvidia.com>
Subject: [PATCH] net/mlx5: fix RSS validation for meter hierarchy
Date: Tue, 23 Nov 2021 18:00:11 +0200
Message-ID: <20211123160011.79219-1-bingz@nvidia.com> (raw)

In a meter hierarchy, all the meters are marked with having RSS if
the final meter's termination action is RSS.

When validating a flow rule with meter hierarchy, the RSS action
should not be fetched from the current meter if it is not the final

The fate action union is next meter ID instead of the pointer to the
RSS action. By using the final meter in the hierarchy, the flow rule
validation will succeed without any crash caused by the invalide RSS
action pointer access.

Fixes: 1ce19ab1f43b ("net/mlx5: fix RSS validation with meter policy")
Cc: stable@dpdk.org

Signed-off-by: Bing Zhao <bingz@nvidia.com>
Reviewed-by: Li Zhang <lizh@nvidia.com>
Reviewed-by: Shun Hao <shunh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
 drivers/net/mlx5/mlx5_flow_dv.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 2f03e59f9c..f5356418fa 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -5254,13 +5254,21 @@ mlx5_flow_validate_action_meter(struct rte_eth_dev *dev,
 						"Flow and meter policy "
 						"have different src port.");
 		} else if (mtr_policy->is_rss) {
-			struct mlx5_meter_policy_action_container *acg =
-				&mtr_policy->act_cnt[RTE_COLOR_GREEN];
-			struct mlx5_meter_policy_action_container *acy =
-				&mtr_policy->act_cnt[RTE_COLOR_YELLOW];
+			struct mlx5_flow_meter_policy *fp;
+			struct mlx5_meter_policy_action_container *acg;
+			struct mlx5_meter_policy_action_container *acy;
 			const struct rte_flow_action *rss_act;
 			int ret;
+			fp = mlx5_flow_meter_hierarchy_get_final_policy(dev,
+								mtr_policy);
+			if (fp == NULL)
+				return rte_flow_error_set(error, EINVAL,
+						  "Unable to get the final "
+						  "policy in the hierarchy");
+			acg = &fp->act_cnt[RTE_COLOR_GREEN];
+			acy = &fp->act_cnt[RTE_COLOR_YELLOW];
 			MLX5_ASSERT(acg->fate_action ==
 				    acy->fate_action ==

             reply	other threads:[~2021-11-23 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 16:00 Bing Zhao [this message]
2021-11-23 16:05 ` [PATCH v2] " Bing Zhao
2021-11-23 20:34   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211123160011.79219-1-bingz@nvidia.com \
    --to=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=lizh@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=shunh@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git