From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADBA4A0C4C; Tue, 23 Nov 2021 23:02:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 343A840040; Tue, 23 Nov 2021 23:02:09 +0100 (CET) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mails.dpdk.org (Postfix) with ESMTP id 003334003C for ; Tue, 23 Nov 2021 23:02:07 +0100 (CET) Received: by mail-lj1-f177.google.com with SMTP id d11so1026314ljg.8 for ; Tue, 23 Nov 2021 14:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SZPxSUnNI1ASJ+19WItdeWrumzUkxcI5J/wWcEFWKAA=; b=QmcuOmXcEcdO0H0Lp/xcIG7R1u9FLlnHV+leLoOUCNzRfMBTUa+rZYHUagQogGXfN7 qGXgKDXjZDzjeaDmZZTNm8xaYfBuOE56C6IABcAsQq+40s5kL5chv36uN1vkbwEyMp50 nGf91lkYhGWYB1U5fopswCPiB06oGOx70Z3b+hOGz3hDFC5twysD4MtH6XJKsPeeaFxK ksYiLPBUHFI7juJz7SxlN1giyEAQJwMcN1zmQEFq9KxOVxD7DvE+VAmvs8mTp+SoLyIa qb383c419zq4qv29Ob1g8grtcwyf1l14UDq1QUoiatOwYv91N3/16ROyoaIX/xrjeksj rGsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SZPxSUnNI1ASJ+19WItdeWrumzUkxcI5J/wWcEFWKAA=; b=0FZLPuoiiEB4zxzjzQM3j2eDhts7qpL++sie54OG2JR4thJogGwLDjf8oQqmTBKdY2 BTjevY6RHlB7vXzJ0tOvZK2cKWebiQvhawInjE2pzPTINIF1FPI3hrAC3bXOh4dXBhEc dObFT1HNSB9wnPnAOJcpA3anUhaHfBLOd7xNxkTSWLkSyevkbDuAbHPnOSiBTEMLwYvK 3MY/4RZ13hToFmWvA5XURVZa7cytRzA1vWCIjVBtlcfEpdOgbue9oVahZOriccOM3R79 huW6PTmz71ithAouI71Wq91zaqHuc7MmzhCgSHgn3eNJ4Dxio/8qremvjpRPDOKES6mE bXUA== X-Gm-Message-State: AOAM531Vuw8GGV2Wx+z/1L2CyOG8IJnOBe6laOsABJ6YnMMORAyHd02K 1nXRpcF9kGkZkkXijSLuk2g= X-Google-Smtp-Source: ABdhPJyptahGG2TC75T2x+FKwkgYQTrKQvhme191K+Xhy4Kk/hRXMyH5f4DsSMepB+V7ML095Bc5FA== X-Received: by 2002:a05:651c:111:: with SMTP id a17mr9857123ljb.456.1637704927433; Tue, 23 Nov 2021 14:02:07 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id i13sm1416559lfb.45.2021.11.23.14.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 14:02:06 -0800 (PST) Date: Wed, 24 Nov 2021 01:02:06 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v8 03/11] app/test: replace POSIX specific code Message-ID: <20211124010206.6ca9d9cf@sovereign> In-Reply-To: <1635216361-23641-4-git-send-email-jizh@linux.microsoft.com> References: <1635215204-20604-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-4-git-send-email-jizh@linux.microsoft.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2021-10-25 19:45 (UTC-0700), Jie Zhou: > - Include rte_os_shim.h > - Replace sleep and usleep with rte_delay_us_sleep > - #ifndef RTE_EXEC_ENV_WINDOWS for POSIX code only > > Signed-off-by: Jie Zhou > --- This patch can be combined with the previous one: they serve the same purpose---to remove Unix-specific code. Please try to summarize in the commit message which parts of the tests suites are excluded, e.g. multi-process. It is more useful then stating what was changed in the code. [...] > diff --git a/app/test/test_cmdline.c b/app/test/test_cmdline.c > index 115bee966d..9a76bd299f 100644 > --- a/app/test/test_cmdline.c > +++ b/app/test/test_cmdline.c > @@ -31,6 +31,7 @@ test_cmdline(void) > return -1; > if (test_parse_num_invalid_param() < 0) > return -1; > +#ifndef RTE_EXEC_ENV_WINDOWS > printf("Testing parsing IP addresses...\n"); > if (test_parse_ipaddr_valid() < 0) > return -1; > @@ -38,6 +39,7 @@ test_cmdline(void) > return -1; > if (test_parse_ipaddr_invalid_param() < 0) > return -1; > +#endif > printf("Testing parsing strings...\n"); > if (test_parse_string_valid() < 0) > return -1; What's wrong with parsing IP addresses on Windows? [...] > diff --git a/app/test/test_mp_secondary.c b/app/test/test_mp_secondary.c > index 5b6f05dbb1..da035348bd 100644 > --- a/app/test/test_mp_secondary.c > +++ b/app/test/test_mp_secondary.c > @@ -14,7 +14,9 @@ > #include > #include > #include > +#ifndef RTE_EXEC_ENV_WINDOWS > #include > +#endif > #include > #include > #include is absent on Windows for sure, but you don't exclude it. Does this file even need modification? It's not going to be compiled for Windows. [...] > diff --git a/app/test/test_ring_stress.c b/app/test/test_ring_stress.c > index 1af45e0fc8..ce3535c6b2 100644 > --- a/app/test/test_ring_stress.c > +++ b/app/test/test_ring_stress.c > @@ -43,9 +43,10 @@ test_ring_stress(void) > n += test_ring_rts_stress.nb_case; > k += run_test(&test_ring_rts_stress); > > +#ifndef RTE_EXEC_ENV_WINDOWS > n += test_ring_hts_stress.nb_case; > k += run_test(&test_ring_hts_stress); > - > +#endif Can you please elaborate what is the issue with this case? It is also one of the details you usually want to put into the commit message.