From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CC64A0C4C; Tue, 23 Nov 2021 23:02:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 245514113E; Tue, 23 Nov 2021 23:02:14 +0100 (CET) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id 2F07B4113D for ; Tue, 23 Nov 2021 23:02:12 +0100 (CET) Received: by mail-lf1-f49.google.com with SMTP id bi37so1661546lfb.5 for ; Tue, 23 Nov 2021 14:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EiTeNjwdlDixXHm3NFr7OqGJtUEqcVOW9zOaN5tj7FI=; b=UkkITwCxxswFV1bO8nC5Oqa4PFKVHwMgEypdK/18gWN+WOiy9ydy45XXWUeh2kxIBi 4nYTl3+SX7UYXleucGG2rWQDQp2xIxDDUsgE/EShUuHUd0CgSeCY/ONgUkuvxWti7tAr kbpMbSkaxepNUB97uhFQ1bWEdw/mPK/DCpdYB5xdNqe8Jp7RO7VvfZkgwHwemixpuwJL 551tjRtp4GpqmjjwSCqs6IaP8pV/rN/fcaeEEBKLJjiDI9Qa8AaKKET8ww/50kvgXtTa 4Z0j5c9GCVMBewfOYbsL8IDFThfcCwTBytTtSc46yxJn4xXHavTn9MViZ4RkoTExMVUd R84w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EiTeNjwdlDixXHm3NFr7OqGJtUEqcVOW9zOaN5tj7FI=; b=QKhVKN6nXllRoSsK2/ESF6Yh3JuVA8QYbzLGg3f/FlRmtB5baflUs5ujpI2J5nx6RZ mWFUKkFB8kKdaIUFU/hC8THBGgziQMme0ZJPHc2r+EZ4RKlmmjVd0vxIpo44HtTeOdUx 5COGaZCtNG1K25L9Ir9pOJ5Mtb/GFhOex9YWe75qT36N/kn086A8ez4Fpn4Woi8RXISG Jjop0i0ma0smPohpmJeb/xgVSKX+vMSKmnQmTLIFGtDkE3/dI1Hv4SRJdGBIa+e664lc MI+HI2Mr4prpsCdbQM3oqGeYiau8/NZpp0Z4azH4H8+127mgA8YijuaumNc9UTnvRFTf JfHQ== X-Gm-Message-State: AOAM530gvadi4au+/ITfGkC/tc/EFb7g9pF/Wns9TYih204K2ch7BjIL 57dVRRKzxf0Zur624L/WSrM= X-Google-Smtp-Source: ABdhPJxcYgemqDwgzmhYQUqPJgJh6iXS7WIK2UUpKrFSN+mxpB64blj/8N8uU4XbR3FgJukNbAfSJA== X-Received: by 2002:a05:6512:3d8e:: with SMTP id k14mr8322686lfv.272.1637704931802; Tue, 23 Nov 2021 14:02:11 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id x27sm1412727lfq.192.2021.11.23.14.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 14:02:11 -0800 (PST) Date: Wed, 24 Nov 2021 01:02:10 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v8 04/11] app/test: exclude ENOTSUP as failure Message-ID: <20211124010210.7fcb23b2@sovereign> In-Reply-To: <1635216361-23641-5-git-send-email-jizh@linux.microsoft.com> References: <1635215204-20604-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-5-git-send-email-jizh@linux.microsoft.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2021-10-25 19:45 (UTC-0700), Jie Zhou: > Check rte_errno to exclude ENOTSUP as failures in test_memory.c > > Signed-off-by: Jie Zhou > --- > app/test/test_memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_memory.c b/app/test/test_memory.c > index dbf6871e71..379b0f99ca 100644 > --- a/app/test/test_memory.c > +++ b/app/test/test_memory.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > #include "test.h" > > @@ -63,7 +64,7 @@ check_seg_fds(const struct rte_memseg_list *msl, const struct rte_memseg *ms, > /* we're able to get memseg fd - try getting its offset */ > ret = rte_memseg_get_fd_offset_thread_unsafe(ms, &offset); > if (ret < 0) { > - if (errno == ENOTSUP) > + if (rte_errno == ENOTSUP) > return 1; > return -1; > } The commit title and message contradict what is inside. ENOTSUP was excluded previously, but errno was checked instead of rte_errno. It should be stated what was wrong and how it is fixed (with a Fixes tag).