DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] maintainers: update for driver testing tool
@ 2021-10-22  7:19 Aman Singh
  2021-10-22  8:57 ` Ferruh Yigit
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Aman Singh @ 2021-10-22  7:19 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit

For test-pmd adding Aman Singh

Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 278e5b3226..c4070fe668 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1637,6 +1637,7 @@ F: app/test/sample_packet_forward.h
 
 Driver testing tool
 M: Xiaoyun Li <xiaoyun.li@intel.com>
+M: Aman Singh <aman.deep.singh@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/
-- 
2.17.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] maintainers: update for driver testing tool
  2021-10-22  7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
@ 2021-10-22  8:57 ` Ferruh Yigit
  2021-11-25 10:00   ` Thomas Monjalon
  2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
  2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
  2 siblings, 1 reply; 15+ messages in thread
From: Ferruh Yigit @ 2021-10-22  8:57 UTC (permalink / raw)
  To: Aman Singh, dev; +Cc: Xiaoyun Li

On 10/22/2021 8:19 AM, Aman Singh wrote:
> For test-pmd adding Aman Singh
> 
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>

Thanks Aman for volunteering.

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] maintainers: update for driver testing tool
  2021-10-22  8:57 ` Ferruh Yigit
@ 2021-11-25 10:00   ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2021-11-25 10:00 UTC (permalink / raw)
  To: Aman Singh, Xiaoyun Li, Ferruh Yigit; +Cc: dev

22/10/2021 10:57, Ferruh Yigit:
> On 10/22/2021 8:19 AM, Aman Singh wrote:
> > For test-pmd adding Aman Singh
> > 
> > Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> 
> Thanks Aman for volunteering.
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

I'll take this opportunity to update the section title. v2 coming.




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2] maintainers: update for testpmd
  2021-10-22  7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
  2021-10-22  8:57 ` Ferruh Yigit
@ 2021-11-25 10:01 ` Thomas Monjalon
  2021-11-25 13:40   ` Ferruh Yigit
  2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
  2 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2021-11-25 10:01 UTC (permalink / raw)
  To: dev; +Cc: Aman Singh, Ferruh Yigit

From: Aman Singh <aman.deep.singh@intel.com>

Add Aman Singh as co-maintainer of testpmd.

Make the title description more accurate for this tool.

Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: update the section title
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d785363c5c..1b259a3d98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
 F: app/test/sample_packet_forward.c
 F: app/test/sample_packet_forward.h
 
-Driver testing tool
+Networking features testing tool
 M: Xiaoyun Li <xiaoyun.li@intel.com>
+M: Aman Singh <aman.deep.singh@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/
-- 
2.33.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
@ 2021-11-25 13:40   ` Ferruh Yigit
  2021-11-25 15:20     ` Thomas Monjalon
  0 siblings, 1 reply; 15+ messages in thread
From: Ferruh Yigit @ 2021-11-25 13:40 UTC (permalink / raw)
  To: Thomas Monjalon, dev; +Cc: Aman Singh

On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> From: Aman Singh <aman.deep.singh@intel.com>
> 
> Add Aman Singh as co-maintainer of testpmd.
> 
> Make the title description more accurate for this tool.
> 
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: update the section title
> ---
>   MAINTAINERS | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d785363c5c..1b259a3d98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
>   F: app/test/sample_packet_forward.c
>   F: app/test/sample_packet_forward.h
>   
> -Driver testing tool
> +Networking features testing tool

"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better,
according previous title it is for driver testing.

>   M: Xiaoyun Li <xiaoyun.li@intel.com>
> +M: Aman Singh <aman.deep.singh@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
>   F: app/test-pmd/
>   F: doc/guides/testpmd_app_ug/
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 13:40   ` Ferruh Yigit
@ 2021-11-25 15:20     ` Thomas Monjalon
  2021-11-25 16:04       ` Ferruh Yigit
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2021-11-25 15:20 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Aman Singh, andrew.rybchenko

25/11/2021 14:40, Ferruh Yigit:
> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> > -Driver testing tool
> > +Networking features testing tool
> 
> "Networking features" scope is a little wide.
> Not sure if "Networking features" or "Networking drivers" suits better,
> according previous title it is for driver testing.

Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf
which is also testing networking drivers.

Maybe "Networking drivers features testing tool" ?





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 15:20     ` Thomas Monjalon
@ 2021-11-25 16:04       ` Ferruh Yigit
  2021-11-25 16:31         ` Ferruh Yigit
  0 siblings, 1 reply; 15+ messages in thread
From: Ferruh Yigit @ 2021-11-25 16:04 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Aman Singh, andrew.rybchenko

On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> 25/11/2021 14:40, Ferruh Yigit:
>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>> -Driver testing tool
>>> +Networking features testing tool
>>
>> "Networking features" scope is a little wide.
>> Not sure if "Networking features" or "Networking drivers" suits better,
>> according previous title it is for driver testing.
> 
> Yes it is for drivers features.
> I want to distinguish testpmd and other tools like test-flow-perf
> which is also testing networking drivers.
> 
> Maybe "Networking drivers features testing tool" ?
> 

ack


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 16:04       ` Ferruh Yigit
@ 2021-11-25 16:31         ` Ferruh Yigit
  2021-11-25 16:56           ` Thomas Monjalon
  0 siblings, 1 reply; 15+ messages in thread
From: Ferruh Yigit @ 2021-11-25 16:31 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Aman Singh, andrew.rybchenko

On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
>> 25/11/2021 14:40, Ferruh Yigit:
>>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>>> -Driver testing tool
>>>> +Networking features testing tool
>>>
>>> "Networking features" scope is a little wide.
>>> Not sure if "Networking features" or "Networking drivers" suits better,
>>> according previous title it is for driver testing.
>>
>> Yes it is for drivers features.
>> I want to distinguish testpmd and other tools like test-flow-perf
>> which is also testing networking drivers.
>>
>> Maybe "Networking drivers features testing tool" ?
>>
> 
> ack
> 

thinking twice what additional meaning does 'features' adds here,
"Networking drivers features testing"
vs
"Networking drivers testing"

Isn't "Networking drivers testing" implies features of drivers?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2021-11-25 16:31         ` Ferruh Yigit
@ 2021-11-25 16:56           ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2021-11-25 16:56 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Aman Singh, andrew.rybchenko

25/11/2021 17:31, Ferruh Yigit:
> On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> > On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> >> 25/11/2021 14:40, Ferruh Yigit:
> >>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> >>>> -Driver testing tool
> >>>> +Networking features testing tool
> >>>
> >>> "Networking features" scope is a little wide.
> >>> Not sure if "Networking features" or "Networking drivers" suits better,
> >>> according previous title it is for driver testing.
> >>
> >> Yes it is for drivers features.
> >> I want to distinguish testpmd and other tools like test-flow-perf
> >> which is also testing networking drivers.
> >>
> >> Maybe "Networking drivers features testing tool" ?
> >>
> > 
> > ack
> > 
> 
> thinking twice what additional meaning does 'features' adds here,
> "Networking drivers features testing"
> vs
> "Networking drivers testing"
> 
> Isn't "Networking drivers testing" implies features of drivers?

Yes
I was trying to avoid being too generic,
because the same title could apply to flow-perf.
But not mentioning "performance" should be enough.

OK for "Networking drivers testing tool"



^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v3] maintainers: update for testpmd
  2021-10-22  7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
  2021-10-22  8:57 ` Ferruh Yigit
  2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
@ 2021-11-26 10:04 ` Thomas Monjalon
  2021-11-26 11:14   ` Thomas Monjalon
  2 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2021-11-26 10:04 UTC (permalink / raw)
  To: dev; +Cc: Aman Singh, Ferruh Yigit

From: Aman Singh <aman.deep.singh@intel.com>

Add Aman Singh as co-maintainer of testpmd.

Make the title description more accurate for this tool.

Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: update the section title
v3: update the section title
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d785363c5c..6e520ca560 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com>
 F: app/test/sample_packet_forward.c
 F: app/test/sample_packet_forward.h
 
-Driver testing tool
+Networking drivers testing tool
 M: Xiaoyun Li <xiaoyun.li@intel.com>
+M: Aman Singh <aman.deep.singh@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/
-- 
2.33.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v3] maintainers: update for testpmd
  2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
@ 2021-11-26 11:14   ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2021-11-26 11:14 UTC (permalink / raw)
  To: Aman Singh; +Cc: dev, Ferruh Yigit

26/11/2021 11:04, Thomas Monjalon:
> From: Aman Singh <aman.deep.singh@intel.com>
> 
> Add Aman Singh as co-maintainer of testpmd.
> 
> Make the title description more accurate for this tool.
> 
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Applied

Thanks Aman for volunteering.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2022-02-10 15:03 ` [PATCH v2] " Yuying Zhang
@ 2022-03-08 22:48   ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2022-03-08 22:48 UTC (permalink / raw)
  To: Yuying Zhang; +Cc: dev, xiaoyun.li, ferruh.yigit, konstantin.ananyev

10/02/2022 16:03, Yuying Zhang:
> Move 'test-pmd/bpf_cmd.*' files under BPF component.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Assuming Konstantin is OK.

Applied, thanks.




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2] maintainers: update for testpmd
  2022-02-09 15:01 [PATCH v1] " Yuying Zhang
@ 2022-02-10 17:11 ` Yuying Zhang
  2022-02-10 10:09   ` Ferruh Yigit
  0 siblings, 1 reply; 15+ messages in thread
From: Yuying Zhang @ 2022-02-10 17:11 UTC (permalink / raw)
  To: dev, xiaoyun.li, ferruh.yigit, cristian.dumitrescu, thomas; +Cc: Yuying Zhang

Move 'test-pmd/cmdline_tm.*' files under
"Traffic Management API" component.
Move 'test-pmd/cmdline_mtr.*' files under
"Traffic Metering and Policing API" component.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..49fafd8be2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -406,11 +406,13 @@ F: lib/ethdev/rte_flow*
 Traffic Management API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
+F: app/test-pmd/cmdline_tm.*
 F: lib/ethdev/rte_tm*
 
 Traffic Metering and Policing API - EXPERIMENTAL
 M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
 T: git://dpdk.org/next/dpdk-next-net
+F: app/test-pmd/cmdline_mtr.*
 F: lib/ethdev/rte_mtr*
 
 Baseband API
-- 
2.25.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2] maintainers: update for testpmd
  2022-02-09 17:28 [PATCH v1] " Yuying Zhang
@ 2022-02-10 15:03 ` Yuying Zhang
  2022-03-08 22:48   ` Thomas Monjalon
  0 siblings, 1 reply; 15+ messages in thread
From: Yuying Zhang @ 2022-02-10 15:03 UTC (permalink / raw)
  To: dev, xiaoyun.li, ferruh.yigit, thomas, konstantin.ananyev; +Cc: Yuying Zhang

Move 'test-pmd/bpf_cmd.*' files under BPF component.

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c65b753c6b..bdbf2f9e7f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1616,6 +1616,7 @@ F: lib/bpf/
 F: examples/bpf/
 F: app/test/test_bpf.c
 F: doc/guides/prog_guide/bpf_lib.rst
+F: app/test-pmd/bpf_cmd.*
 
 Graph - EXPERIMENTAL
 M: Jerin Jacob <jerinj@marvell.com>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] maintainers: update for testpmd
  2022-02-10 17:11 ` [PATCH v2] " Yuying Zhang
@ 2022-02-10 10:09   ` Ferruh Yigit
  0 siblings, 0 replies; 15+ messages in thread
From: Ferruh Yigit @ 2022-02-10 10:09 UTC (permalink / raw)
  To: Yuying Zhang, dev, xiaoyun.li, cristian.dumitrescu, thomas

On 2/10/2022 5:11 PM, Yuying Zhang wrote:
> Move 'test-pmd/cmdline_tm.*' files under
> "Traffic Management API" component.
> Move 'test-pmd/cmdline_mtr.*' files under
> "Traffic Metering and Policing API" component.
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c65b753c6b..49fafd8be2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -406,11 +406,13 @@ F: lib/ethdev/rte_flow*
>   Traffic Management API - EXPERIMENTAL
>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_tm.*

Thanks Yuying,

Can you please move the testpm files under the lib files?
For both components.

>   F: lib/ethdev/rte_tm*
>   
>   Traffic Metering and Policing API - EXPERIMENTAL
>   M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>   T: git://dpdk.org/next/dpdk-next-net
> +F: app/test-pmd/cmdline_mtr.*
>   F: lib/ethdev/rte_mtr*
>   
>   Baseband API


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-03-08 22:48 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22  7:19 [dpdk-dev] [PATCH] maintainers: update for driver testing tool Aman Singh
2021-10-22  8:57 ` Ferruh Yigit
2021-11-25 10:00   ` Thomas Monjalon
2021-11-25 10:01 ` [PATCH v2] maintainers: update for testpmd Thomas Monjalon
2021-11-25 13:40   ` Ferruh Yigit
2021-11-25 15:20     ` Thomas Monjalon
2021-11-25 16:04       ` Ferruh Yigit
2021-11-25 16:31         ` Ferruh Yigit
2021-11-25 16:56           ` Thomas Monjalon
2021-11-26 10:04 ` [PATCH v3] " Thomas Monjalon
2021-11-26 11:14   ` Thomas Monjalon
2022-02-09 15:01 [PATCH v1] " Yuying Zhang
2022-02-10 17:11 ` [PATCH v2] " Yuying Zhang
2022-02-10 10:09   ` Ferruh Yigit
2022-02-09 17:28 [PATCH v1] " Yuying Zhang
2022-02-10 15:03 ` [PATCH v2] " Yuying Zhang
2022-03-08 22:48   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git