DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1] gpudev: remove unnecessary rte_gpu_wmb
@ 2021-11-25 22:40 eagostini
  2021-11-26 11:29 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: eagostini @ 2021-11-25 22:40 UTC (permalink / raw)
  To: dev; +Cc: Elena Agostini

From: Elena Agostini <eagostini@nvidia.com>

Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts.
It causes a performance degradation in case of NVIDIA GPU V100.

This change doesn't affect any functionality as the status resides
in CPU registered memory.

Fixes: c7ebd65c1372 ("gpudev: add communication list")

Signed-off-by: Elena Agostini <eagostini@nvidia.com>
---
 lib/gpudev/gpudev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c
index 1d8200e71b..9ae36dbae9 100644
--- a/lib/gpudev/gpudev.c
+++ b/lib/gpudev/gpudev.c
@@ -877,7 +877,6 @@ rte_gpu_comm_populate_list_pkts(struct rte_gpu_comm_list *comm_list_item,
 	RTE_GPU_VOLATILE(comm_list_item->num_pkts) = num_mbufs;
 	rte_gpu_wmb(comm_list_item->dev_id);
 	RTE_GPU_VOLATILE(comm_list_item->status) = RTE_GPU_COMM_LIST_READY;
-	rte_gpu_wmb(comm_list_item->dev_id);
 
 	return 0;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] gpudev: remove unnecessary rte_gpu_wmb
  2021-11-25 22:40 [PATCH v1] gpudev: remove unnecessary rte_gpu_wmb eagostini
@ 2021-11-26 11:29 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-11-26 11:29 UTC (permalink / raw)
  To: Elena Agostini; +Cc: dev

25/11/2021 23:40, eagostini@nvidia.com:
> From: Elena Agostini <eagostini@nvidia.com>
> 
> Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts.
> It causes a performance degradation in case of NVIDIA GPU V100.
> 
> This change doesn't affect any functionality as the status resides
> in CPU registered memory.
> 
> Fixes: c7ebd65c1372 ("gpudev: add communication list")
> 
> Signed-off-by: Elena Agostini <eagostini@nvidia.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-26 11:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 22:40 [PATCH v1] gpudev: remove unnecessary rte_gpu_wmb eagostini
2021-11-26 11:29 ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git