From: Ramkumar Balu <rbalu@marvell.com> To: Akhil Goyal <gakhil@marvell.com>, Anoob Joseph <anoobj@marvell.com>, Declan Doherty <declan.doherty@intel.com>, Fan Zhang <roy.fan.zhang@intel.com>, Ankur Dwivedi <adwivedi@marvell.com>, "Tejasree Kondoj" <ktejasree@marvell.com> Cc: <stable@dpdk.org>, <dev@dpdk.org>, Ramkumar <rbalu@marvell.com> Subject: [PATCH 1/5] cryptodev: fix RSA op cipher field description Date: Mon, 29 Nov 2021 09:51:55 +0000 Message-ID: <20211129095159.16376-2-rbalu@marvell.com> (raw) In-Reply-To: <20211129095159.16376-1-rbalu@marvell.com> From: Ramkumar <rbalu@marvell.com> The description for 'struct rte_crypto_rsa_op_param' failed to specify a field for returning the plaintext from RSA public key decryption. This patch fixes the rte_crypto_rsa_op_param description to specify 'cipher' field to be used for returning plaintext during RSA op_type == RTE_CRYPTO_ASYM_OP_VERIFY. Fixes: 501ed9c6611f ("cryptodev: add cipher field to RSA op") Cc: stable@dpdk.org Signed-off-by: Ramkumar <rbalu@marvell.com> --- lib/cryptodev/rte_crypto_asym.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 9c866f553f..b99cf6843c 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -461,11 +461,12 @@ struct rte_crypto_rsa_op_param { * - to be decrypted for RSA private decrypt. * * Pointer to output data - * - for RSA public encrypt. + * - for RSA public encrypt/decrypt. * In this case the underlying array should have been allocated - * with enough memory to hold ciphertext output (i.e. must be + * with enough memory to hold ciphertext/plaintext output (i.e. must be * at least RSA key size). The cipher.length field should - * be 0 and will be overwritten by the PMD with the encrypted length. + * be 0 and will be overwritten by the PMD with the encrypted/decrypted + * length. * * All data is in Octet-string network byte order format. */ -- 2.17.1
next prev parent reply other threads:[~2021-11-29 10:41 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-29 9:51 [PATCH 0/5] cryptodev: fix inconsistency in RSA op usage Ramkumar Balu 2021-11-29 9:51 ` Ramkumar Balu [this message] 2021-11-29 9:51 ` [PATCH 2/5] crypto/openssl: fix output of RSA verify op Ramkumar Balu 2021-12-28 9:10 ` Kusztal, ArkadiuszX 2022-01-13 10:34 ` Ramkumar Balu 2021-11-29 9:51 ` [PATCH 3/5] crypto/octeontx: fix output field for RSA verify Ramkumar Balu 2021-11-29 9:51 ` [PATCH 4/5] crypto/octeontx2: " Ramkumar Balu 2021-11-29 9:51 ` [PATCH 5/5] crypto/cnxk: " Ramkumar Balu 2021-12-28 8:58 ` [PATCH 0/5] cryptodev: fix inconsistency in RSA op usage Kusztal, ArkadiuszX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211129095159.16376-2-rbalu@marvell.com \ --to=rbalu@marvell.com \ --cc=adwivedi@marvell.com \ --cc=anoobj@marvell.com \ --cc=declan.doherty@intel.com \ --cc=dev@dpdk.org \ --cc=gakhil@marvell.com \ --cc=ktejasree@marvell.com \ --cc=roy.fan.zhang@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git