From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E0D88A0C55;
	Wed,  1 Dec 2021 01:31:58 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C795F4068C;
	Wed,  1 Dec 2021 01:31:58 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 0E6CA4067B
 for <dev@dpdk.org>; Wed,  1 Dec 2021 01:31:58 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1061)
 id 664D220E0BFA; Tue, 30 Nov 2021 16:31:57 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 664D220E0BFA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1638318717;
 bh=PXr4+qGD5cqXUwDxIJ+AyZzvUqWBKUaB5HTmEvctD4o=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=DEmRiI86M8HdXPi1rbAPiLIzUvbTe4q8cIbStvdn+iCYb0uLN5Ajiq5BuZ94wi6Nq
 hrXebytSHQ6UUYDImn9dCQppMsq83Kl7OQKligwJuGmYCQ+NiXjUOkLAIda6dvv5Ti
 4Z/u5f97FoLlLYKvK5t5SKEPkQtXXgf00sU9hSZw=
Date: Tue, 30 Nov 2021 16:31:57 -0800
From: Jie Zhou <jizh@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com,
 dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com,
 thomas@monjalon.net, aconole@redhat.com
Subject: Re: [PATCH v8 04/11] app/test: exclude ENOTSUP as failure
Message-ID: <20211201003157.GC14219@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1635215204-20604-1-git-send-email-jizh@linux.microsoft.com>
 <1635216361-23641-1-git-send-email-jizh@linux.microsoft.com>
 <1635216361-23641-5-git-send-email-jizh@linux.microsoft.com>
 <20211124010210.7fcb23b2@sovereign>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211124010210.7fcb23b2@sovereign>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Nov 24, 2021 at 01:02:10AM +0300, Dmitry Kozlyuk wrote:
> 2021-10-25 19:45 (UTC-0700), Jie Zhou:
> > Check rte_errno to exclude ENOTSUP as failures in test_memory.c
> > 
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > ---
> >  app/test/test_memory.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/app/test/test_memory.c b/app/test/test_memory.c
> > index dbf6871e71..379b0f99ca 100644
> > --- a/app/test/test_memory.c
> > +++ b/app/test/test_memory.c
> > @@ -10,6 +10,7 @@
> >  #include <rte_memory.h>
> >  #include <rte_common.h>
> >  #include <rte_memzone.h>
> > +#include <rte_errno.h>
> >  
> >  #include "test.h"
> >  
> > @@ -63,7 +64,7 @@ check_seg_fds(const struct rte_memseg_list *msl, const struct rte_memseg *ms,
> >  	/* we're able to get memseg fd - try getting its offset */
> >  	ret = rte_memseg_get_fd_offset_thread_unsafe(ms, &offset);
> >  	if (ret < 0) {
> > -		if (errno == ENOTSUP)
> > +		if (rte_errno == ENOTSUP)
> >  			return 1;
> >  		return -1;
> >  	}
> 
> The commit title and message contradict what is inside.
> ENOTSUP was excluded previously, but errno was checked instead of rte_errno.
> It should be stated what was wrong and how it is fixed (with a Fixes tag).

Will add the Fixes info and revise the title and message.