From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D26DEA0C55; Wed, 1 Dec 2021 02:05:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F4494068C; Wed, 1 Dec 2021 02:05:40 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 766884067B for ; Wed, 1 Dec 2021 02:05:39 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1061) id C02FC20DEEC4; Tue, 30 Nov 2021 17:05:38 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C02FC20DEEC4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1638320738; bh=Aj3Zn+4hKtRnsilM9HWjnft4ZqDqTKG6BGc9PhGPiq0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gHR5cPr0M+LjaKE3rGnTLs6v5eTSu9RL/kxjGUtRyAxylEDcaVa5g8v4mXaIKPXn6 d917x6lF2rynftqG3pw+RTs9op96b84HRkXiV+PWIy238SGCs4VoriKr7QtS1nsOg8 xXOuOTuipebONVU8m9Kv4/u/amNZnNgBTgRv/F5E= Date: Tue, 30 Nov 2021 17:05:38 -0800 From: Jie Zhou To: Dmitry Kozlyuk Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v8 03/11] app/test: replace POSIX specific code Message-ID: <20211201010538.GA15157@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1635215204-20604-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-1-git-send-email-jizh@linux.microsoft.com> <1635216361-23641-4-git-send-email-jizh@linux.microsoft.com> <20211124010206.6ca9d9cf@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124010206.6ca9d9cf@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 24, 2021 at 01:02:06AM +0300, Dmitry Kozlyuk wrote: > 2021-10-25 19:45 (UTC-0700), Jie Zhou: > > - Include rte_os_shim.h > > - Replace sleep and usleep with rte_delay_us_sleep > > - #ifndef RTE_EXEC_ENV_WINDOWS for POSIX code only > > > > Signed-off-by: Jie Zhou > > --- > > This patch can be combined with the previous one: > they serve the same purpose---to remove Unix-specific code. > > Please try to summarize in the commit message > which parts of the tests suites are excluded, e.g. multi-process. > It is more useful then stating what was changed in the code. > Will combine and revise the message. > [...] > > diff --git a/app/test/test_cmdline.c b/app/test/test_cmdline.c > > index 115bee966d..9a76bd299f 100644 > > --- a/app/test/test_cmdline.c > > +++ b/app/test/test_cmdline.c > > @@ -31,6 +31,7 @@ test_cmdline(void) > > return -1; > > if (test_parse_num_invalid_param() < 0) > > return -1; > > +#ifndef RTE_EXEC_ENV_WINDOWS > > printf("Testing parsing IP addresses...\n"); > > if (test_parse_ipaddr_valid() < 0) > > return -1; > > @@ -38,6 +39,7 @@ test_cmdline(void) > > return -1; > > if (test_parse_ipaddr_invalid_param() < 0) > > return -1; > > +#endif > > printf("Testing parsing strings...\n"); > > if (test_parse_string_valid() < 0) > > return -1; > > What's wrong with parsing IP addresses on Windows? > test_cmdline_ipaddr.c uses linux netinet/in.h specific u6_addr. Skip these 3 cases for now and prefer a separate patch to make it work on Windows. Or maybe there is already DPDK support on this which I am not aware of? Thanks. > [...] > > diff --git a/app/test/test_mp_secondary.c b/app/test/test_mp_secondary.c > > index 5b6f05dbb1..da035348bd 100644 > > --- a/app/test/test_mp_secondary.c > > +++ b/app/test/test_mp_secondary.c > > @@ -14,7 +14,9 @@ > > #include > > #include > > #include > > +#ifndef RTE_EXEC_ENV_WINDOWS > > #include > > +#endif > > #include > > #include > > #include > > is absent on Windows for sure, but you don't exclude it. > Does this file even need modification? > It's not going to be compiled for Windows. > This is replaced with the test stub in the patch#11 (of V8) to make it compile on Windows. Sorry for the confusion. Will make sure remove this unnecessary part from V9. > [...] > > diff --git a/app/test/test_ring_stress.c b/app/test/test_ring_stress.c > > index 1af45e0fc8..ce3535c6b2 100644 > > --- a/app/test/test_ring_stress.c > > +++ b/app/test/test_ring_stress.c > > @@ -43,9 +43,10 @@ test_ring_stress(void) > > n += test_ring_rts_stress.nb_case; > > k += run_test(&test_ring_rts_stress); > > > > +#ifndef RTE_EXEC_ENV_WINDOWS > > n += test_ring_hts_stress.nb_case; > > k += run_test(&test_ring_hts_stress); > > - > > +#endif > > Can you please elaborate what is the issue with this case? > It is also one of the details you usually want to put > into the commit message. Cannot remember what caused this case being skipped in the first place, but it can work now. So removed the ifndef. Thanks.