From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C238A0C41; Wed, 1 Dec 2021 19:45:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BC34426E5; Wed, 1 Dec 2021 19:45:41 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id A9A9A426E2 for ; Wed, 1 Dec 2021 19:45:39 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id y8so18421015plg.1 for ; Wed, 01 Dec 2021 10:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Spcz9F2tiNQtOuQEqWw/mw2lmgayU+WVdwRCHZXZIrk=; b=b+vfV/iVdIlJdOzV2N6u+WxPLuWP5EoGG5frFWMFr40QXp1V5KWhnmQeAdrk5zrnoY UTt1Jwm+Dv4odC4LRzu2F66UivJX/R8XmTV/zvn87eAy+WEkQvo+RNIwBNQh4chs7pNn 3NgaamcgSCuaRNO81rSoMe4VwfFBHPDQSbjmr1UQHUKEclGn87bujZlDSSjC746GqnCE mJk5Aw0jNw44A0QGJFtgqnCeqP0T5nNn25Fm2HCS0pOrbgR+QQZhPvapI5drX3Pf1chP oqElEY/LRCi2bY7x5+Y5dAtLtJHO4WtgwFU5TOR9A1/OSORwuU3x+E8IA+f3XHNmrvxl qvEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Spcz9F2tiNQtOuQEqWw/mw2lmgayU+WVdwRCHZXZIrk=; b=H7GxRMBhr8aODzF+ptR2pA3Tpa8opFr8Ls9YdEewqWzEtWm5OQ2gson6lwPHyiPjTw CFuy5Jbkil3/ALVlQvIfNL/I6wU+2Z0cCOlzdo/Q05ibZf+pfa+WSu9sf2jCvsWjiVeG f/7RLnWwOh0VuOMWJ17AwgTN15EppJzD4qPQGWYhajBUwaIZt7mVVrgWTF83cjcu/Yjm k2ztR/kWGVTlE9LItf8+2Cp5VBbWeWl6nD45vg5g6zpL2b0bn7mFdw6PYTC0vLEteDoi S5hhcy750MbGu1cW5FoqgVmayJIp3eFqgLTDze/Jg9PcQVk2PjiN5iFOHh7c2ctRtvW+ YW4w== X-Gm-Message-State: AOAM530+ml6X1H2q6d9oeCuV7Gk/KvlD5tj+SfFcxFjsykjPe8ckFV9G wjDTEf3Uu2GgMNXEhN5zjrmj0g== X-Google-Smtp-Source: ABdhPJzNgls6MG5rPw2ZAXCnwDObzsga+lcK5XzF/jpLmr8bKIr+/N/5q3jhBCln544SsSH3dZ4SxQ== X-Received: by 2002:a17:902:e302:b0:141:ba08:2e44 with SMTP id q2-20020a170902e30200b00141ba082e44mr9361011plc.81.1638384338874; Wed, 01 Dec 2021 10:45:38 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id w19sm58762pjh.10.2021.12.01.10.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 10:45:38 -0800 (PST) Date: Wed, 1 Dec 2021 10:45:35 -0800 From: Stephen Hemminger To: Jie Zhou Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v9 9/9] app/test: enable subset of unit tests on Windows Message-ID: <20211201104535.207b57c6@hermes.local> In-Reply-To: <1638381938-6113-10-git-send-email-jizh@linux.microsoft.com> References: <1635216361-23641-1-git-send-email-jizh@linux.microsoft.com> <1638381938-6113-1-git-send-email-jizh@linux.microsoft.com> <1638381938-6113-10-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 1 Dec 2021 10:05:38 -0800 Jie Zhou wrote: > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c > index b206db27ae..c2ea9090cf 100644 > --- a/app/test/test_dmadev.c > +++ b/app/test/test_dmadev.c > @@ -2,6 +2,17 @@ > * Copyright(c) 2021 HiSilicon Limited > * Copyright(c) 2021 Intel Corporation > */ > +#include "test.h" > + > +#ifdef RTE_EXEC_ENV_WINDOWS > +static int > +test_dma(void) > +{ > + printf("dma not supported on Windows, skipping test\n"); > + return TEST_SKIPPED; > +} > + > +#else Rather than littering code with ifdefs is it not possible to just not build these tests on Windows?