From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66DADA0C41; Fri, 3 Dec 2021 17:28:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FE834014F; Fri, 3 Dec 2021 17:28:57 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 15F7740041 for ; Fri, 3 Dec 2021 17:28:54 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id gx15-20020a17090b124f00b001a695f3734aso2984743pjb.0 for ; Fri, 03 Dec 2021 08:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1+KUGReguL9MuwpmAA60w/aEFkzClWPD+FWPbDXkFME=; b=Vw6BvTjwd0h9Vlptqun5Q7lWgnJbdV4mMHIfG2cKwexqA9i0/W3/gIB9NHs3g51bZp jaDfXc/Yur4gFNl0TeeWrec0IIvYEXgsD82FiPGPT4N92efm29lUDbY+UP4lpNj0h7sW DjOWtlIgwud+mn0yH6L/7FghUog5lurxg0WL9Sg+hZ6/SHr3SnVbCrkoVCmnnA0sJlA9 6mZTkkpstiLi1bJc8TYNbLTRF8qrHlDFMEwPcmIcO1wQVB+L7nvfHOc2E3IimHnBcuqa 4/41/bVSZc3jqR7v73DSTPo6UcQ0CYq8sjLvFiOv8UdDM1r95YyPpqDXVrPZ59Tv3MaD fyMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1+KUGReguL9MuwpmAA60w/aEFkzClWPD+FWPbDXkFME=; b=E6o6Z20sRD2F/e7E1CSebZaITzE3VGC5u+6LJF7ATmQ88PM9Mnjl3kjo4QGWaNjQg1 Da6Im3AxNvBX2WdH2vNc9jGD73zTb3q9tI2aNRTMKANWh9waydN5y2QUvFbZOQBvZVlm qD5Gl6rV+QLcFLPr2HM5XbgmTad3WhrgBgGOZAjdL8An5WKHNHLGYPwOxYSlUZwjiilc S0kdSUiRNQN5s+pw0pjCkRjWA0W6hmdU1kYgiuwtZr6FT9w7y3qjYxEs/+Kg0cIPqkzO D0MOwC+iNn++O9A3qWtQfktE7XDfHoGUfAj/yiP0JSGO7V7rHyjZagaZh1roFVUOnvwM 9elA== X-Gm-Message-State: AOAM532CAaKG9jN+/yHwMUTXnvdkLD2kd+Qie5yFJ9UvtPcWTIBwhT82 ASDLer30oUE89tW2SVibvBQncg== X-Google-Smtp-Source: ABdhPJzo4lx9SepL+F9if44cpuNP7ik1o0+S0KdpAkYyhE6vVvx4mJgAT8uGip/ulPJTNeY1gaMXtQ== X-Received: by 2002:a17:90b:3a89:: with SMTP id om9mr15316097pjb.29.1638548933965; Fri, 03 Dec 2021 08:28:53 -0800 (PST) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id z7sm3753666pfe.77.2021.12.03.08.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 08:28:53 -0800 (PST) Date: Fri, 3 Dec 2021 08:28:50 -0800 From: Stephen Hemminger To: Markus Theil Cc: ferruh.yigit@intel.com, dev@dpdk.org, markus.theil@secunet.com, Michael Pfeiffer Subject: Re: [PATCH v3] kni: fix ioctl signature Message-ID: <20211203082850.245dab59@hermes.local> In-Reply-To: <20211203071907.58032-1-markus.theil@tu-ilmenau.de> References: <20211128150531.0a9dc798@hermes.local> <20211203071907.58032-1-markus.theil@tu-ilmenau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 3 Dec 2021 08:19:07 +0100 Markus Theil wrote: > From: Markus Theil > > Fix kni's ioctl signature to correctly match the kernel's > structs. This shaves off the (void*) casts and uses struct file* > instead of struct inode*. With the correct signature, control flow > integrity checkers are no longer confused at this point. > > Signed-off-by: Markus Theil > Tested-by: Michael Pfeiffer > --- Thanks for fixing. Acked-by: Stephen Hemminger