From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A81D5A0C41; Sat, 4 Dec 2021 02:05:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47F414013F; Sat, 4 Dec 2021 02:05:56 +0100 (CET) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 7E58840041 for ; Sat, 4 Dec 2021 02:05:54 +0100 (CET) Received: by mail-lf1-f48.google.com with SMTP id bi37so10527082lfb.5 for ; Fri, 03 Dec 2021 17:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KCo3so9JUzJtFnXdnxsZ3bti7G8b0eeY6IWC5NEhLSE=; b=Ymq273zlYAvvViTl8BOCrxmC2VGnzmuZ767432qAwaJPlKPqf+giGRFUefP70eOko0 rj1BrrPrC4QiLOd38xjhOXFnJ2bHhbJqUTk4nmHCHAKgySntLXndzIVI/PigU7wOYSG+ uWjGCuGZI8MuryAHOWw+eNcq2yJ+xN1g11f91PeYL604FPIUuku/Mz20e0mya5VQkpnb aKFGGj51fd1+ND/8EGHsf00Arz0zMbKj1WZuF+CA7f1hxwDWMCkvChHeMwVu8mDKcZxG 9a/fB+vaVVXu6bTMroK8d6fBcFa3nruN/jSXu0bPUZxg+YTGC421iN7T5U5LL9OOgOos pu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KCo3so9JUzJtFnXdnxsZ3bti7G8b0eeY6IWC5NEhLSE=; b=tuazk76Obb6Oig+ktZ8e3g13t+5CMVR7qs7LeMbUW5BVFzkO96QXBK1mcI4iPtqhFV Cj5V1che9DvueL3ihJefD8KWxmZVldj6S2lZ5FRd+N603ZYqVYa1k1djctBLNXoK3O1c PpnUCbP55C47LRJg/Xf3yMDPO6yPl/6jmqfmenf1qa+CRwPa3c4aCNjaDxhEkYuSEeOD tIh38LFEv402T0MkLL+n1EKj+eOLuUV66GjGl9KcpGS0xzg8++IEaMck/4JFh7jhOO1k fCwVp6zSRlKwIKOj8qWhZCOSEmbMliSNgw4jg+vThz2wDzIWKPzj7u5aZDC38gm9Y9Xp Orkw== X-Gm-Message-State: AOAM532WpWns71nGxgFbIxxfrfZjBT/ebJVbr1nY5++lfmk49gtBmR++ NgZI9zn75DJ+54hPT94USQE= X-Google-Smtp-Source: ABdhPJzk5h0TC091pZzQuHhh6QyIA7tzqSpg3EwKJ1svnUkak9xQE5VCUF2z0BgjD106+jnPfkPw5w== X-Received: by 2002:a05:6512:138f:: with SMTP id p15mr20526004lfa.648.1638579953922; Fri, 03 Dec 2021 17:05:53 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id f9sm612879lfu.10.2021.12.03.17.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 17:05:53 -0800 (PST) Date: Sat, 4 Dec 2021 04:05:52 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v10 2/9] app/test: remove POSIX-specific code Message-ID: <20211204040552.66e1e7c3@sovereign> In-Reply-To: <1638384245-12587-3-git-send-email-jizh@linux.microsoft.com> References: <1638381938-6113-1-git-send-email-jizh@linux.microsoft.com> <1638384245-12587-1-git-send-email-jizh@linux.microsoft.com> <1638384245-12587-3-git-send-email-jizh@linux.microsoft.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2021-12-01 10:43 (UTC-0800), Jie Zhou: > - Remove header inclusion of netinet/in.h and terminos.h Typo: "termios.h". > - Include rte_os_shim.h > - Replace sleep and usleep with rte_delay_us_sleep Instead of all the above I'd say: "Replace POSIX-specific code with DPDK equivalents or conditionally disable it on Windows." > - Use NUL on Windows as /dev/null for Linux "Linux" -> "Unix" > - Exclude tests not supported on Windows yet, e.g. multi-process, and > IP address parsing (the test cases use linux netinet/in.h u6_addr > and better have a sperate patch to add such tests on Windows) Instead of "e.g." a complete list of missing tests is preferable: * multi-process * PMD performance statistics display on signal * command-line IP address parsing TBH, I don't understand the issue with test_cmdline_ipaddr--- it could be fixed with just a few lines: #define IP4(a,b,c,d) {.s_addr = ... } #ifdef RTE_EXEC_ENV_WINDOWS #define s6_addr16 u.Word #else #define s6_addr16 __u6_addr.__u6_addr16 #endif Why it should be a separate patch?