From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 779DEA034F; Mon, 6 Dec 2021 23:19:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13E17410E5; Mon, 6 Dec 2021 23:19:49 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70132.outbound.protection.outlook.com [40.107.7.132]) by mails.dpdk.org (Postfix) with ESMTP id 4525040040 for ; Mon, 6 Dec 2021 23:19:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lkoJoDWffIz5/bRI8wMOmxBGidtBOh7rqZmDo1arwhXdtDHhH3T0JoX6NoWWQB8A4k0ELExoUCOSuomfB2WTNNvlkrjx9MY2OCAvPxD2XUKD3+MYOMTIEkVCq824NOWOUHX1YNUcPmmCfIA0ATgTNcNq5KIFhvIliHHiQ0qFtL8epPWJtp49BcgdymZNWowPnH44/7Z/iqQcf41Ip241kwinxF7YbbwPze00qdjntkj9YGA9ZmCYGPbwFPO0U/fKaHF3TOLNYbIrlyzVN+tjiardJzA6PCFO84OYW7uI9DBd37hAzjE00WIAeQxWlt7+aKCPYfT6PmSotFpIKssGbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R+P6ruW5mJnDGIWt/FutgcxgBnkpMpeYroPTnqqE1vk=; b=lIaL2V2vdE6ZkA6kBVdZIFmFSggZCIEiJMIU1x3JTBGgeavbSA0/VKMw4bi81zBwn0r4a6VumXvJwrHAJTj0T1zHmvToW954KSjLbpodYXBTkgyIzdEnEf+7DfqvzfpS2xfi4VXrp7uwH8ZPJSqPSKQgKoTWCNn+zSrvbuQg0YGsHsPH18voOOBa/wVxlXpvPGkeh4FVzibUB+h4Y1F9Dkem974WwoKRXHVThM6P4+m1buC8H1QEO71zZxWQEkD4/92ZEPRF2Nd5WmLCVsBl6nn2mJ0smgNoEhM1ql89paxx5iF0Eb9PAr84/WZ7MqRHXrR2saHge9Pivb5fPx+bLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+P6ruW5mJnDGIWt/FutgcxgBnkpMpeYroPTnqqE1vk=; b=aiBWrGEdstpAs3+0Mdqb0wXnbONLO2Atmp7P1t5dibromNQEUxCmIB3icqMefHwcK6C9wCChnIMbRnhV1PU7n5/YNiCCfNbzl3/VlqxyR3u/forNAVCbJXPwxxH9Aj+ialP1beTyo7GIG7pb/R7mQcRipWOAT1AXzid0HHQqHCM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; Received: from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29) by AM0PR04MB6724.eurprd04.prod.outlook.com (2603:10a6:208:17a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Mon, 6 Dec 2021 22:19:46 +0000 Received: from AM0PR04MB4083.eurprd04.prod.outlook.com ([fe80::f4db:d40d:a746:7bfc]) by AM0PR04MB4083.eurprd04.prod.outlook.com ([fe80::f4db:d40d:a746:7bfc%7]) with mapi id 15.20.4755.022; Mon, 6 Dec 2021 22:19:46 +0000 From: Stephen Douthit To: Cc: dev@dpdk.org, wenw@silicom-usa.com, Stephen Douthit Subject: [PATCH v2 0/7] ixgbe SFP handling fixes Date: Mon, 6 Dec 2021 17:19:14 -0500 Message-Id: <20211206221922.644187-1-stephend@silicom-usa.com> X-Mailer: git-send-email 2.31.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MN2PR20CA0031.namprd20.prod.outlook.com (2603:10b6:208:e8::44) To AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29) MIME-Version: 1.0 Received: from lappy.adi.eng (173.14.114.227) by MN2PR20CA0031.namprd20.prod.outlook.com (2603:10b6:208:e8::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19 via Frontend Transport; Mon, 6 Dec 2021 22:19:46 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12a2f842-3a29-44f5-114f-08d9b90682cf X-MS-TrafficTypeDiagnostic: AM0PR04MB6724:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZLDIZ4WwImxiwpoCU4hll4GrW1+RauQVJ34QDNEF/+ONjwsRFanUQv6m4vn7jSJgE+Ja2zuOHZeAdO8xQBfnYZndLwXErIEg3nT1a+S1c8nVxO6oKL0gu4nDSEVZQ+yhQS6b9ouIWq+C7pR5DbSXSwiUAAM8pIBe29+DEwX0+w1ne6Jei1VcdapZe1wedHYFGEuC22AHBAvaYEVGDDQ9sCJXfOpixSZ5CNOVaNGtz2M++uTCj6pOjJiwgQ0INsdodH/t6zJiIKnqxOZBE5ziNh+VzMGwF4r09Lqu2VSRwPfQrN4sd5u9QM21xJItPMrSjzB+MwfMWEnYQ6l7oUT+VB6l0iyXNWueybfNic8eE3EE1gkJPUXCHlmTrLIGdWTNyiFA6+HIZY3l046xx4zubKeAFqtsG25yVHmtfvvnBJTk2zSG1RHz5SAds6eQissyLCiy2rSjpXXKlTK5TvQphnQgUDDsVAmM5TptYpc9y07KPtDOvOUotJz3HBb4JSiqEKt9aWtVPh2suQWqfUtYRCbyh2y91H+l/K3rAIKyuZyjq+EgfE4e3GEJ3Rti48oPLpzV+QtOTZmL5WD5n8PtYCqSIBOvuO3/Kd9s/NLWMzWrXMy48X5MVxLZaIraR2r2KW4sHsVNBlotCsQTLFoUaB2NXcLGAhbd+3O4MIYF0DflgIYRHBCUjxYATXfXMR+Y54uS0ioHYed46A6jQEwAwEoBmI6QY19N//LI7Nu+ll8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(5660300002)(2906002)(83380400001)(508600001)(38100700002)(38350700002)(956004)(107886003)(109986005)(6512007)(6486002)(316002)(36756003)(8936002)(26005)(1076003)(52116002)(2616005)(186003)(66476007)(6666004)(6506007)(66556008)(66946007)(8676002)(86362001)(266003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P5mBEe+x7x9f6GmGGLO1qoAL/eB2zM2/HpB+QUkU4vxmC25G72xD1C/tu22S?= =?us-ascii?Q?4RMKAIycJYQ2+N9KplwnrTSGKKMfU6axElIACboOtSVS56K5edCRwXf4JCAj?= =?us-ascii?Q?8qe1u2LmJ1vL8I0b/2cgmCjwuj6EQCiOzlUR6mi5q/2+ziifBhqhoyJWFXKX?= =?us-ascii?Q?uZAGYzaBOHXv5ob2/LzR5gusoBDcv+1PlWcGeW/nG3jyz/i/YhKMElEd9Gwf?= =?us-ascii?Q?2YCQ7aaifeCjVuKSdvNxzQwwyFG6m5FIgz+nvKMnCqTCYmB4+hZ/E08gp+J2?= =?us-ascii?Q?ZMue+k2RpasDx0NRhNCrR0C4fI/ss7rgtlxEXB4Zg4ajJLnFQ/tjAbT9mekq?= =?us-ascii?Q?AYYQViNeYGBF5bZ4IIJKwiIxYS41wi5KBUVyrmdp+x8aIaJJoQA7SbBvvpvU?= =?us-ascii?Q?YewB4EFv7FzCi8meEp8udNv27ev/xNt9l52RTFcAxeMM83cUJyrJBHVr2s8G?= =?us-ascii?Q?Nhdr8O2HAaKGKcSZrmSByNzwmF7OXGrexKMMpZ8uRDIZgfdvJeVxpoOpYxh+?= =?us-ascii?Q?7OpmyT37gmTWiW/tfHbiNYNz6e6QrirFsyWRXF0DJEdEi942jY3lqMCTR6Hv?= =?us-ascii?Q?Hc2APJEXIF2I7ZUi3VFBbn/qmqmCuBiyEpPuI2BaNKXt0qMuPOssgZwidcq4?= =?us-ascii?Q?jdsQR4YQSFBJ3eXJI1AxB7TzKMFjrVWP+UbJ7k37L85Fj96YY76welZci6bF?= =?us-ascii?Q?E+iwcKlLutcYzTeLanr61VAhTklDn7Dxwz9j2dyLrTnGOEQw4tSd8X/uOciE?= =?us-ascii?Q?C5Zh0F83YwVDlehyQOfzmUqiKa8rVwo0DLisG9jqXYo7VR55ofwrkEUdaWDg?= =?us-ascii?Q?a8rSmy7mmRts30EUSL8vwzFMZJBscf6pewfPyTFmh/CmF0mPGmkwJ/oLLoNU?= =?us-ascii?Q?9MIr0GO2Guv82FpRJz+DKw7kSc3+Lx7TOpqPss3aDieC4CnouqKooHst8PRQ?= =?us-ascii?Q?f3jfZAxB442v1re+xcfjCm/00UYyMuCz+8/RKcIo4FUb4fAVJikbYKQhZI0B?= =?us-ascii?Q?c4wmFMamFKAgu53biXFNTJGD0Bff6SD36fvKdWNpe6WczgJzrNo342YA4h0i?= =?us-ascii?Q?MNcqWXEXm2vDFluDY848sESRzVHs0cNCzeLFQOmFb9NPeF6FKjsQMzQSEGQS?= =?us-ascii?Q?iropBp1sFoWJIDzzxK+SWuRGEO4vyh7kNVK1npmsZlC0T/IVVhRiNplFR6Md?= =?us-ascii?Q?WkbDISP8SEJgIiTYKE+V1YaH62xlYCPN9iStsm0XLn3PRNVq86D5g+KbEvRr?= =?us-ascii?Q?eXrIiz0CZr+8dbdJhakPoZhWwfNupbQPO7CkHEVgF/FoXigG8tuesAcBB9dq?= =?us-ascii?Q?rFBQHMLpYa6spl+P78Dxl04AazJdmK9dgddC8I3GAMktjXHms0b4izs/zIzI?= =?us-ascii?Q?j3nBORJ5gSICSs+VXRqvquzS+wpQsxzNu/JLFutCYWMrybGk7asH+Ji/gq3a?= =?us-ascii?Q?9wOWUa5kHzIZiSO7iYWmtpeBoCbQjmMmDkmNEphoki9lc64pWjrtLKBN7Qtn?= =?us-ascii?Q?Rw+EZeAJ1s76zMgPdrEwRxke8Nr4aY4BO9zs1eTWB4R6IvaTZFziXfQTJBwg?= =?us-ascii?Q?+19D3qt9xUC5t2+iK7bm3NYW32w8L6YdQNu0OHcSvMvwATjSDe4Dm3yzJKRv?= =?us-ascii?Q?nUfGE7/5pxpEBoCjuVmRETn+ZEBGRuiHFP917vmrlwhnsp+PfUL7la6+CqhW?= =?us-ascii?Q?a9bKL/gUwuTH5NlZs53+PBRqp+U=3D?= X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12a2f842-3a29-44f5-114f-08d9b90682cf X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4083.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 22:19:46.6885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qHX6c7zORsxhpopOcuYUK9cxgSVgyzYstztygJM8UEKnB+VfTw5xp5OBeUCL/KZnFyx5RjiqaKAVTcxjv9fd6FJMJdq0FGOy5mxBzUstSfc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6724 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org v2: General: * Fix typos reported by checkpatch (my codespell list was old) Patch 5: * Refactor the delay code to use msec_delay(), fixes Windows builds. I had opencoded some delay checks similar to the jiffies/time_after scheme used frequently in the Linux kernel, but that failed to build on Windows without nanosleep(). msec_delay() eventually calls rte_delay_us_sleep(), which doesn't busy wait, which is want we want. And there's a Window's backend for that function, so now this builds with gcc/clang on Windows Server 2019, and gcc on Windows 10 (didn't try clang there) --- Hello all, We have several platforms based on Intel's C3000 series of SoCs that have integrated ixgbe devices (X550EM) operating in the "Native SFI" mode (the 0x15c4 device ID). The first five patches in the series all fix issues relating to the ID and setup of SFPs. Patch 6 allows slow to boot SFPs (like some XGS-PON modules) to work. Patch 7 enables 1G Cu to run with a warning, similar to other unofficially supported modules covered by the allow_unsupported_sfp flag. Currently we use this for g.Fast modules, but other modules that enumerate as 1G Cu may also benefit. Since all of my testing was done on a C3000 platform, and the ixgbe driver now covers a large number of devices, any regression testing that can be done on other ixgbe devices would be greatly appreciated. Thanks, Steve Stephen Douthit (7): net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal net/ixgbe: Check that SFF-8472 soft rate select is supported before write net/ixgbe: Run 82599 link status workaround only on affected devices net/ixgbe: Fix SFP detection and linking on hotplug net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices drivers/net/ixgbe/base/ixgbe_82599.c | 41 +++ drivers/net/ixgbe/base/ixgbe_common.c | 106 ++++++-- drivers/net/ixgbe/base/ixgbe_common.h | 8 + drivers/net/ixgbe/base/ixgbe_phy.c | 39 ++- drivers/net/ixgbe/base/ixgbe_phy.h | 3 + drivers/net/ixgbe/base/ixgbe_type.h | 2 + drivers/net/ixgbe/base/ixgbe_x550.c | 14 +- drivers/net/ixgbe/ixgbe_ethdev.c | 370 ++++++++++++++++---------- drivers/net/ixgbe/ixgbe_ethdev.h | 18 +- 9 files changed, 426 insertions(+), 175 deletions(-) -- 2.31.1