From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97F55A0093; Thu, 9 Dec 2021 20:49:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6247B4014F; Thu, 9 Dec 2021 20:49:03 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E9E6640041 for ; Thu, 9 Dec 2021 20:49:01 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 064BE20B717B; Thu, 9 Dec 2021 11:49:01 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 064BE20B717B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1639079341; bh=CXHhk10Cit2EhxYIyGSi1yYV4nH8IJrTtOGj2zmUNpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NKVyLhr/Z3ytlT53OgreZObtS61Bj/2vjaCNGkItOkrALWnk/IdoXlV73kZI1ViWN Cl3CmvIqHSKjnEKhmUfY1vVd/ILIZvkRLKk15p2H3BmJx39rdgwjwm3dEhY7DlqQoY ho+g2YsV5623ocObb6UNU4zK4xB9bmY6Wgje5XEM= Date: Thu, 9 Dec 2021 11:49:01 -0800 From: Tyler Retzlaff To: Jie Zhou Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v14 00/11] app/test: enable subset of tests on Windows Message-ID: <20211209194900.GD26551@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1638928262-13177-1-git-send-email-jizh@linux.microsoft.com> <1638990000-3228-1-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1638990000-3228-1-git-send-email-jizh@linux.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 08, 2021 at 10:59:49AM -0800, Jie Zhou wrote: > The goal of this patchset is to enable unit tests in CI for Windows. > It mainly contains: > - Replace POSIX specific codes > - Fix some lib and tests per failures investigation > - Add test stubs for not yet supported ones on Windows > - Replace .sh script with .py script for meson.build > - Enable build and run subset of unit tests on Windows > > Future work: > - Work with CI lab to onboard unit tests for Windows to catch regression > - Investigate issues hit at CI onboarding > - Enable more tests > > --- > V2 changes: > - Fix compilation error on FreeBSD > - Fix email mismatch issue > - Add a missing space around "*" > > --- > V3 changes: > - Fix a misc c coding style issue > - Revise some commit title and message body > - Fix violations of PEP8 in new added Python scripts > - Add error handling in get_coremask.py > - Fix has_hugepage.py to check system support of hugepages > instead of checking privileges > - Fix test meson.build to run Python scripts using py3 > - Consolidate lists of source files, test dep, etc. across all > platforms, with conditional extending on some platform(s) > > --- > V4 changes: > - Remove building of ip_frag, rib, and reorder libraries on Windows. > These three libs usually can be built on Windows without change. > However, in between the time of V3 and V4, there is regression in > upstream caused build failures of these three libs. Will separately > investigate and enable these libraries. > > - Remove previous patch#2 (Enable mempool/stack on Windows) from this > patchset as it was separated out and merged as patch-19314. > > - Consolidate the source files, deps, tests lists across platforms as > much as possible. > > --- > V5 changes: > - Remove a space between function name and open parenthesis '(' > - Add back a header mistakenly deleted > > --- > V6 changes: > - Fix inconsistent static vs. non-static declarations > > --- > V7 changes: > - Remove get_coremask.py as it is not needed any more in meson.build > - Remove enablement of efd and lpm and their corresponding unit tests. > The enablement of these two libs and their UTs will be in separate > patches after this patch set. > > V8 changes: > - Fix coding style issue of using C99 // comments > > --- > V9 changes: > - Fix has_hugepage.py with adding failure handling on Linux, using > proper variable name to follow Python convention, and removing > unnecessary comment. > - Enable previously skipped test_cmdline_socket_fns test cases > - Revise title and message, and add Fixes info for current Patch#3 > - Combine 2 patches (previous #2 and #3 in V8) into one and with > more detailed message > > --- > V10 changes: > - Fix indentation > > --- > V11 changes: > - Remove mandatory dependency on bitratestats, latencystats, > and metrics libs in test meson.build, which was reintroduced > at rebase in V9. > > --- > V12 changes: > - Remove unnecessary print of a null string > - Enable several previous disabled tests > - Split Patch#9 in V11 into two patches for better structure > - Reorder some of the patches for better structure > - Document more details in commit message for issue tracking > > --- > V13 changes: > - Fix misc coding style issue > - Fix build issue on Ubuntu 18.04 > > --- > V14 changes: > - Explain the reason of skipping telemetry tests in commit log > > Tested-by: Pallavi Kadam > the set looks good to me, let's get it in and if we need to make further changes we can. integration of the set is blocking porting of other tests. Acked-by: Tyler Retzlaff