From: Gaoxiang Liu <gaoxiangliu0@163.com>
To: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Cc: liugaoxiang@huawei.com, Gaoxiang Liu <gaoxiangliu0@163.com>
Subject: [PATCH] mbuf: delete dynamic fields copy in hdr copy
Date: Tue, 14 Dec 2021 15:56:05 +0800 [thread overview]
Message-ID: <20211214075606.979-1-gaoxiangliu0@163.com> (raw)
Because dynamic fields are registered by the DPDK application,
so it is up to the application to decide whether to copy the value of
dynamic fields.
So delete dynamic fields copy in __rte_pktmbuf_copy_hdr.
It's more flexible for the DPDK application,
and is useful for improving performance.
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
---
lib/mbuf/rte_mbuf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index dedf83c38d..e2dfd47442 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -1101,7 +1101,6 @@ __rte_pktmbuf_copy_hdr(struct rte_mbuf *mdst, const struct rte_mbuf *msrc)
mdst->tx_offload = msrc->tx_offload;
mdst->hash = msrc->hash;
mdst->packet_type = msrc->packet_type;
- rte_mbuf_dynfield_copy(mdst, msrc);
}
/**
--
2.32.0
next reply other threads:[~2021-12-14 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 7:56 Gaoxiang Liu [this message]
2022-01-11 16:45 ` Thomas Monjalon
2022-01-26 13:13 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214075606.979-1-gaoxiangliu0@163.com \
--to=gaoxiangliu0@163.com \
--cc=dev@dpdk.org \
--cc=liugaoxiang@huawei.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).