From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3760FA00C3; Wed, 15 Dec 2021 20:20:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF45340688; Wed, 15 Dec 2021 20:20:21 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 462A240041 for ; Wed, 15 Dec 2021 20:20:21 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id c22-20020a17090a109600b001b101f02dd1so10181pja.5 for ; Wed, 15 Dec 2021 11:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wZF4Gw9utWBTtVniJLQGFCBvo9fgJt8sK3PMMdHnj4E=; b=STgbVLYwEa9RtbMwTpH07ORe000F5Zd+3ANk8e7k/zT4y906IAJbx3b5qXRyPNvOyo tpzZF5tThT3tktw6/rrnbyyi/n7GugM5aqAzehyaP5wgbr0YCqUGuzhhtcY/l6CrYrMp MvnEZrwTGVyV5gkSokfsPmWBhDGuHt6cfVTyQ+uV2EDOqYPjD7jcmey/BX+ElXXCVBr+ L5z09VdxanxPRIsIxFM9Z5znRXMlqpU1iMjZq2rPVKjbRSe0NHpLcW6Exj9bmKiIs64E Ic73xyU5NS2ycnvbnoKdd1FDqILjq0vkHgVT0bGR1RL0uFC4SJ52etq2fAbFFs+KgDlW z/Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wZF4Gw9utWBTtVniJLQGFCBvo9fgJt8sK3PMMdHnj4E=; b=IhMj0/jsvb6m674RN8fNNLENCjMbtOEuaWUDw1riFb0xbKPXZLMS9ri2LhVusmH3U2 VLGsis9VSW7+jvhTQ9JKJfi4hUUgfLlh+0TSpZ/ueoq8Tp2vQ8objOE3OI62oJPkDjqk taZEs4w6UqsmQ6fraLW2In8WNv/e6yVzyTHYN6vertnVHuIUsxzGZX7W5gmww1SPQYph GT9MQ2rYNuHRU7nGrFQRV6EkA63RasrSk1evPpHlZoRK5LW1nHQxIDQdsPBShCd1R8oF njCWD6zggmLgeMtQEN1Jqp1vYM2eistP7aThnRpJT7f1PLM6sxtkNAq8fbuI3Nu6+1U6 RfvA== X-Gm-Message-State: AOAM532ZpLwd6Ove3M+c/CaF7UHAsOX0pNhNnpe+VFSv0Pytm5jNbkdE O3gqZnfCH+3/BjDs2Z/f9nRpdg== X-Google-Smtp-Source: ABdhPJy+PTKGW/veahggvO/Z95zoOP0ht5NlIFw1kdOQKxhb3UXG/KPDc6V2zQDhB8YWgj+BLxYqaQ== X-Received: by 2002:a17:902:c943:b0:142:1758:8ee7 with SMTP id i3-20020a170902c94300b0014217588ee7mr12307636pla.58.1639596020283; Wed, 15 Dec 2021 11:20:20 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id na13sm3462336pjb.11.2021.12.15.11.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 11:20:19 -0800 (PST) Date: Wed, 15 Dec 2021 11:20:17 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [dpdk-kmods] linux/igb_uio: fix build for switch fall through Message-ID: <20211215112017.26958d79@hermes.local> In-Reply-To: <20211215184859.1859870-1-ferruh.yigit@intel.com> References: <20211215184859.1859870-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 15 Dec 2021 18:48:59 +0000 Ferruh Yigit wrote: > Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't > take any fall through comments into account but only uses compiler > 'fallthrough' attribute to document fall through action is intended. > > "falls through" comment was used in the code which is causing a build > error now, this patch converts comment to the 'fallthrough' macro > defined in the Linux. > > To cover the case where Linux version doesn't have the macro, defined it > in the compatibility header too. > > Signed-off-by: Ferruh Yigit Are you sure that fixes it? because the comment in the macro is typically not visible in a macro expansion. Since in most case Linux uses gcc why not use the gcc attribute __attribute__ ((fallthrough))