From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAF09A00C3; Wed, 15 Dec 2021 15:34:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 643EB40688; Wed, 15 Dec 2021 15:34:59 +0100 (CET) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mails.dpdk.org (Postfix) with ESMTP id 9E43840041; Wed, 15 Dec 2021 15:34:57 +0100 (CET) Received: by mail-lj1-f177.google.com with SMTP id i63so33637086lji.3; Wed, 15 Dec 2021 06:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bHUfKRhQGJ5sf9jcSvWsQA3K1U8o+jXCM9FE1zzZupk=; b=HhMYnoECJBT485eCtAxnUmeGasYm4rxL9mfX7l0uUxY4lBEczHM3JzUNyAliZOWqXd h0pdnHzeoi2uhyXoAeu2QbMmpz5HjZT7xujywlQ6PiwRgR+KOd/ke25G2r6JgBfuvJVo OCGX9vnenFcNCiSabpXGVeOTsVdlExvZwWAixHI25KQHuwOgcvqJcttdUq5QQeffVuVo O/po3CaEuX9PXWKFpGYeilHuvGyBU8CLM2kn6KORx03BVt5LC9NVaUSdOkkrV2ioH19q kuBj+E3J1mEK3Q0CCRIQXuI5D66eo9b8DGmhvWAVzdCnXveZ60GZJ+lZQE2da0Hj0TET 5PeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bHUfKRhQGJ5sf9jcSvWsQA3K1U8o+jXCM9FE1zzZupk=; b=v6jEcFGjXvXZGOfUzO0piRHxr8qrqwEhJwC8AfqF5tl/El7dtaPipAjKY4ROVB0MOE FpKZYkWjiPf2ULuamMjcZNqraKpwpuB5mMvER5OLlQVRyl7FRiNJkPt44i+xhwFll6hA jFYUOKzTrJVUyUndxWeJuBEdCuea6CbjrHlZKQ8I6a4fm65Zme0+QtdIoAkdLT+g0Kqc q20NQjry8/xlvPsclA0WKzazd8ksHaoOt9//0GtNOegjZBfLmzqlwOehMjVa6zpwbCKU VcRI7etkfJfITxg+nv2z2gSRXVXqiSsnBz1V3MuKbTWNkhZQqBwTtU4ikOWBV/XS/GIO 11Pg== X-Gm-Message-State: AOAM531iXiTjnyhCxy6Ne6Lp5XSHNtP4zDfEM/M6v1BDIOvjp7QKXBO0 5zaOkQkQiqNL5E73x2AL3vw= X-Google-Smtp-Source: ABdhPJzUmqsISIOO68BtEt6U0H6cHX8L/Kcaiz6wOdK3ZvGB/LptObu1PZ4ZAPGiKKmbGfmOnIJUnQ== X-Received: by 2002:a05:651c:124f:: with SMTP id h15mr9943380ljh.514.1639578897087; Wed, 15 Dec 2021 06:34:57 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id a28sm462415ljm.65.2021.12.15.06.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 06:34:56 -0800 (PST) Date: Wed, 15 Dec 2021 17:34:55 +0300 From: Dmitry Kozlyuk To: Jerin Jacob , Gaoxiang Liu Cc: dpdk-dev , Anatoly Burakov , liugaoxiang@huawei.com, dpdk stable Subject: Re: [PATCH v3] eal: allow to exclude memseg from core dump Message-ID: <20211215173455.6e688519@sovereign> In-Reply-To: References: <20211214120817.1476-1-gaoxiangliu0@163.com> <20211214151850.1183-1-gaoxiangliu0@163.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2021-12-15 17:36 (UTC+0530), Jerin Jacob: [...] > > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c > > index 68ae93bd6e..44227aee95 100644 > > --- a/lib/eal/unix/eal_unix_memory.c > > +++ b/lib/eal/unix/eal_unix_memory.c > > @@ -83,10 +83,13 @@ eal_mem_set_dump(void *virt, size_t size, bool dump) > > int flags = dump ? EAL_DODUMP : EAL_DONTDUMP; > > int ret = madvise(virt, size, flags); > > if (ret) { > > - RTE_LOG(DEBUG, EAL, "madvise(%p, %#zx, %d) failed: %s\n", > > + RTE_LOG(INFO, EAL, "madvise(%p, %#zx, %d) failed: %s\n", > > virt, size, flags, strerror(rte_errno)); > > probably ERR instead of INFO. > > > > rte_errno = errno; > > - } > > + } else > > + RTE_LOG(INFO, EAL, "madvise(%p, %#zx, %d) success: %s\n", > > + virt, size, flags, __func__); > > This should be DEBUG. Not INFO. Usually errors from OS API are reported as DEBUG in EAL, so the first one should also remain DEBUG.