DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/virtio: unregister virtio user memery event to fix memory leak problem
@ 2021-12-20 12:41 Harold Huang
  2021-12-20 12:49 ` [PATCH v2] net/virtio: unregister virtio user memory " Harold Huang
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Harold Huang @ 2021-12-20 12:41 UTC (permalink / raw)
  To: dev; +Cc: maxime.coquelin, chenbo.xia

When eth_virtio_dev_init is failed, the registered virtio user memery is
not released and creating a new virtio user dev could be failed becase the
new dev could use the same address pointer and the register virtio user
memory to the same address is not allowed.

Signed-off-by: Harold Huang <baymaxhuang@gmail.com>
---
 drivers/net/virtio/virtio_user_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 0271098f0d..16eca2f940 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -666,6 +666,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev)
 	/* previously called by pci probing for physical dev */
 	if (eth_virtio_dev_init(eth_dev) < 0) {
 		PMD_INIT_LOG(ERR, "eth_virtio_dev_init fails");
+		virtio_user_dev_uninit(dev);
 		virtio_user_eth_dev_free(eth_dev);
 		goto end;
 	}
-- 
2.27.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-01-27  5:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 12:41 [PATCH] net/virtio: unregister virtio user memery event to fix memory leak problem Harold Huang
2021-12-20 12:49 ` [PATCH v2] net/virtio: unregister virtio user memory " Harold Huang
2021-12-20 14:08   ` Fwd: " Harold Huang
2021-12-22  8:33 ` [PATCH v3] net/virtio: fix unregister virtio user memory event cb problem Harold Huang
2021-12-23  4:42 ` [PATCH] net/virtio: fix unreleased resource when creating virtio user dev is failed Harold Huang
2022-01-14  7:48   ` Xia, Chenbo
2022-01-27  5:23   ` Xia, Chenbo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).