From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E650A034E; Wed, 22 Dec 2021 09:15:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CE2840DDA; Wed, 22 Dec 2021 09:15:49 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id DF96840687; Wed, 22 Dec 2021 09:15:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640160948; x=1671696948; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Q019mCx0uc7wSGZfTILv1M4lUrVFxGD/iF5/HsEJPE=; b=SJWBtn9cmUR6y3A0bYz4f7+RJEEtGFtTybh5vt2Jx/sCEDhtXp1msD5X s4ANmr0ciZEIPNCWsFYDnAEkLNTlyK5VWrFkqYE1rbPc7c1RLCuXWUgHq Rc9CC1tFLLo2uJZHWVqDiCT/xJrodbxdGAXVaNlaNBbWfCinfRCX5nNbz D27b/FYfRkGQWuN/xpzz4dAz7Pg36wdMtdy6+uHkrvhljudPP7zHKbODg 8KQsAj2tTSoPGO+zYJmH1/o5wrLRgw02HFdcQ6o4rk+bJSv5rTPUxR/Oc GgtU7VcfjsWs7GOUNqlvmwCOkwLDCVGN65CaEXYfieU86iiVY730ovrnq g==; X-IronPort-AV: E=McAfee;i="6200,9189,10205"; a="264768538" X-IronPort-AV: E=Sophos;i="5.88,225,1635231600"; d="scan'208";a="264768538" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 00:15:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,225,1635231600"; d="scan'208";a="664203869" Received: from dpdk-junfengguo-v1.sh.intel.com ([10.67.119.216]) by fmsmga001.fm.intel.com with ESMTP; 22 Dec 2021 00:15:44 -0800 From: Junfeng Guo To: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com, junfeng.guo@intel.com Subject: [PATCH v2] net/ice: fix pattern check for FDIR parser Date: Wed, 22 Dec 2021 16:08:52 +0800 Message-Id: <20211222080852.1604018-1-junfeng.guo@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211222080224.1580328-1-junfeng.guo@intel.com> References: <20211222080224.1580328-1-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org FDIR rules with masks are not supported in current code. Thus add pattern check for IPv4/UDP/TCP/SCTP addr/port to terminate the FDIR programming stage. Fixes: 1b71ed2cdd5d ("net/ice: refactor flow pattern parser") Cc: stable@dpdk.org Signed-off-by: Junfeng Guo --- drivers/net/ice/ice_fdir_filter.c | 32 +++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 13a2ac42df..989b5586b1 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -2037,6 +2037,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, return -rte_errno; } + /* Mask for IPv4 src/dst addrs not supported */ + if (!ipv4_mask->hdr.src_addr && + ipv4_mask->hdr.src_addr != UINT32_MAX) + return -rte_errno; + if (!ipv4_mask->hdr.dst_addr && + ipv4_mask->hdr.dst_addr != UINT32_MAX) + return -rte_errno; + if (ipv4_mask->hdr.dst_addr == UINT32_MAX) *input_set |= ICE_INSET_IPV4_DST; if (ipv4_mask->hdr.src_addr == UINT32_MAX) @@ -2178,6 +2186,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, return -rte_errno; } + /* Mask for TCP src/dst ports not supported */ + if (!tcp_mask->hdr.src_port && + tcp_mask->hdr.src_port != UINT16_MAX) + return -rte_errno; + if (!tcp_mask->hdr.dst_port && + tcp_mask->hdr.dst_port != UINT16_MAX) + return -rte_errno; + if (tcp_mask->hdr.src_port == UINT16_MAX) *input_set |= ICE_INSET_TCP_SRC_PORT; if (tcp_mask->hdr.dst_port == UINT16_MAX) @@ -2217,6 +2233,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, return -rte_errno; } + /* Mask for UDP src/dst ports not supported */ + if (!udp_mask->hdr.src_port && + udp_mask->hdr.src_port != UINT16_MAX) + return -rte_errno; + if (!udp_mask->hdr.dst_port && + udp_mask->hdr.dst_port != UINT16_MAX) + return -rte_errno; + if (udp_mask->hdr.src_port == UINT16_MAX) *input_set |= ICE_INSET_UDP_SRC_PORT; if (udp_mask->hdr.dst_port == UINT16_MAX) @@ -2254,6 +2278,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, return -rte_errno; } + /* Mask for SCTP src/dst ports not supported */ + if (!sctp_mask->hdr.src_port && + sctp_mask->hdr.src_port == UINT16_MAX) + return -rte_errno; + if (!sctp_mask->hdr.dst_port && + sctp_mask->hdr.dst_port == UINT16_MAX) + return -rte_errno; + if (sctp_mask->hdr.src_port == UINT16_MAX) *input_set |= ICE_INSET_SCTP_SRC_PORT; if (sctp_mask->hdr.dst_port == UINT16_MAX) -- 2.25.1