From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF018A0350; Thu, 23 Dec 2021 09:16:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73A7D4068C; Thu, 23 Dec 2021 09:16:10 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by mails.dpdk.org (Postfix) with ESMTP id 3C02F4067B; Thu, 23 Dec 2021 09:16:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HylS5YPUcSRSebT4P8X6YzOiJ4N4UXNf/RRtYjMcICsSUguFarwzhlawuGHrKsldwjUtymSHXufRcsMJqaFzBwkk2GQ+zjP1oUU/b50CfAvOn3xzGrKrFHGUtIIaah4XeUbCy8rlvpnoNyVEmldOb9h0L3yNtla+JSjDfVMFA2tuUbE2sjJVnl84beMgz35heEuXEPpvoxENfgxW6/tY1cBwsuGmZBPhxz8MVEaAIdH48cTEo9vvDzFLdYgFocMWEjhRK6AvNjnopUz7PoNrV0YinbdZwdfDEUjqOzTxbNf3MpRN4xoUHMylO7UclWWkM6Jmd36vzCTN6PCx3CsAXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N8QqmcADnmBeU+psDhLo+xeKyYZYngAghQRyrEGOyBA=; b=d8JIoaDf8250ahtAPwZAJppeU+29xxSRuqQ+xbH9sVu3evnbYjpympBGx4SGIXoBl7JfUrwbJaXria57KGaye0ApLTqBAb+R0PCoi3nhhOmLBBsJ2xZxtJnVMOgM7+4eLMcXTTwbtRwdYMg1WpUBsFF8aVVDrO6FnmYloldHailLUSsVrO0/tNdCKXMK7bNUdD5DmasZXTHPaECkmDCtC5eNQhfPVaexODGT+lhgRPfVNxsFrpP7c7Jimaf5KS5S2Kh71nVV5sSZG7KQjcTqpOdlzzOH7HE5JVF9J3b/hakt/9IA7xOo0vN29LnRLiv1PaVaVN1/n0Ze1QBKZRI/ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N8QqmcADnmBeU+psDhLo+xeKyYZYngAghQRyrEGOyBA=; b=h0Kxn8IkzwPBuJ7hJ6USFduId01hZ8DyBzS8bkB4SpUledivwQwko0ZqA83lpFFtaP+PFl7DNVE8yBWRf9XUrV7rhXTufKEMAi6B6RmhiVdM5tgq6G9ew5+sdpJncKgF91WPe/itTLynh6HjKxhAK/7t6siNNyhs5oWvyNjNX3fjTn8njkAf51RmmHZT639ZOiLuzHKObqJuk0AeFBJZAJ6J/Dmejb8FqdoG7Op23BRo9hE4WPoXysJOV2T4ZutFURBuOMhzA7LoFKegIG40xoDRdsvzA1VcDIsoLLsu98gfLt6NvpQzBhslF1U0N4D6Nlr/6KFr08syPy+PVXxOXA== Received: from MWHPR03CA0024.namprd03.prod.outlook.com (2603:10b6:300:117::34) by BL0PR12MB4754.namprd12.prod.outlook.com (2603:10b6:208:8e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.19; Thu, 23 Dec 2021 08:16:07 +0000 Received: from CO1NAM11FT030.eop-nam11.prod.protection.outlook.com (2603:10b6:300:117:cafe::6c) by MWHPR03CA0024.outlook.office365.com (2603:10b6:300:117::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.14 via Frontend Transport; Thu, 23 Dec 2021 08:16:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.238) by CO1NAM11FT030.mail.protection.outlook.com (10.13.174.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4823.18 via Frontend Transport; Thu, 23 Dec 2021 08:16:06 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 23 Dec 2021 08:16:05 +0000 Received: from nvidia.com (172.20.187.5) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.9; Thu, 23 Dec 2021 00:16:03 -0800 From: Lior Margalit To: Slava Ovsiienko CC: Lior Margalit , , , Subject: [PATCH v1] net/mlx5: fix assertion on the flags set in pkt mbuf Date: Thu, 23 Dec 2021 10:15:41 +0200 Message-ID: <20211223081541.3095005-1-lmargalit@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0565a5b5-d4b9-4807-9093-08d9c5ec77f3 X-MS-TrafficTypeDiagnostic: BL0PR12MB4754:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CrrlZnd+KbJ9wYR0M2H7UBov45DadRGD0JHTPbJk34OnSxHDIW3BiGORUMkGye4nXrBFmy1f7ElqMge8843HUjswakLG3D89IqcE8n9DQm/ub7lDrib+VZLOBmxIEYvdKL9DLjSTuRkeQj/dgwNxG7SnDAmw+zonzI8x6wtMg1vr8kz5+MhBZAzTscH74O0+rwZaC7EkZAnLk+pU7RZa8I5x1Z1hi+C+Xlgo8Lf2joAXFUIivrkKUgNH70r24DOKGsWZS/ZjumATQ4G0IdT1tmd+u2kJUfShqbLw9tyLbd0N/Q0DYiYQvAGkQ5Mu3kPMpFh2S1kGL/mnvfqfay5otBa3Y8vqtMliqazDx2rQP2GNEbwqXHbm8664zjJjVxLuWoiB0uZQxiP8ZlCVdpkVusDKS5QJkeS+fGS+4z6H9OWOdF108gSggn8rdW5LH8U6wkVj4IuAk1i13DL4Isb4RHZdSrHgeUZsFTGGrhcaqAq766vs3i4bAoxYZzDwvnWzwEprgYTSKVCMewsJ0TZd6AS5kcU2+BRvybbj3MtnFjHPfJWFdz1gh/YmCaNrYT+d3PFkhrXgtBA6mXxZRGDwWm4XIW/peh1iCGd5o7qCdy2T4hWmQFngmHM3wamPEv1p88iDUjwn7GDyEfbd0z0bAUQ5+tl9rUfdQP1cJ6iFG6nUJyvtI5tYjvMuYUJHbe+7LdeiKHNarxqz4QPQUj0ffwaXyf87dUjMmG+JT/yHZFtwBbQHak4/AU2TR8DNpq5yixUyNx4J2Tzk5mODkKnIG8wKTppYySW3fIp4PDr2r2w= X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(4636009)(40470700002)(36840700001)(46966006)(5660300002)(47076005)(83380400001)(37006003)(8676002)(54906003)(70206006)(70586007)(86362001)(6286002)(1076003)(8936002)(316002)(508600001)(36756003)(26005)(40460700001)(55016003)(186003)(82310400004)(2906002)(450100002)(6636002)(16526019)(7696005)(426003)(336012)(356005)(2616005)(81166007)(4326008)(6862004)(36860700001)(6666004)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2021 08:16:06.3946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0565a5b5-d4b9-4807-9093-08d9c5ec77f3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT030.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4754 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fixed the assertion on the flags set in pkt->ol_flags for vectorized MPRQ. With vectorized MPRQ the CQs are processed before copying the MPRQ bufs so the valid assertion is that the expected flag is set and not that the pkt->ol_flags equlas this flag alone. Fixes: 0f20acbf5eda ("net/mlx5: implement vectorized MPRQ burst") Cc: akozyrev@nvidia.com Cc: stable@dpdk.org Signed-off-by: Lior Margalit Acked-by: Slava Ovsiienko --- drivers/net/mlx5/mlx5_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rx.h b/drivers/net/mlx5/mlx5_rx.h index adb759c235..c178f9a24b 100644 --- a/drivers/net/mlx5/mlx5_rx.h +++ b/drivers/net/mlx5/mlx5_rx.h @@ -543,7 +543,7 @@ mprq_buf_to_pkt(struct mlx5_rxq_data *rxq, struct rte_mbuf *pkt, uint32_t len, buf_len, shinfo); /* Set mbuf head-room. */ SET_DATA_OFF(pkt, RTE_PKTMBUF_HEADROOM); - MLX5_ASSERT(pkt->ol_flags == RTE_MBUF_F_EXTERNAL); + MLX5_ASSERT(pkt->ol_flags & RTE_MBUF_F_EXTERNAL); MLX5_ASSERT(rte_pktmbuf_tailroom(pkt) >= len - (hdrm_overlap > 0 ? hdrm_overlap : 0)); DATA_LEN(pkt) = len; -- 2.25.1