From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D62D5A034F; Tue, 28 Dec 2021 16:55:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D8140040; Tue, 28 Dec 2021 16:55:28 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id C904C4003C for ; Tue, 28 Dec 2021 16:55:26 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id a11-20020a17090a854b00b001b11aae38d6so17457554pjw.2 for ; Tue, 28 Dec 2021 07:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oPoitSEskuwzgIWSEx7GU29SmtQZuUt9T1O9clFaPZ8=; b=8QMjNnyXkvoqLGwAZLc2ynwF6VJfwz01Nfso44bvOicu2xAy1Yd8QXKvv/GMSiCmdu I9MhuR2C7uH8T/GwxRcrc0/MclnPhXOH03R00T2Z37MrpsSLxIWfEHucMG2z75iJ0Ef3 GRJmNgyyyitTMWIsLbp+P7bOr0cJu/tenMfU3/ptUr5xmpRIjflF7EOKECSX6Tga4Icb tu8Vwb3ujCt/sdjUY5cZpbfK36tsKwfYw3xkHDZ/yfUV1YgDuUBKcW8JBiylSAKZRY8/ Xzwr4vE54ZlAfhCGBTQTCzoHi507JaKddO7akW+CLosyPejlg8Mt2e1A6SPkW/GjTecR /3tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oPoitSEskuwzgIWSEx7GU29SmtQZuUt9T1O9clFaPZ8=; b=jo41ZHKNnhIPY4DnfieCtkf8xl79xdlOGQeBTrQuMEuhQw1YpkxvQabCZ4+lQRLcw0 rou3RG7U5MaGxu7uY45mdvKBkN9ncs7koHLnpYE4RKfA2nt1IyIlDzaxgH6VXzu0Bg0h YJzhJaxx3ABPyP4avoVhjv978PNmD+1EVu05im3/LqK3n0zXkXrAa7qLMEqMQqOolAD1 2jxkvZ5tJ/6aB6znEFNyuMCebrH+CGHNknjrgDsmiBt6RIitplRTHYSOKqNiElUsck5t T9xOIVQm2P6cAM6/SKmjR/6x3ta1V5QxcYak6yJl0rrmR+dHnOmaqjMGmNHGaRSTPTyk sttA== X-Gm-Message-State: AOAM531t0mE4kgFahpBP86ACz+CIQS+LNRiNAf2rahV+E4DfyPV4oxFc k/clNw+aQtQbnTtNFR/ocxtPkg== X-Google-Smtp-Source: ABdhPJxuRuef0p6i45XohIH1ZOVAFAqLzUJtTGU5DaqUgRF3u7aIfxeJatYs36m+5CiTtHfZ6b/lNQ== X-Received: by 2002:a17:90b:1807:: with SMTP id lw7mr27616065pjb.98.1640706925822; Tue, 28 Dec 2021 07:55:25 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id gk13sm22929304pjb.43.2021.12.28.07.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 07:55:25 -0800 (PST) Date: Tue, 28 Dec 2021 07:55:23 -0800 From: Stephen Hemminger To: Yanling Song Cc: , , , , Subject: Re: [PATCH v3 00/25] Net/SPNIC: support SPNIC into DPDK 22.03 Message-ID: <20211228075523.7bbf660c@hermes.local> In-Reply-To: <20211228150120.000013cf@ramaxel.com> References: <20211224094457.051f3c17@hermes.local> <20211228150120.000013cf@ramaxel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 28 Dec 2021 15:01:20 +0800 Yanling Song wrote: > On Fri, 24 Dec 2021 09:44:57 -0800 > Stephen Hemminger wrote: > > > On Fri, 24 Dec 2021 16:32:18 +0800 > > Yanling Song wrote: > > > > > The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial NIC > > > cards into DPDK 22.03. Ramaxel Memory Technology is a company which > > > supply a lot of electric products: storage, communication, PCB... > > > SPNxxx is a serial PCIE interface NIC cards: > > > SPN110: 2 PORTs *25G > > > SPN120: 4 PORTs *25G > > > SPN130: 2 PORTs *100G > > > > > > The following is main features of our SPNIC: > > > - TSO > > > - LRO > > > - Flow control > > > - SR-IOV(Partially supported) > > > - VLAN offload > > > - VLAN filter > > > - CRC offload > > > - Promiscuous mode > > > - RSS > > > > > > v2->v3: > > > 1. Fix clang compiling failure. > > > > > > v1->v2: > > > 1. Fix coding style issues and compiling failures; > > > 2. Only support linux in meson.build; > > > 3. Use CLOCK_MONOTONIC_COARSE instead of > > > CLOCK_MONOTONIC/CLOCK_MONOTONIC_RAW; 4. Fix time_before(); > > > 5. Remove redundant checks in spnic_dev_configure(); > > > > Overall looks good. > > > > Please use a consistent prefix to all globally visible symbols to > > avoid any possible name clashes when statically linking. > > > > $ nm ./build/drivers/librte_net_spnic.a | grep ' t ' | grep -v > > spnic_ | grep -v rte_ 00000000000006f0 t remove_aeq > > 0000000000000040 t fault_event_handler > > 0000000000000060 t ffm_event_msg_handler > > 00000000000016c0 t alloc_mbox_info > > 0000000000000ca0 t send_mbox_to_func > > 0000000000000890 t send_tlp_mbox_to_func > > 00000000000000c0 t pciinitfn_net_spnic > > 0000000000000890 t clean_queue_offload_ctxt > > > > > Good point. There are some external functions which have no spnic_ > prefix. and there are also some static functions which have no > spnic_ prefix. > Since static functions only works in the file, it doesn't matter to add > prefix or not. My plan is to add spnic_ prefix to those external > functions. Is it ok to you? > > Yes, that is what this script was looking for, external functions with no prefix