From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9DFF5A034D;
	Wed, 29 Dec 2021 12:49:30 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1F85240151;
	Wed, 29 Dec 2021 12:49:30 +0100 (CET)
Received: from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])
 by mails.dpdk.org (Postfix) with ESMTP id E218D40040
 for <dev@dpdk.org>; Wed, 29 Dec 2021 12:49:28 +0100 (CET)
Received: from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local
 [172.26.18.31])
 by VLXDG1SPAM1.ramaxel.com with ESMTPS id 1BTBnN7v039382
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Wed, 29 Dec 2021 19:49:23 +0800 (GMT-8)
 (envelope-from songyl@ramaxel.com)
Received: from localhost (172.20.2.155) by V12DG1MBS01.ramaxel.local
 (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 29
 Dec 2021 19:49:23 +0800
Date: Wed, 29 Dec 2021 19:49:21 +0800
From: Yanling Song <songyl@ramaxel.com>
To: "lihuisong (C)" <lihuisong@huawei.com>
CC: <dev@dpdk.org>, <yanling.song@linux.dev>, <yanggan@ramaxel.com>,
 <xuyun@ramaxel.com>, <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 02/25] net/spnic: initialize the HW interface
Message-ID: <20211229194921.000043f8@ramaxel.com>
In-Reply-To: <9a9afaaf-683a-37ae-251b-42abefb3e1d5@huawei.com>
References: <cover.1640426040.git.songyl@ramaxel.com>
 <3029b106a8d95440f638874f3e8df0f89d61647b.1640426040.git.songyl@ramaxel.com>
 <9a9afaaf-683a-37ae-251b-42abefb3e1d5@huawei.com>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.2.155]
X-ClientProxiedBy: V12DG1MBS03.ramaxel.local (172.26.18.33) To
 V12DG1MBS01.ramaxel.local (172.26.18.31)
X-DNSRBL: 
X-MAIL: VLXDG1SPAM1.ramaxel.com 1BTBnN7v039382
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


> > @@ -35,11 +68,42 @@ static int spnic_func_init(struct rte_eth_dev
> > *eth_dev) pci_dev->addr.domain, pci_dev->addr.bus,
> >   		 pci_dev->addr.devid, pci_dev->addr.function);
> >   
> > +	eth_dev->data->dev_flags |=
> > RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;  
> 
> Please do not use the temporary macro. Please review this patch:
> 
> f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue
> xstats")
> 
Ok. RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS will be removed in V5.