From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5951EA04A5; Thu, 30 Dec 2021 15:48:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E04FE410F1; Thu, 30 Dec 2021 15:48:55 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2086.outbound.protection.outlook.com [40.107.244.86]) by mails.dpdk.org (Postfix) with ESMTP id 295D440F35 for ; Thu, 30 Dec 2021 15:48:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LukjQOCAPrDi6xcUaYKhKGJsrYauOTxSBHacvURdFTTe28jrD/0YG4ueqr1bRvtysQ7DvXI6AoNakKXVsy1excy3JlMtubY3oXVdm/bYR6aDVadnWFAqBNW9FYSNtkfT5icd3DWGrBQdy4vJ8hq1nyn6ih4vJzi+40YlH/kZN3sBuMN+xvEBsrv99wK2tW+4UmJvCfAJXEn2gC0nxW6upiHq+PH7TQUrw2SPhtmZ6XpbOBsfn+oP2bxGKDEfrGlKLI6lDXcoMWxpUrJnifrBx9dlnNYDrdz/nTO9KEz1y7H61yZUMUhNXTEsBwV+C42ZyHXMCJPERGIbSQSPUKDDFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YNex9xojSORQQ5vrHy0+qa4ydSeStw/7eFu+Ayts7yE=; b=Vh5VS653pmTu0QiqHzrdJH1mbRqjvOemZj0rOBnH8HP7LRad0Rucp7m4MUuykiIPOxjoH6lod5Z/uBsmOhzd8tFQVCcdFXoolabG3Xpiz3KzTgu2CH8mqseW6Z/o/GnfG4yUrISuaRZznAUCANIzBgbLtqvTntFo/LfzhkSj9JwB0YaacKRTN5/pRk2nP9bQXnQtloGp0gdkW/N7rXylgyn42tGOk+1kYZk7qVlj1jU6HnHtsn3Y1mIoqVo96LW2ZpFnEgEW2e1dc0B7mpjvh5pFDSOZ7R7MCK/yL4ROQBQa8/d5DjWqNpIs+ZF7B3ygrCJPRazLtu97W16tki59Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YNex9xojSORQQ5vrHy0+qa4ydSeStw/7eFu+Ayts7yE=; b=kJ1QCh6diHI3CFGYq+c7oNoz5gKT919XrN6bsWmkwAzVsRuF+ZJorsY0S0LZ8RMTxAiddlLPWjUj6AO8zgxg5qFtkwShFCAp1y1AttD4vkON0YBIkQ0kKfRedbWhDXGjJegrhHQkNWbITfJygySgwD//NLvLKfnYhn5yHVKWtCtqczSQQDXUSCsSP0tD03iHLyTGQl7PEyS74XnZ9yiWNgq46j0QO5gI/sl1DfwD1mGjZUSQmP4Yv8iwFDTgTGsKkoek0E+PNOXBWk4WctfUjviVHhXKiXof3GyvsjRklYJ4jE5kwuf6hLriN+wJrO4k1QGEtVbB4DzyK+45OPU+6g== Received: from DM5PR21CA0068.namprd21.prod.outlook.com (2603:10b6:3:129::30) by BL1PR12MB5287.namprd12.prod.outlook.com (2603:10b6:208:317::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Thu, 30 Dec 2021 14:48:53 +0000 Received: from DM6NAM11FT060.eop-nam11.prod.protection.outlook.com (2603:10b6:3:129:cafe::b1) by DM5PR21CA0068.outlook.office365.com (2603:10b6:3:129::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.3 via Frontend Transport; Thu, 30 Dec 2021 14:48:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.234) by DM6NAM11FT060.mail.protection.outlook.com (10.13.173.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4844.14 via Frontend Transport; Thu, 30 Dec 2021 14:48:52 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 30 Dec 2021 14:48:52 +0000 Received: from nvidia.com (172.20.187.6) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.9; Thu, 30 Dec 2021 06:48:51 -0800 From: Dmitry Kozlyuk To: CC: Anatoly Burakov Subject: [RFC PATCH 5/6] eal: allow hugepage file reuse with --huge-unlink Date: Thu, 30 Dec 2021 16:48:28 +0200 Message-ID: <20211230144828.3550807-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211230143744.3550098-1-dkozlyuk@nvidia.com> References: <20211230143744.3550098-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1a00c35-f250-4d50-2f6b-08d9cba37f98 X-MS-TrafficTypeDiagnostic: BL1PR12MB5287:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZfcYdjo6y+0/VBIFU4hG7we8WUOUMs3+jaqXWsz8kIAaU3CAl/gL+Kp48VElH7AI7kfujTvRaIiCdL65J3qZlAC1DkrobLkdt9llUPOn/wNbRM4L8pIWIklaRyjKc8Xa8CDENnKGrwqDZBd6iW8Xqd0Yfn+uhXCFYvmlahjyM4AXsNKbMlsa/8wPljuSnSGhzLJg8ZALqcmRlIIurjNWml7YCj9c8QzSNwOeuw7i2nYFjN70CISe4jftw/WGr/NVjP+nRwzXSVJzaLOfjYR3DNaaeGS20/RckOvlxry/e4o2rJ/nTgNRNTwpo4t5nx5lYXVZv5uVgYioKeQvhuvBLEPRkK9DC6Rzpp/OfzwRm0bpATe09IqDTgwLKk6rRQdiHu/uOEXj2z0ceIYw5SrEsPfqSOAp3P6oWoLAaIehcQ+aA3ZmT0u5SvaOiZ7XAiQU0ol4ttFML+L344MtkUypVW/iUfLPfHynryCfMB774C0UFq9p+YmjPZwpJftKF4V61jFSyE5opjU+ay0NWaSlkJICTKaRuKhaR93twE29AiPQqMu6t/HoN7aYlWH+Nkp91kVfG6a7yB5EvYwYUqO9e8zMd1eyjRUquKW4KHKZKhanxFXq2CgoLf+8kLNg0Pl4KyAdJuQhiDjbHVxwfjnYIZ2IehZ4mg0IfhaH7+MnlfGZzC2yKiq5wKjgrdCRPHAHgIPhb9h/jJIW9jERlGSyqU+cenKZwh5yeYyFdcuLQWEhogIJ1wSLn4OY3YZLU/puXRpJeWKGw0KMEA7YO2fuVSJyt4fz0ZDc04aBfGG3PeFUNDeTkONInuuCRIthEK+d6nfqeQK6+GCHzSFCg5nn0A== X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(40470700002)(316002)(2906002)(36756003)(5660300002)(1076003)(6916009)(47076005)(70586007)(508600001)(6666004)(86362001)(2616005)(186003)(4326008)(83380400001)(426003)(55016003)(336012)(40460700001)(82310400004)(81166007)(6286002)(8936002)(356005)(8676002)(16526019)(7696005)(36860700001)(26005)(70206006)(14583001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2021 14:48:52.9017 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1a00c35-f250-4d50-2f6b-08d9cba37f98 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT060.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5287 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Expose Linux EAL ability to reuse existing hugepage files via --huge-unlink=never switch. Default behavior is unchanged, it can also be specified using --huge-unlink=existing for consistency. Old --huge-unlink switch is kept, it is an alias for --huge-unlink=always. Signed-off-by: Dmitry Kozlyuk --- doc/guides/linux_gsg/linux_eal_parameters.rst | 21 ++++++++-- .../prog_guide/env_abstraction_layer.rst | 9 +++++ doc/guides/rel_notes/release_22_03.rst | 7 ++++ lib/eal/common/eal_common_options.c | 39 +++++++++++++++++-- 4 files changed, 69 insertions(+), 7 deletions(-) diff --git a/doc/guides/linux_gsg/linux_eal_parameters.rst b/doc/guides/linux_gsg/linux_eal_parameters.rst index 74df2611b5..64cd73b497 100644 --- a/doc/guides/linux_gsg/linux_eal_parameters.rst +++ b/doc/guides/linux_gsg/linux_eal_parameters.rst @@ -84,10 +84,23 @@ Memory-related options Use specified hugetlbfs directory instead of autodetected ones. This can be a sub-directory within a hugetlbfs mountpoint. -* ``--huge-unlink`` - - Unlink hugepage files after creating them (implies no secondary process - support). +* ``--huge-unlink[=existing|always|never]`` + + No ``--huge-unlink`` option or ``--huge-unlink=existing`` is the default: + existing hugepage files are removed and re-created + to ensure the kernel clears the memory and prevents any data leaks. + + With ``--huge-unlink`` (no value) or ``--huge-unlink=always``, + hugepage files are also removed after creating them, + so that the application leaves no files in hugetlbfs. + This mode implies no multi-process support. + + When ``--huge-unlink=never`` is specified, existing hugepage files + are not removed neither before nor after mapping them. + This makes restart faster by saving time to clear memory at initialization, + but it may slow down zeroed allocations later. + Reused hugepages can contain data from previous processes that used them, + which may be a security concern. * ``--match-allocations`` diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst index 6cddb86467..d8940f5e2e 100644 --- a/doc/guides/prog_guide/env_abstraction_layer.rst +++ b/doc/guides/prog_guide/env_abstraction_layer.rst @@ -277,6 +277,15 @@ to prevent data leaks from previous users of the same hugepage. EAL ensures this behavior by removing existing backing files at startup and by recreating them before opening for mapping (as a precaution). +One expection is ``--huge-unlink=never`` mode. +It is used to speed up EAL initialization, usually on application restart. +Clearing memory constitutes more than 95% of hugepage mapping time. +EAL can save it by remapping existing backing files +with all the data left in the mapped hugepages ("dirty" memory). +Such segments are marked with ``RTE_MEMSEG_FLAG_DIRTY``. +Memory allocator detects dirty segments handles them accordingly, +in particular, it clears memory requested with ``rte_zmalloc*()``. + Anonymous mapping does not allow multi-process architecture, but it is free of filename conflicts and leftover files on hugetlbfs. If memfd_create(2) is supported both at build and run time, diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst index 6d99d1eaa9..0b882362cf 100644 --- a/doc/guides/rel_notes/release_22_03.rst +++ b/doc/guides/rel_notes/release_22_03.rst @@ -55,6 +55,13 @@ New Features Also, make sure to start the actual text at the margin. ======================================================= +* **Added ability to reuse hugepages in Linux.** + + It is possible to reuse files in hugetlbfs to speed up hugepage mapping, + which may be useful for fast restart and large allocations. + The new mode is activated with ``--huge-unlink=never`` + and has security implications, refer to the user and programmer guides. + Removed Items ------------- diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index 7520ebda8e..905a7769bd 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -74,7 +74,7 @@ eal_long_options[] = { {OPT_FILE_PREFIX, 1, NULL, OPT_FILE_PREFIX_NUM }, {OPT_HELP, 0, NULL, OPT_HELP_NUM }, {OPT_HUGE_DIR, 1, NULL, OPT_HUGE_DIR_NUM }, - {OPT_HUGE_UNLINK, 0, NULL, OPT_HUGE_UNLINK_NUM }, + {OPT_HUGE_UNLINK, 2, NULL, OPT_HUGE_UNLINK_NUM }, {OPT_IOVA_MODE, 1, NULL, OPT_IOVA_MODE_NUM }, {OPT_LCORES, 1, NULL, OPT_LCORES_NUM }, {OPT_LOG_LEVEL, 1, NULL, OPT_LOG_LEVEL_NUM }, @@ -1596,6 +1596,28 @@ available_cores(void) return str; } +#define HUGE_UNLINK_NEVER "never" + +static int +eal_parse_huge_unlink(const char *arg, struct hugepage_file_discipline *out) +{ + if (arg == NULL || strcmp(arg, "always") == 0) { + out->unlink_before_mapping = true; + return 0; + } + if (strcmp(arg, "existing") == 0) { + /* same as not specifying the option */ + return 0; + } + if (strcmp(arg, HUGE_UNLINK_NEVER) == 0) { + RTE_LOG(WARNING, EAL, "Using --"OPT_HUGE_UNLINK"=" + HUGE_UNLINK_NEVER" may create data leaks.\n"); + out->keep_existing = true; + return 0; + } + return -1; +} + int eal_parse_common_option(int opt, const char *optarg, struct internal_config *conf) @@ -1737,7 +1759,10 @@ eal_parse_common_option(int opt, const char *optarg, /* long options */ case OPT_HUGE_UNLINK_NUM: - conf->hugepage_file.unlink_before_mapping = true; + if (eal_parse_huge_unlink(optarg, &conf->hugepage_file) < 0) { + RTE_LOG(ERR, EAL, "invalid --"OPT_HUGE_UNLINK" option\n"); + return -1; + } break; case OPT_NO_HUGE_NUM: @@ -2068,6 +2093,12 @@ eal_check_common_options(struct internal_config *internal_cfg) "not compatible with --"OPT_HUGE_UNLINK"\n"); return -1; } + if (internal_cfg->hugepage_file.keep_existing && + internal_cfg->in_memory) { + RTE_LOG(ERR, EAL, "Option --"OPT_IN_MEMORY" is not compatible " + "with --"OPT_HUGE_UNLINK"="HUGE_UNLINK_NEVER"\n"); + return -1; + } if (internal_cfg->legacy_mem && internal_cfg->in_memory) { RTE_LOG(ERR, EAL, "Option --"OPT_LEGACY_MEM" is not compatible " @@ -2200,7 +2231,9 @@ eal_common_usage(void) " --"OPT_NO_TELEMETRY" Disable telemetry support\n" " --"OPT_FORCE_MAX_SIMD_BITWIDTH" Force the max SIMD bitwidth\n" "\nEAL options for DEBUG use only:\n" - " --"OPT_HUGE_UNLINK" Unlink hugepage files after init\n" + " --"OPT_HUGE_UNLINK"[=existing|always|never]\n" + " When to unlink files in hugetlbfs\n" + " ('existing' by default, no value means 'always')\n" " --"OPT_NO_HUGE" Use malloc instead of hugetlbfs\n" " --"OPT_NO_PCI" Disable PCI\n" " --"OPT_NO_HPET" Disable HPET\n" -- 2.25.1