From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1D26A00C3; Mon, 17 Jan 2022 23:17:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EAFF426D4; Mon, 17 Jan 2022 23:17:01 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id A278C40140 for ; Mon, 17 Jan 2022 23:16:59 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id a5so11360228pfo.5 for ; Mon, 17 Jan 2022 14:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fMmo2OFsmvooJ1/RC+RNnwFrq7sAGDnwQE9gUFvqjko=; b=8AvR9onM1XLNwjTpU+Fbx3VE1TcDlggncxkGLZBT9ZUpe7JuLvEsGR083o8837UZE5 rxFK2gn8vTJLLEPVaOR4siI6xONdiqcyBHnOjpOwDQ5fQg1lanB4kuPxe2zXkubeXndQ u4L6qDokg2Z8HTiMoatz2G/VK5f4XChcAgnXCHn7bKKuRXJCiwFGVGiPPCkSYBF38Ryz Znvb2cPVPmJLzEkoHDREq6wI8p9BxiENAYbrGHBSiRjRMSPeikWqeiNjQfYHAgpYEitW DdGhVetRPeaR8JcjRmMGRw7j6PVydCAw5p7GSTumIGAHfoUgq9Pz09M5QIWDKXHA9ggR pUlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fMmo2OFsmvooJ1/RC+RNnwFrq7sAGDnwQE9gUFvqjko=; b=xeP2KDCqm4eLAutMGZM+out1woDLLED4LhpKc9bMItEFZmtIU6X+1+rvWcw88S5Ig0 EinoJKCL1+m37p/yR9uZ1xScQPWfNv3d/GPcM+RzNjLXAyX7zIUaFnrtl6D53tOswVu9 VeqakGDQJG06PmhI7bWIsY0l/kRU5vFJ5lzq8cMW0KTKUd0c1mooI11WGRGIYESj5ceB I+A0dp5tfKgH2D41PfTvRTdCZR7teX5Y1G8YTZI5umSgm8vw3IsoS0aMGdrTaTO80p0E 3LPNR7un4v5beu8Lz5VB4BdVFwwggDJ0lwARyOnVoiVfDeHd02qWLnbw3vV6qif102pu FmoA== X-Gm-Message-State: AOAM533c7gSLNLQobTvlScLBlPya6mShJ6uZKbqKHcP5lpxJ93TJdJon Y4VzUhJad6hP1uw6nyZiKDnogA== X-Google-Smtp-Source: ABdhPJzz6NlkqwicOEPMR2Y/6FfV/0Tf7V19BwrMUoD+wqhd9lAKDdf/DhJnL96Depg0wfgWPhEVsQ== X-Received: by 2002:a05:6a00:24c2:b0:4bc:bea:1e60 with SMTP id d2-20020a056a0024c200b004bc0bea1e60mr22766366pfv.63.1642457818669; Mon, 17 Jan 2022 14:16:58 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id t23sm312628pju.7.2022.01.17.14.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 14:16:58 -0800 (PST) Date: Mon, 17 Jan 2022 14:16:55 -0800 From: Stephen Hemminger To: Kumara Parameshwaran Cc: keith.wiles@intel.com, dev@dpdk.org, Kumara Parameshwaran Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process Message-ID: <20220117141655.2a375448@hermes.local> In-Reply-To: <20211126041515.96259-1-kumaraparamesh92@gmail.com> References: <20211126041515.96259-1-kumaraparamesh92@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 26 Nov 2021 09:45:15 +0530 Kumara Parameshwaran wrote: > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > + if (ret) { > + TAP_LOG(ERR, "Failed to get port id for %s", > + request_param->port_name); > + return -1; > + } > + dev = &rte_eth_devices[port_id]; > + process_private = dev->process_private; > + dev->data->nb_rx_queues = request_param->rxq_count; > + dev->data->nb_tx_queues = request_param->txq_count; Why is this necessary? dev->data is already in memory shared between primary and secondary process.