DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wei Huang <wei.huang@intel.com>
To: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com
Cc: stable@dpdk.org, tianfei.zhang@intel.com, ferruh.yigit@intel.com,
	Wei Huang <wei.huang@intel.com>
Subject: [PATCH v1 3/4] raw/ifpga: fix ifpga devices cleanup function
Date: Mon, 17 Jan 2022 22:17:37 -0500	[thread overview]
Message-ID: <20220118031738.2059-4-wei.huang@intel.com> (raw)
In-Reply-To: <20220118031738.2059-1-wei.huang@intel.com>

Use rte_dev_remove() to replace rte_rawdev_pmd_release()
in ifpga_rawdev_cleanup(), resources occupied by ifpga
raw devices such as threads can be released correctly.

Fixes: f724a802 ("raw/ifpga: add miscellaneous APIs")

Signed-off-by: Wei Huang <wei.huang@intel.com>
---
 drivers/raw/ifpga/ifpga_rawdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c
index 9663b67..8d47fd5 100644
--- a/drivers/raw/ifpga/ifpga_rawdev.c
+++ b/drivers/raw/ifpga/ifpga_rawdev.c
@@ -1787,12 +1787,14 @@ int ifpga_rawdev_partial_reconfigure(struct rte_rawdev *dev, int port,
 void ifpga_rawdev_cleanup(void)
 {
 	struct ifpga_rawdev *dev;
+	struct rte_rawdev *rdev;
 	unsigned int i;
 
 	for (i = 0; i < IFPGA_RAWDEV_NUM; i++) {
 		dev = &ifpga_rawdevices[i];
 		if (dev->rawdev) {
-			rte_rawdev_pmd_release(dev->rawdev);
+			rdev = dev->rawdev;
+			rte_dev_remove(rdev->device);
 			dev->rawdev = NULL;
 		}
 	}
-- 
1.8.3.1


  parent reply	other threads:[~2022-01-18  3:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18  3:17 [PATCH v1 0/4] Fix bugs found in raw/ifpga development for arrow creek Wei Huang
2022-01-18  3:17 ` [PATCH v1 1/4] raw/ifpga/base: fix SPI transaction Wei Huang
2022-01-18  3:17 ` [PATCH v1 2/4] raw/ifpga: fix pthread cannot join Wei Huang
2022-01-18  3:17 ` Wei Huang [this message]
2022-01-18  3:17 ` [PATCH v1 4/4] raw/ifpga/base: fix port feature ID Wei Huang
2022-01-18  6:39   ` Xu, Rosen
2022-01-18  7:37 ` [PATCH v2 0/4] Fix bugs found in raw/ifpga development for arrow creek Wei Huang
2022-01-18  7:37   ` [PATCH v2 1/4] raw/ifpga/base: fix SPI transaction Wei Huang
2022-01-18  7:37   ` [PATCH v2 2/4] raw/ifpga: fix pthread cannot join Wei Huang
2022-01-18  7:37   ` [PATCH v2 3/4] raw/ifpga: fix ifpga devices cleanup function Wei Huang
2022-01-18  7:37   ` [PATCH v2 4/4] raw/ifpga/base: fix port feature ID Wei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118031738.2059-4-wei.huang@intel.com \
    --to=wei.huang@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=tianfei.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).