DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>
Cc: Ray Kinsella <mdr@ashroe.eu>, "dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Shivah Shankar Shankar Narayan Rao <sshankarnara@marvell.com>
Subject: Re: [EXT] Re: [PATCH v4 1/1] eal: add internal function to get base address
Date: Tue, 18 Jan 2022 12:40:27 +0300	[thread overview]
Message-ID: <20220118124027.1ad3a38f@sovereign> (raw)
In-Reply-To: <CO6PR18MB3939E30DC555B6658DF23030AE589@CO6PR18MB3939.namprd18.prod.outlook.com>

2022-01-18 05:29 (UTC+0000), Srikanth Yalavarthi:
> Hi Dmitry,
> 
> This is to cater to use cases where chunks of memory are allocated by the host / application, and would like to represent it as an offset from the Linux virtual base address. One use case is for a firmware running on an accelerator, this can be used as reference address to access host memory.
> 
> Another situation can be to use the offset as an identifier for the memory using smaller data types

Thank you, the intent is clear now. It is worth adding to the commit log.
On the implementation: eal_get_baseaddr() does not respect --base-virtaddr,
you probably want something like what eal_get_virtual_area() uses:

	internal_conf->base_virtaddr != 0 ?
		internal_conf->base_virtaddr : eal_get_baseaddr()

P.S. Please avoid top-posting.


  reply	other threads:[~2022-01-18  9:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 11:22 [PATCH " Srikanth Yalavarthi
2022-01-17 13:38 ` [PATCH v3 " Srikanth Yalavarthi
2022-01-17 13:42 ` [PATCH v4 " Srikanth Yalavarthi
2022-01-17 14:43   ` Dmitry Kozlyuk
2022-01-18  5:29     ` [EXT] " Srikanth Yalavarthi
2022-01-18  9:40       ` Dmitry Kozlyuk [this message]
2022-01-18 13:33 ` [PATCH v5 " Srikanth Yalavarthi
2022-02-02 14:19   ` Thomas Monjalon
2022-02-04 19:28   ` Dmitry Kozlyuk
2022-02-08 17:15   ` Burakov, Anatoly
2022-02-08 22:58     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118124027.1ad3a38f@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mdr@ashroe.eu \
    --cc=sshankarnara@marvell.com \
    --cc=syalavarthi@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).