From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02268A0352; Wed, 19 Jan 2022 05:51:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79DB7407FF; Wed, 19 Jan 2022 05:51:17 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 93F2C4013F for ; Wed, 19 Jan 2022 05:51:16 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id a1-20020a17090a688100b001b3fd52338eso1465323pjd.1 for ; Tue, 18 Jan 2022 20:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E9z5xCj1jQf9ByBIVXJSXeUyOMqzrdVj4NqKf2zOM4M=; b=gGt8evTxdrgGJStCcItEOENdJHjSEcByStJ2K1eEbObmDxOluxefjVh+EWGRtuVMZ0 x0vvP5e2cvTPdPNw9u62YusL6Yi+LFVMFE1W/Pw5bDnYgJfFc0WsBlqPV/PjWb1es0gt tXx55EPuWzXmRPCJmLqtibcoN5jFtbGhBK2Yu5dnDf609G3fJl7BduerzU27SEhJkZUO YhLBMUZKu8UhU+ozp4xjw+P+9RvtkW29qAY6O+WXHAK23xAzS2PHsEVMbmdDzskzpRX7 H9JRhn41E+T6fpksvwMCn5gRt9Bp1uWXd/yaYGy4yfIara6f1AzLH546Gol4TbklXLMX H25A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E9z5xCj1jQf9ByBIVXJSXeUyOMqzrdVj4NqKf2zOM4M=; b=EXPAhF13rD1JZpmVuwdzSkBz+Q/k522cXeKsehZSqTdYyT4HQ/aqYFnNwMPBSqafph wU2H1WguKoiHD20yl3guyeAhY0GVD+7C74W0lzmgVRdbkHn7uXJsvbXXuBT5kjp8xKnC GRETA97TziuqLtEf6ehimNqq5lDBi8bY+YI/xCTgNG9XpLE5A1sveKDUVSasUAFtJ6mi nQRpV28V9/rlN2eW+zUU10rd4OQl7POW2nX+8jdVG6smAtC/HEfQACxZnaw3gaw1RQs9 4cVcsOzKtjtooQqfeEO9v0X9f/83q3A7GlPS6UJ+N4/KLAbnaj6xL8JPBImwrxO27E4M j+8Q== X-Gm-Message-State: AOAM532+EtQUbMRXxl5Q60O+1Nk876HcHQDNLQyBpcgD84nDQv9PQeKT toae5xlmPNpyVDBuOQ9gy0Asjqh3x93kFA== X-Google-Smtp-Source: ABdhPJzoT6YvY/un/MIrEfevzt/I3Y4q9Li1OyO8sa0+e4jAJE2So+8Deg9OIeQi0R0/hwFrq+Qz5g== X-Received: by 2002:a17:90b:1c10:: with SMTP id oc16mr2264964pjb.50.1642567875569; Tue, 18 Jan 2022 20:51:15 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id n28sm15932775pgl.7.2022.01.18.20.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 20:51:15 -0800 (PST) Date: Tue, 18 Jan 2022 20:51:12 -0800 From: Stephen Hemminger To: kumaraparameshwaran rathinavel Cc: Kumara Parameshwaran , "keith.wiles@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process Message-ID: <20220118205112.20506a2a@hermes.local> In-Reply-To: References: <20211126041515.96259-1-kumaraparamesh92@gmail.com> <20220117141655.2a375448@hermes.local> <20220118082143.0eedf2b5@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 19 Jan 2022 10:03:49 +0530 kumaraparameshwaran rathinavel wrote: > > > Why is this necessary? dev->data is already in memory shared between > > primary > > > and secondary process. > > > > > The question is about the two assignments that happen in secondary proces > > > that change dev->data->nb_rx_queues and dev->data->nb_tx_queues. These > > are > > > shared and should not need to be modified here. > > > Sure my bad. Misunderstood the comment. Yes, this should not be done, will > remove the assignments. No problem, primary/secondary process support is a bug farm because it is too easy to have pointer that is from primary process leak into secondary. I just wanted to make sure there wasn't something wrong in the infrastructure.