From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 418CAA034C;
	Fri, 21 Jan 2022 10:33:34 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 27F4542737;
	Fri, 21 Jan 2022 10:33:34 +0100 (CET)
Received: from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])
 by mails.dpdk.org (Postfix) with ESMTP id 5273040042
 for <dev@dpdk.org>; Fri, 21 Jan 2022 10:33:32 +0100 (CET)
Received: from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local
 [172.26.18.31])
 by VLXDG1SPAM1.ramaxel.com with ESMTPS id 20L9XQR1035766
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Fri, 21 Jan 2022 17:33:26 +0800 (GMT-8)
 (envelope-from songyl@ramaxel.com)
Received: from localhost (172.20.2.155) by V12DG1MBS01.ramaxel.local
 (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.17; Fri, 21
 Jan 2022 17:33:25 +0800
Date: Fri, 21 Jan 2022 17:33:24 +0800
From: Yanling Song <songyl@ramaxel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, <yanling.song@linux.dev>, <yanggan@ramaxel.com>,
 <xuyun@ramaxel.com>, <stephen@networkplumber.org>, <lihuisong@huawei.com>
Subject: Re: [PATCH v6 05/26] net/spnic: add mgmt module
Message-ID: <20220121173324.00004b9a@ramaxel.com>
In-Reply-To: <e7129168-167b-28d8-f8a0-472dad7e94bb@intel.com>
References: <cover.1640838702.git.songyl@ramaxel.com>
 <ff238f00fa098c02e8fd15c2068f45229a6e9118.1640838702.git.songyl@ramaxel.com>
 <e7129168-167b-28d8-f8a0-472dad7e94bb@intel.com>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.2.155]
X-ClientProxiedBy: V12DG1MBS01.ramaxel.local (172.26.18.31) To
 V12DG1MBS01.ramaxel.local (172.26.18.31)
X-DNSRBL: 
X-MAIL: VLXDG1SPAM1.ramaxel.com 20L9XQR1035766
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, 19 Jan 2022 17:22:51 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 12/30/2021 6:08 AM, Yanling Song wrote:
> > Mgmt module manage the message gerenated from the hardware.
> > This patch implements mgmt module initialization, related event
> > processing and message command definition.
> > 
> > Signed-off-by: Yanling Song <songyl@ramaxel.com>  
> 
> <...>
> 
> > +static void spnic_get_port_link_info(u8 link_state, struct
> > rte_eth_link *link) +{
> > +	if (!link_state) {
> > +		link->link_status = ETH_LINK_DOWN;
> > +		link->link_speed = ETH_SPEED_NUM_NONE;
> > +		link->link_duplex = ETH_LINK_HALF_DUPLEX;
> > +		link->link_autoneg = ETH_LINK_FIXED;
> > +	}  
> 
> The driver is using deprecated macros. If you can rebase on top of
> latest next-net, you will get the warnings.
> 
> Since it is hard to continue with bunch of build errors, I will wait
> for next version and can continue the reviews with it.

Thanks for pointing it out. Will use new macros to replace the old ones
in the next version.