From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B04A5A034C;
	Fri, 21 Jan 2022 10:36:34 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 51DF042738;
	Fri, 21 Jan 2022 10:36:34 +0100 (CET)
Received: from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])
 by mails.dpdk.org (Postfix) with ESMTP id 98EE340042
 for <dev@dpdk.org>; Fri, 21 Jan 2022 10:36:32 +0100 (CET)
Received: from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local
 [172.26.18.31])
 by VLXDG1SPAM1.ramaxel.com with ESMTPS id 20L9aTWY036791
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Fri, 21 Jan 2022 17:36:29 +0800 (GMT-8)
 (envelope-from songyl@ramaxel.com)
Received: from localhost (172.20.2.155) by V12DG1MBS01.ramaxel.local
 (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.17; Fri, 21
 Jan 2022 17:36:28 +0800
Date: Fri, 21 Jan 2022 17:36:27 +0800
From: Yanling Song <songyl@ramaxel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, <yanling.song@linux.dev>, <yanggan@ramaxel.com>,
 <xuyun@ramaxel.com>, <stephen@networkplumber.org>, <lihuisong@huawei.com>
Subject: Re: [PATCH v6 09/26] net/spnic: support MAC and link event handling
Message-ID: <20220121173627.00001c8e@ramaxel.com>
In-Reply-To: <54e67663-9c38-6bdb-7033-207da837668b@intel.com>
References: <cover.1640838702.git.songyl@ramaxel.com>
 <683cdaab3c9602409662f77862b83f2c345855c5.1640838702.git.songyl@ramaxel.com>
 <54e67663-9c38-6bdb-7033-207da837668b@intel.com>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.2.155]
X-ClientProxiedBy: V12DG1MBS01.ramaxel.local (172.26.18.31) To
 V12DG1MBS01.ramaxel.local (172.26.18.31)
X-DNSRBL: 
X-MAIL: VLXDG1SPAM1.ramaxel.com 20L9aTWY036791
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, 19 Jan 2022 17:26:47 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 12/30/2021 6:08 AM, Yanling Song wrote:
> > This commit adds interfaces to add/remove MAC addresses
> > and registers related ops to struct eth_dev_ops. Furthermore,
> > this commit adds callback to handle link events.
> >   
> 
> The patch also adds the VF dev_ops.
> 
> It would be more clear to support PF first and add mbox support and
> VF later. But VF support is crept into the code from early patches, I
> assume that is because the driver is already complete and spliting it
> is hard at this stage..
> 
Yes. it is.

> Similarly the primary/secondary support seems spread through the
> patches, hard to separate the feature.
> 
> 
> Above are sign of the patches are not split logically which makes
> harder to review them and detect any issues, and future fixes
> references won't be clear.
> 
> If you can clarify the split more, that would be great but I can see
> it is hard with an existing driver.
> 
Sorry for the inconvenient. Will split the patches clearly in the next
version. 

> > Signed-off-by: Yanling Song <songyl@ramaxel.com>  
>