From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC9FDA034C; Fri, 21 Jan 2022 10:40:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C99FB4273B; Fri, 21 Jan 2022 10:40:29 +0100 (CET) Received: from VLXDG1SPAM1.ramaxel.com (email.ramaxel.com [221.4.138.186]) by mails.dpdk.org (Postfix) with ESMTP id 7630B40042 for ; Fri, 21 Jan 2022 10:40:28 +0100 (CET) Received: from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local [172.26.18.31]) by VLXDG1SPAM1.ramaxel.com with ESMTPS id 20L9ePaj038696 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Jan 2022 17:40:25 +0800 (GMT-8) (envelope-from songyl@ramaxel.com) Received: from localhost (172.20.2.155) by V12DG1MBS01.ramaxel.local (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.17; Fri, 21 Jan 2022 17:40:25 +0800 Date: Fri, 21 Jan 2022 17:40:23 +0800 From: Yanling Song To: Ferruh Yigit CC: , , , , , Subject: Re: [PATCH v6 26/26] net/spnic: fixes unsafe C style code Message-ID: <20220121174023.00003747@ramaxel.com> In-Reply-To: References: X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.2.155] X-ClientProxiedBy: V12DG1MBS01.ramaxel.local (172.26.18.31) To V12DG1MBS01.ramaxel.local (172.26.18.31) X-DNSRBL: X-MAIL: VLXDG1SPAM1.ramaxel.com 20L9ePaj038696 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 19 Jan 2022 17:28:11 +0000 Ferruh Yigit wrote: > On 12/30/2021 6:09 AM, Yanling Song wrote: > > Use the hardware structure instead of void* as parameter of > > function to keep the type information > > Hi Yanling, > > This is a new driver and first patchset for it. Instead of fixing it > in the set, why not update old patches to introduce them correct at > first place? > Thanks for the guide. Will do it this way in the next version. > > > > Signed-off-by: Yanling Song > > --- > > drivers/net/spnic/base/spnic_cmdq.c | 14 +-- > > drivers/net/spnic/base/spnic_cmdq.h | 6 +- > > drivers/net/spnic/base/spnic_hw_cfg.c | 49 ++++------ > > drivers/net/spnic/base/spnic_hw_cfg.h | 16 ++-- > > drivers/net/spnic/base/spnic_hw_comm.c | 32 ++++--- > > drivers/net/spnic/base/spnic_hw_comm.h | 22 ++--- > > drivers/net/spnic/base/spnic_hwdev.c | 8 +- > > drivers/net/spnic/base/spnic_hwif.c | 52 +++++------ > > drivers/net/spnic/base/spnic_hwif.h | 22 ++--- > > drivers/net/spnic/base/spnic_mgmt.c | 9 +- > > drivers/net/spnic/base/spnic_mgmt.h | 4 +- > > drivers/net/spnic/base/spnic_nic_cfg.c | 110 > > +++++++++++------------ drivers/net/spnic/base/spnic_nic_cfg.h | > > 84 ++++++++--------- drivers/net/spnic/base/spnic_nic_event.c | 30 > > +++---- drivers/net/spnic/base/spnic_nic_event.h | 10 +-- > > drivers/net/spnic/base/spnic_wq.c | 3 +- > > drivers/net/spnic/base/spnic_wq.h | 2 +- > > drivers/net/spnic/spnic_ethdev.c | 10 +-- > > drivers/net/spnic/spnic_io.c | 34 +++---- > > drivers/net/spnic/spnic_io.h | 10 +-- > > drivers/net/spnic/spnic_rx.c | 4 +- > > drivers/net/spnic/spnic_tx.c | 4 +- > > 22 files changed, 252 insertions(+), 283 deletions(-) > > > <...> >