From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EE08A04A6; Mon, 24 Jan 2022 00:53:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 286C440140; Mon, 24 Jan 2022 00:53:45 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 1EC5640040 for ; Mon, 24 Jan 2022 00:53:43 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id s61-20020a17090a69c300b001b4d0427ea2so18737570pjj.4 for ; Sun, 23 Jan 2022 15:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iMP2FEjGCXA+MgMmiYTk/4ouVJ3U4DRDZs2dkAyQ9Cw=; b=kW0JuAPIsXqcavskgycldSTuoRYyHfAYS00ibsa1VZKTHLGZxhvpgGj1qV/4c7+rv0 rnX5ye33cpbvDkh2FveBZSdSHyZ+VCjdD00MAvv32dB/cGfoqAfEi+SVZmR9ySKqWuXg oLUBhyMTpb0gml3XrQOsd/YjWmkYiNuM/PQCWaHYACQt43TunHhHH4usD61R2Z6DFL/M DuvdCfhlJnLP17hFv7ScNx3Pg05qgc+oxU+GET69YBDlsn0RvnVvtOak1Iu3OeEC2SxL mGNdMeFnz9zuvYy+AmsKuH3lGOQit7jBqR8To2YwuWh3VflXGk6qiLcFn6RdEml0V7s9 fC1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iMP2FEjGCXA+MgMmiYTk/4ouVJ3U4DRDZs2dkAyQ9Cw=; b=jFltA9+emNBL0Ol0I5bn3rQSeBoCOxCnWsXxg0wtMWee/713TUTOhcCv/quN4NxdDe Y9tpM/g/zO01SOiq2sPm4EjEv1lUSvvrBJduxur2lSQB34z+AHn5nfi9HAdiBnTU91uI 0Rg+SOemxLutAOb0SGHo7yLgSNTwjdSfbkLU8aDXFeYW3GPxXBadZdfkafyq1R156e6o 84c4Q9m7Of4JLRg4gQTLl3vAfZ2mZrGut8PSBra8EUo/7V6lTYcnUOQMTUjrJTvNEuFo jeHGbEEU7o3N3yBKYStTbHkBHqwHLrgBhGRihoB5c/qSPrj4LxPYXcL9lOfMyHgyywcH SwEA== X-Gm-Message-State: AOAM533f/n9qRkz+Qig+SE/85NxvNBJ2t+wyMV8ySi6tw9rXWRWSGXpy 9WF/Y7tAjtj58BgJuSt9RvB0jqUhiTv9Bg== X-Google-Smtp-Source: ABdhPJxAZcxBgfYi6bcAxAlixWw//gv1N+Xcybzw89q0PA3IzvukqQsnRxevThaWu7fZcWy76XD56w== X-Received: by 2002:a17:90b:1109:: with SMTP id gi9mr7180190pjb.210.1642982023077; Sun, 23 Jan 2022 15:53:43 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id h9sm13586952pfi.124.2022.01.23.15.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 15:53:42 -0800 (PST) Date: Sun, 23 Jan 2022 15:53:40 -0800 From: Stephen Hemminger To: Michael Barker Cc: Thomas Monjalon , dev@dpdk.org, Ray Kinsella Subject: Re: [PATCH v2] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if. Message-ID: <20220123155340.280b53f1@hermes.local> In-Reply-To: References: <20220117231404.219496-1-mikeb01@gmail.com> <20220117232318.219749-1-mikeb01@gmail.com> <10018405.DAOxP5AVGn@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 24 Jan 2022 10:17:37 +1300 Michael Barker wrote: > On Fri, 21 Jan 2022 at 03:16, Thomas Monjalon wrote: > > > 18/01/2022 00:23, Michael Barker: > > > When using clang with -Wall the use of diagnose_if kicks up a warning, > > > > Please could you copy the warning in the commit log? > > > > I've updated the commit log to be more descriptive (and included the > associated warning). > > > requiring all dpdk includes to be wrapped with the pragma. This change > > > isolates the ignore just the appropriate location and makes it easier > > > for users to apply -Wall,-Werror > > > > Please could you explain how it is related to -Wgcc-compat? > > > > I'm currently working on some code that makes use of DPDK, which is built > with '-Wall,-Werror' enabled. When using the clang toolchain the build > fails as a result of this macro that this patch updates. The workaround > from my application is to wrap all of the DPDK header includes in pragma to > disable the warnings (see below). This has the unfortunate side effect of > disabling this warning across all of the included DPDK headers, which is > not ideal. Hence the reason to submit the patch which disables the warning > just in the location where it occurs. > Fix the issue please, don't suppress it.