From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87FCEA04A6; Mon, 24 Jan 2022 00:55:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 309B240151; Mon, 24 Jan 2022 00:55:50 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 187D440040 for ; Mon, 24 Jan 2022 00:55:49 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id l17so7708346plg.1 for ; Sun, 23 Jan 2022 15:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dOXjPo0kVAkbYg6xLX4dah7AGd3YAGyVtlqfRavIvj0=; b=8FHCg5l6/z1bypPKF6r0lMLIrhjZWKbdyGTs2/aniMk12Kr+zwVCA8SqkrUeZ/+wbq mclrJBLgT0Js5FH17PtyzmsZa/PlP3jyBj7NPU48i6BEH2j5AAVmSN6khCNk0yfe3kmD gZHw4OaJWJbGBQRrAXvm0eRV1ysbUzosJin/RwQ+7OFWxfvdKKTCchcmdRb3f6Ke5Kex 87WWOWZDKaVRQ1tMq5dt3cy9DV/RslApg2wn8+1hnyOf8Qqn6e1jZ0nqemGzbiAa01To zU5cJGowIu7eCGWtmuUOe0L0QF/5GB/+Vvo93YM3ar8u7hUKyq/KkNfuRJKieEs48Z8g fvCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dOXjPo0kVAkbYg6xLX4dah7AGd3YAGyVtlqfRavIvj0=; b=SD3nvhRh3N8eInDwWC1ATEBotEWJXvG+djqpvqQwCuDDuJF6klteVyeDyrFMcYqetg z3sxMcPwggsiVvPAzVoscW5coV+52esNre+/aFjQn8bdAfE9PrG1QTNHb35e/CgxGqlF HbvNLAE4gOybrtRoQNY25fJg2TemmNYc1guvQeL89r14f3CImjkLSaCmbvWA65bKnmdM Dz7Mr5rCamjL0+he3PRY0Lo1RuCrJFOAsSgJdMIJ+FyhbkuPoykRH/fJSNR5Z53L1YVU IEB5hHtuJWmg+orum+tpC2RctQi6b+UzYD2JV9NDl6C15ZHqO+I+dc23qbJIpkQD9kIW 39Gw== X-Gm-Message-State: AOAM532IgYlbpBHDYrqELjSv2l9FVpZ/RNrSaZIXsbPsfNCeMEYgcuFf 1KID4qsVrbL0a1yNzQEEqNnO5Q== X-Google-Smtp-Source: ABdhPJyEw3EvcmP9xZRl0G64awoMbtMmf6Mf7YxFntUgVOiGBVH/+8pMglqqi7DHqGwPw8PGQXRVPQ== X-Received: by 2002:a17:902:7b87:b0:14a:bf7b:84da with SMTP id w7-20020a1709027b8700b0014abf7b84damr12376613pll.89.1642982148303; Sun, 23 Jan 2022 15:55:48 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id j11sm14388056pfj.13.2022.01.23.15.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 15:55:47 -0800 (PST) Date: Sun, 23 Jan 2022 15:55:45 -0800 From: Stephen Hemminger To: Michael Barker Cc: dev@dpdk.org, Ray Kinsella Subject: Re: [PATCH v4] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if. Message-ID: <20220123155545.60de272f@hermes.local> In-Reply-To: <20220123212024.19747-1-mikeb01@gmail.com> References: <20220123210751.19182-1-mikeb01@gmail.com> <20220123212024.19747-1-mikeb01@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 24 Jan 2022 10:20:24 +1300 Michael Barker wrote: > When compiling with clang using -Wall (or -Wgcc-compat) the use of > diagnose_if kicks up a warning: > > .../include/rte_interrupts.h:623:1: error: 'diagnose_if' is a clang > extension [-Werror,-Wgcc-compat] > __rte_internal > ^ Which clang version is this? Perhaps the allow internal API could use a different attribute that could work in both cases?